Re: misc doc fixes for REL_12_STABLE

2019-07-12 Thread Liudmila Mantrova
On 7/12/19 7:44 AM, Michael Paquier wrote: On Thu, Jul 11, 2019 at 05:49:26PM +0300, Liudmila Mantrova wrote: Please consider a patch that fixes some trivial issues in new doc fragments (a couple of typos/ambiguities and some tags that affect translation). Thanks for the patch. I have one comm

Re: SPITupleTable members missing in docs

2019-07-12 Thread Fabien COELHO
Hello Daniel, Since this makes the number of internal members far outnumber the public ones, also reword the statement about which fields can be used to try and improve clarity. Patch applies cleanly, doc build ok. To take into account Tom's comment, I'd suggest a middle ground by comment

Re: SPITupleTable members missing in docs

2019-07-12 Thread Tom Lane
Fabien COELHO writes: > To take into account Tom's comment, I'd suggest a middle ground by > commenting a public and private part explicitely in the struct, something > like: >typedef struct { > /* PUBLIC members to be used by callers ... */ > ... > ... > /* PRIVATE memb

Re: SPITupleTable members missing in docs

2019-07-12 Thread Fabien COELHO
Hello, To take into account Tom's comment, I'd suggest a middle ground by commenting a public and private part explicitely in the struct, typedef struct { /* PUBLIC members to be used by callers ... */ /* PRIVATE members, not intended for external usage ... */ } ... ; One pr

Re: misc doc fixes for REL_12_STABLE

2019-07-12 Thread Michael Paquier
On Fri, Jul 12, 2019 at 12:35:49PM +0300, Liudmila Mantrova wrote: > Changing master to primary was my first inclination, but I saw that we have > 8 masters and 4 primaries here. So maybe we should have another consistency > patch (that probably goes beyond this chapter). I can prepare one if you >