I quite like this suggestion, so I’ve changed the patch to do this. Removed
the doc: in the commit message to indicate that this is no longer just touching
documentation.
About v2: applies cleanly, compiles, make check and doc gen ok.
However, the documentation does not look right, field
Fabien COELHO writes:
> Hello Daniel,
>> I quite like this suggestion, so I’ve changed the patch to do this.
>> Removed the doc: in the commit message to indicate that this is no
>> longer just touching documentation.
> And it should be posted to .
Seems excessive, since there's no actual
Hello Daniel,
I quite like this suggestion, so I’ve changed the patch to do this.
Removed the doc: in the commit message to indicate that this is no
longer just touching documentation.
And it should be posted to .
--
Fabien.
> On 14 Jul 2019, at 08:12, Daniel Westermann (DWE)
> wrote:
> This is not true anymore since PostgreSQL 11, isn't it? If agreed, I would
> try to write my first patch to remove that.
Correct, as long as the default isn’t volatile. This was changed in 16828d5c0,
please go ahead and propose a
> On 12 Jul 2019, at 17:04, Tom Lane wrote:
>
> Fabien COELHO writes:
>> To take into account Tom's comment, I'd suggest a middle ground by
>> commenting a public and private part explicitely in the struct, something
>> like:
Thanks for the review!
>> typedef struct {
>> /* PUBLIC
