Re: wal_sender_timeout / wal_receiver_timeout - seconds or milliseconds?

2019-11-05 Thread Bruce Momjian
On Tue, Nov 5, 2019 at 01:27:16PM +0900, Michael Paquier wrote: > On Mon, Nov 04, 2019 at 09:52:34PM -0500, Bruce Momjian wrote: > > The default _value_ is 60 seconds, and we use the 's' to specify > > seconds. What the comment is saying is that if you _don't_ specify any > > units, the integer i

Re: uniqueness and null could benefit from a hint for dba

2019-11-05 Thread Bruce Momjian
On Tue, Oct 29, 2019 at 02:00:38PM +0200, Tuomas Leikola wrote: > On Thu, Oct 24, 2019 at 5:31 PM Bruce Momjian wrote: > > Uh, I am wondering if it is just too details for our docs.  Can you > think of some text and its location? > > > > "Unique indexes on functions can be used to crea

Re: BUG #15912: The units of `autovacuum_vacuum_cost_delay` setting should be documented

2019-11-05 Thread Bruce Momjian
On Thu, Oct 24, 2019 at 02:37:03PM -0400, Tom Lane wrote: > I think this is confusingly bad English, and it's poor exposition > because a minor detail (it must be pretty minor, if we got away > without mentioning it at all for years) is injected into the middle > of the basic statement of the varia

Re: Correction For PostgreSQL Manual

2019-11-05 Thread Bruce Momjian
On Fri, Oct 25, 2019 at 09:56:47PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/bgworker.html > Description: > > The warning about background worker processes at the beginning of Chapter 47 >

Re: Correction For PostgreSQL Manual

2019-11-05 Thread Justin Pryzby
On Tue, Nov 05, 2019 at 08:54:46PM -0500, Bruce Momjian wrote: > On Fri, Oct 25, 2019 at 09:56:47PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/12/bgworker.html > > Description: > > > > Th

Re: Correction For PostgreSQL Manual

2019-11-05 Thread Bruce Momjian
On Tue, Nov 5, 2019 at 08:23:53PM -0600, Justin Pryzby wrote: > It looks like that introduced a different typo in v11 and v12. > > git fetch: > da5cd7a..00ac1ec REL9_4_STABLE -> origin/REL9_4_STABLE > 00ac1eced6204656ae393a719063fbef99a2cf4b => ok > 74d32ee..5c9b0cd REL9_5_STABLE -> origin/REL

Re: Why 'infinity' is not in range '[2019-01-02, infinity]'?

2019-11-05 Thread Bruce Momjian
On Sat, Oct 26, 2019 at 04:15:29PM +0300, Eugen Konkov wrote: > Today I got next ambiguous: > > select tstzrange( 'infinity', null ); > tstzrange > - > [infinity,) > (1 row) > > [DOC](https://www.postgresql.org/docs/12/rangetypes.html) stated: > >if the upper bound of the range i

Re: wal_sender_timeout / wal_receiver_timeout - seconds or milliseconds?

2019-11-05 Thread Michael Paquier
On Tue, Nov 05, 2019 at 10:21:38AM -0500, Bruce Momjian wrote: > Ugh, the "if no unit specified" is true of all the settings. Should we > make that clearer in a more central location. Hmm. Are you thinking about a new single location in the docs? I would be afraid to have something like that ro