Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-08 Thread Tom Lane
Alvaro Herrera writes: > On 2019-Nov-08, Tom Lane wrote: >> So the patch becomes s/virgin/pristine/g plus add a parenthetical >> definition for the first use? Works for me. > Well, there are three uses of the word "virgin". The first is for > "virgin user", and the patch turns that into just "u

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-08 Thread Alvaro Herrera
On 2019-Nov-08, Tom Lane wrote: > Alvaro Herrera writes: > > Hmm. Maybe we can say "pristine database" and then add this explanation > > in a parenthical comment: > > > This is particularly handy when restoring a > > pg_dump dump: the dump script should be restored in a > > pristine

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-08 Thread Daniel Gustafsson
> On 8 Nov 2019, at 16:19, Tom Lane wrote: > So the patch becomes s/virgin/pristine/g plus add a parenthetical > definition for the first use? Works for me. Agreed. cheers ./daniel

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-08 Thread Tom Lane
Alvaro Herrera writes: > Hmm. Maybe we can say "pristine database" and then add this explanation > in a parenthical comment: > This is particularly handy when restoring a > pg_dump dump: the dump script should be restored in a > pristine database (one where no user-defined objects ex

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-08 Thread Alvaro Herrera
On 2019-Nov-08, Tom Lane wrote: > Alvaro Herrera writes: > > Here's a proposed patch. > > I don't like this wording much, because "no user-defined objects" > is not a sufficient specification of what we are talking about. > You need to also capture the property that none of the system- > defined

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-08 Thread Tom Lane
Alvaro Herrera writes: > Here's a proposed patch. I don't like this wording much, because "no user-defined objects" is not a sufficient specification of what we are talking about. You need to also capture the property that none of the system- defined objects have been altered. Now that we explic

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-08 Thread Daniel Gustafsson
> On 8 Nov 2019, at 14:10, Alvaro Herrera wrote: > > On 2019-Nov-08, Daniel Gustafsson wrote: > >> Agreed. I like your suggestion, or the inverse of it: "a database without >> any >> user defined objects". > > Here's a proposed patch. +1, LGTM cheers ./daniel

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-08 Thread Alvaro Herrera
On 2019-Nov-08, Daniel Gustafsson wrote: > Agreed. I like your suggestion, or the inverse of it: "a database without any > user defined objects". Here's a proposed patch. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training &

Re: The word "virgin" used incorrectly and probably better off replaced

2019-11-08 Thread Daniel Gustafsson
> On 7 Nov 2019, at 22:50, Alvaro Herrera wrote: > > On 2019-Nov-07, Bruce Momjian wrote: > >> On Thu, Nov 7, 2019 at 07:55:22PM +0100, Daniel Gustafsson wrote: On 7 Nov 2019, at 16:03, Alvaro Herrera wrote: > We could say "empty", which seems better suited than both "virgin" and >>

tables in the DB is not available after pg_restore.

2019-11-08 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/11/app-pgrestore.html Description: Hi, I have one question about pg_restore tool, tables in the DB is not available after pg_restore. Even if the user is still the owner of table after rest