Re: COPY manual is ambiguous about column list

2019-12-19 Thread David G. Johnston
On Thursday, December 19, 2019, Tom Lane wrote: > "David G. Johnston" writes: > > Seems better to simply talk about each form independently: > > > If a list of columns is specified, COPY TO will only > > copy the data in the specified columns to the file. COPY > > FROM will, by position (i.e.,

Re: COPY manual is ambiguous about column list

2019-12-19 Thread Tom Lane
"David G. Johnston" writes: > Seems better to simply talk about each form independently: > If a list of columns is specified, COPY TO will only > copy the data in the specified columns to the file. COPY > FROM will, by position (i.e., the number of columns listed must > match the number of colum

Re: COPY manual is ambiguous about column list

2019-12-19 Thread David G. Johnston
On Thu, Dec 19, 2019 at 9:46 PM Tom Lane wrote: > Bruce Momjian writes: > > How is the attached patch? > > !In COPY FROM, the number of columns specified > !must match the number of fields in the file; any table columns not > !specified in the COPY FROM column list will insert > !

Re: COPY manual is ambiguous about column list

2019-12-19 Thread Tom Lane
Bruce Momjian writes: > How is the attached patch? !In COPY FROM, the number of columns specified !must match the number of fields in the file; any table columns not !specified in the COPY FROM column list will insert !their default values. Phrasing seems a bit weird to me: you'

Re: document effect of USAGE on foreign server to dblink

2019-12-19 Thread Jeff Janes
On Thu, Dec 19, 2019 at 11:43 AM Bruce Momjian wrote: > On Wed, Nov 27, 2019 at 11:33:03AM -0500, Jeff Janes wrote: > > I think that the permissions around the usage of foreign server names as > > connection names in dblink should be documented, as in the attached. > > Uh, this looks like an odd

Re: COPY manual is ambiguous about column list

2019-12-19 Thread Pavlo Golub
On Thu, 19 Dec 2019 at 17:53, Bruce Momjian wrote: > > On Thu, Nov 28, 2019 at 02:53:03PM +0100, Pavlo Golub wrote: > > On Thu, 28 Nov 2019 at 10:47, Laurenz Albe wrote: > > > > > > On Wed, 2019-11-27 at 17:54 +, PG Doc comments form wrote: > > > > "If a list of columns is specified, COPY wil

Re: COPY manual is ambiguous about column list

2019-12-19 Thread Bruce Momjian
On Thu, Nov 28, 2019 at 02:53:03PM +0100, Pavlo Golub wrote: > On Thu, 28 Nov 2019 at 10:47, Laurenz Albe wrote: > > > > On Wed, 2019-11-27 at 17:54 +, PG Doc comments form wrote: > > > "If a list of columns is specified, COPY will only copy the data in the > > > specified columns to or from t

Re: document effect of USAGE on foreign server to dblink

2019-12-19 Thread Bruce Momjian
On Wed, Nov 27, 2019 at 11:33:03AM -0500, Jeff Janes wrote: > I think that the permissions around the usage of foreign server names as > connection names in dblink should be documented, as in the attached. Uh, this looks like an odd place to document it, since this part is talking about permission

Re: client auth docs seem to have devolved

2019-12-19 Thread Alvaro Herrera
On 2019-Dec-19, Tom Lane wrote: > I wrote: > > Concretely, I propose the attached. Anybody want to editorialize on > > my short descriptions of the auth methods? > > Pushed after a bit more fiddling with the wording. Looks good, thanks. -- Álvaro Herrerahttps://www.2ndQuadrant

Re: client auth docs seem to have devolved

2019-12-19 Thread Tom Lane
I wrote: > Concretely, I propose the attached. Anybody want to editorialize on > my short descriptions of the auth methods? Pushed after a bit more fiddling with the wording. regards, tom lane