Re: Add A Glossary

2020-06-16 Thread Justin Pryzby
On Tue, Jun 16, 2020 at 08:09:26PM -0400, Alvaro Herrera wrote: > diff --git a/doc/src/sgml/glossary.sgml b/doc/src/sgml/glossary.sgml > index 25b03f3b37..e29b55e5ac 100644 > --- a/doc/src/sgml/glossary.sgml > +++ b/doc/src/sgml/glossary.sgml > @@ -395,15 +395,15 @@ > > The base

Re: Add A Glossary

2020-06-16 Thread Alvaro Herrera
On 2020-Jun-09, Jürgen Purtz wrote: > Can you agree to the following definitions? If no, we can alternatively > formulate for each of them: "Under discussion - currently not defined". My > proposals are inspired by chapter 2.2 Concepts: "Tables are grouped into > databases, and a collection of

Re: PGTYPESinterval_free should be instead PGTYPESinterval_new in example.

2020-06-16 Thread Tom Lane
PG Doc comments form writes: > Page: https://www.postgresql.org/docs/12/ecpg-pgtypes.html > Hello! In example of usage PGTYPESinterval_free used PGTYPESinterval_new. > Should be PGTYPESinterval_free. You're right ... I bet that's been wrong for a really long time. Thanks for the report!

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Tom Lane
Bruce Momjian writes: > OK, I didn't think there was enough desire to put it its own paragraph, > but I like the idea of mentioning all of the trigger functions; patch > attached. This one WFM. regards, tom lane

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Bruce Momjian
On Tue, Jun 16, 2020 at 01:39:45PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have developed the attached patch which is in a better direction. > > I still wish you wouldn't jam this topic into an only-marginally-related > sentence. In the case at hand, the point that the existing

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Tom Lane
Bruce Momjian writes: > I have developed the attached patch which is in a better direction. I still wish you wouldn't jam this topic into an only-marginally-related sentence. In the case at hand, the point that the existing text is making is that a no-op update will fire triggers. Which is not

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Bruce Momjian
On Tue, Jun 16, 2020 at 10:08:14AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have created the attached patch to mention > > suppress_redundant_updates_trigger() in this case. I don't think having > > an actual example is warranted. > > I don't like this patch, because in fact >

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Tom Lane
Bruce Momjian writes: > I have created the attached patch to mention > suppress_redundant_updates_trigger() in this case. I don't think having > an actual example is warranted. I don't like this patch, because in fact suppress_redundant_updates_trigger is entirely unrelated to the stated

PGTYPESinterval_free should be instead PGTYPESinterval_new in example.

2020-06-16 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/ecpg-pgtypes.html Description: Hello! In example of usage PGTYPESinterval_free used PGTYPESinterval_new. Should be PGTYPESinterval_free.

Regarding query sort order for "select distinct"

2020-06-16 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/queries-order.html Description: Hi, Good day :) It seems Postgre supports following feature: E121-02ORDER BY columns need not be in select list. But please add postgre behavior for

Re: Not using suppress_redundant_updates_trigger in sql-createtrigger.html#examples

2020-06-16 Thread Bruce Momjian
On Fri, Jun 12, 2020 at 09:09:09AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/bug-reporting.html > Description: > > Hi > I was stumbling across the trigger function >