Re: "stable storage"

2020-08-21 Thread Stephen Frost
Greetings, * Peter Geoghegan (p...@bowt.ie) wrote: > On Fri, Aug 21, 2020 at 3:12 PM Bruce Momjian wrote: > > > Is "stable storage" the same as "durable storage"? Should we rename > > > "stable storage" mentions to "durable storage"? > > > > I have developed the attached doc patch to change

Re: Create a Foreign Table for PostgreSQL CSV Logs

2020-08-21 Thread David G. Johnston
On Fri, Aug 21, 2020 at 2:58 PM Bruce Momjian wrote: > On Fri, Aug 21, 2020 at 09:25:20AM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/12/runtime-config-logging.html > > Description: > > >

Re: Document "59.2. Built-in Operator Classes" have a clerical error?

2020-08-21 Thread Alvaro Herrera
On 2020-Aug-21, Bruce Momjian wrote: > On Mon, Aug 3, 2020 at 04:49:04PM +0900, Michael Paquier wrote: > > On Mon, Aug 03, 2020 at 03:14:56PM +0800, osdba wrote: > > > "range_opsany range type&& &> &< >> << <@ -|- = @> @>", exist double "@>", > > > > > > Should be "<@ @>" ? > > > > Indeed,

Re: Procedures

2020-08-21 Thread David G. Johnston
On Fri, Aug 21, 2020 at 3:52 PM Bruce Momjian wrote: > > > Agreed, this doc area needs help. > > I developed the attached patach for this. Is this sufficient? > For consistency I would change "statement" to "command" at the end of that paragraph . the command. and to contrast with "a

Re: Subscript expressions do not have to evaluate to integers

2020-08-21 Thread David G. Johnston
On Fri, Aug 21, 2020 at 6:22 PM Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Jul 22, 2020 at 02:59:18AM +, PG Doc comments form wrote: > >> I believe a more appropriate statement would acknowledge that at least > some > >> values undergo an explicit-style conversion to an integer. >

Re: Typo in the Section "3.6. Inheritance"

2020-08-21 Thread David G. Johnston
On Fri, Aug 21, 2020 at 4:36 PM Bruce Momjian wrote: > On Wed, Aug 5, 2020 at 11:29:31PM -0700, David G. Johnston wrote: > > > Removing "char" from the tutorial is a nice side-effect that we probably > want > > to do even if we keep "state". > > I think CHAR(2) is fine because it is always 2

Re: Typo in the Section "3.6. Inheritance"

2020-08-21 Thread Michael Paquier
On Fri, Aug 21, 2020 at 07:36:41PM -0400, Bruce Momjian wrote: > How is the attached patch, based on your suggestions? Looks good to me. -- Michael signature.asc Description: PGP signature

Re: Document "59.2. Built-in Operator Classes" have a clerical error?

2020-08-21 Thread Michael Paquier
On Fri, Aug 21, 2020 at 07:16:16PM -0400, Bruce Momjian wrote: > I decided to remove the duplicates and just add "(multiple)" after > operators that have multiple system table entries; patch attached. Sounds like a good idea to me. Thanks. Another idea I had after reading your email would be

Re: Subscript expressions do not have to evaluate to integers

2020-08-21 Thread Tom Lane
Bruce Momjian writes: > On Wed, Jul 22, 2020 at 02:59:18AM +, PG Doc comments form wrote: >> I believe a more appropriate statement would acknowledge that at least some >> values undergo an explicit-style conversion to an integer. > OK, how is the attached patch? "and" is not an improvement

Re: Subscript expressions do not have to evaluate to integers

2020-08-21 Thread Bruce Momjian
On Wed, Jul 22, 2020 at 02:59:18AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/sql-expressions.html > Description: > > Section 4.2.3. Subscripts of the documentation states: > > > Each

Re: typo in sentence

2020-08-21 Thread Bruce Momjian
On Tue, Aug 4, 2020 at 06:03:26PM -0700, David G. Johnston wrote: > On Tuesday, August 4, 2020, Tom Lane wrote: > > Ganesh A Hegde writes: > > There is only a single sentence starting with 'if' and not two. The > phrase > > 'it is therefore ..' is preceded by a comma and not a

Re: Typo in the Section "3.6. Inheritance"

2020-08-21 Thread Bruce Momjian
On Wed, Aug 5, 2020 at 11:29:31PM -0700, David G. Johnston wrote: > On Wed, Aug 5, 2020 at 10:41 PM Michael Paquier wrote: > > On Wed, Aug 05, 2020 at 05:36:56PM -0400, Bruce Momjian wrote: > > On Wed, Aug  5, 2020 at 05:12:43PM -0400, Bruce Momjian wrote: > > > !     type for

Re: Document "59.2. Built-in Operator Classes" have a clerical error?

2020-08-21 Thread Bruce Momjian
On Mon, Aug 3, 2020 at 04:49:04PM +0900, Michael Paquier wrote: > On Mon, Aug 03, 2020 at 03:14:56PM +0800, osdba wrote: > > "range_opsany range type&& &> &< >> << <@ -|- = @> @>", exist double "@>", > > > > Should be "<@ @>" ? > > Indeed, this needs to be improved. Another issue on the same

Re: Procedures

2020-08-21 Thread Bruce Momjian
On Thu, Aug 6, 2020 at 06:10:52PM -0400, Bruce Momjian wrote: > On Thu, Aug 6, 2020 at 02:30:55PM +0100, Robin Abbi wrote: > > PostgreSQL went as far as release 10 without procedures. > > Some third party resources written before 11 loosely conflate procedures > > with > > functions. > > Some

Re: obsolete indexing method "rtree"

2020-08-21 Thread Bruce Momjian
On Fri, Aug 7, 2020 at 05:46:45PM +0200, Jürgen Purtz wrote: > > On 06.08.20 10:12, David G. Johnston wrote: > > On Thu, Aug 6, 2020 at 12:18 AM Jürgen Purtz wrote: > > > > Why? > > Because it can hinder the learning process. > > > FWIW I'd at least fixup

Re: "stable storage"

2020-08-21 Thread Peter Geoghegan
On Fri, Aug 21, 2020 at 3:12 PM Bruce Momjian wrote: > > Is "stable storage" the same as "durable storage"? Should we rename > > "stable storage" mentions to "durable storage"? > > I have developed the attached doc patch to change "stable storage" to > "durable storage". I agree that this is an

Re: "stable storage"

2020-08-21 Thread Bruce Momjian
On Mon, Aug 17, 2020 at 12:52:22PM -0400, Bruce Momjian wrote: > I know we talk about durability a lot, but it seems we mention "stable > storage" much more often than "durable storage" in our docs: ... > Is "stable storage" the same as "durable storage"? Should we rename > "stable storage"

Re: Create a Foreign Table for PostgreSQL CSV Logs

2020-08-21 Thread Bruce Momjian
On Fri, Aug 21, 2020 at 09:25:20AM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/12/runtime-config-logging.html > Description: > > There is some imperfection in PostgreSQL doc. There are two

Re: Request for further clarification on synchronous_commit

2020-08-21 Thread Bruce Momjian
On Wed, Aug 19, 2020 at 11:39:53AM +0200, Kasper Kondzielski wrote: > > On Tue, Aug 18, 2020 at 12:50:34PM +0200, Kasper Kondzielski wrote: > > > Hi, thanks for the reply. > > > > > > To be honest I don't think it is better. Previously paragraph about > > > remote_apply was after paragraph about

Create a Foreign Table for PostgreSQL CSV Logs

2020-08-21 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/runtime-config-logging.html Description: There is some imperfection in PostgreSQL doc. There are two section in documentation how to import PostgreSQL log into sql space and both not