Should 'sum(mvf)' read 'sum(mcv)'...?

2022-08-21 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/row-estimation-examples.html Description: About halfway down this page https://www.postgresql.org/docs/current/row-estimation-examples.html we see the following formula for calculating sel

Re: Typo in description of PROGRAM parameter for the COPY command

2022-08-21 Thread Tom Lane
Daniel Gustafsson writes: > Skimming the page I noticed that we wrap CSV in in all but a few > places, which seemed randomly "chosen". Another sentence which stood out to > me > was this one on FREEZE: > "This violates the normal rules of MVCC visibility and users specifying > shou

Re: Typo in description of PROGRAM parameter for the COPY command

2022-08-21 Thread Daniel Gustafsson
> On 21 Aug 2022, at 20:48, Tom Lane wrote: > > Daniel Gustafsson writes: >> On 21 Aug 2022, at 03:31, PG Doc comments form >> wrote: >>> ...so if you need to pass any arguments to shell command that come >>> from an untrusted source... >>> >>> The "to shell command that come" part should be

Re: Typo in description of PROGRAM parameter for the COPY command

2022-08-21 Thread Tom Lane
Daniel Gustafsson writes: > On 21 Aug 2022, at 03:31, PG Doc comments form wrote: >> ...so if you need to pass any arguments to shell command that come >> from an untrusted source... >> >> The "to shell command that come" part should be changed so it either reads >> like this: >> >> ...so if yo

Re: Typo in description of PROGRAM parameter for the COPY command

2022-08-21 Thread Daniel Gustafsson
> On 21 Aug 2022, at 03:31, PG Doc comments form wrote: >> ...so if you need to pass any arguments to shell command that come > from an untrusted source... > > The "to shell command that come" part should be changed so it either reads > like this: > >> ...so if you need to pass any arguments to

Re: relpages in pg_class

2022-08-21 Thread Shangzi Xie
Page and block can be used interchangeably, but the description of relpages in the documentation can be confusing to someone who doesn't care much about the difference between page and block. When I want to count pages from a table, maybe the keywords I should look for should be "the number of", bu

Typo in description of PROGRAM parameter for the COPY command

2022-08-21 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/sql-copy.html Description: On this page https://www.postgresql.org/docs/current/sql-copy.html the description of the PROGRAM parameter for the COPY command has the following sentence with