Re: `pg_restore --if-exists` clarification

2023-09-28 Thread Tom Lane
"David G. Johnston" writes: >>> .. But pragmatically it doesn't matter, so why not >>> reclassify this as a "warning" or a "notice"? > Because pg_restore is just a client and it is repeating back what the > server tells it. And for the server it is an error to drop an object that > doesn’t exist

Re: `pg_restore --if-exists` clarification

2023-09-28 Thread David G. Johnston
On Thursday, September 28, 2023, Gulyás Attila wrote: > So `--if-exists` simply suppresses any notice / warning that would occur? > That switch causes the drop DDL produced by pg_restore to include if exists clauses. The server then simply treats the DDL as a no-op if said object being dropped

Re: `pg_restore --if-exists` clarification

2023-09-28 Thread Gulyás Attila
So `--if-exists` simply suppresses any notice / warning that would occur? I'm sorry if I come off as obtuse, but I have literally no idea what `--clean` and `--if-exists` do when used together. I took the quote from the Stackoverflow answer on face value, because it sounded plausible and I can't u

Re: `pg_restore --if-exists` clarification

2023-09-28 Thread Kirk Parker
On Thu, Sep 28, 2023, 05:52 PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/app-pgrestore.html > Description: > > Good Morning, > > In the `pg_restore` docs > (https://www.postgresql.org/docs/current/ap

Re: Is CREATE INDEX dependent on the session?

2023-09-28 Thread Tom Lane
Laurenz Albe writes: > On Wed, 2023-09-27 at 11:23 -0400, Ilya Priven wrote: >> Would it warrant a clarification in the documentation: >> - Whether CREATE INDEX is aborted if the session is disconnected, assuming >> it's not in a transaction? > It is aborted as soon as the server realizes that t

Re: Make SSPI documentation clearer

2023-09-28 Thread Bruce Momjian
On Wed, Sep 27, 2023 at 07:09:02PM -0400, Bruce Momjian wrote: > On Sun, Mar 12, 2023 at 08:36:53PM -0400, Stephen Frost wrote: > > > When the server is on a non-Windows platform then the server must use > > > GSSAPI > > > if it wants to authenticate the client either via Kerberos or via Active >

`pg_restore --if-exists` clarification

2023-09-28 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/app-pgrestore.html Description: Good Morning, In the `pg_restore` docs (https://www.postgresql.org/docs/current/app-pgrestore.html), `--if-exists` states that it is to > Use conditional

Re: Hyperlinks for source file references

2023-09-28 Thread Daniel Gustafsson
> On 27 Sep 2023, at 15:18, Peter Eisentraut wrote: > > On 25.09.23 13:09, Daniel Gustafsson wrote: >> Commit b73c3a11963 introduced xyz >> hyperlinks for files in the postgres source tree by linking to the gitweb >> interface at git.postgresql.org. This, IMO, makes the content referred to >> m