Re: [DOCS] Confusing Trigger Docs.

2023-11-22 Thread Laurenz Albe
On Wed, 2023-11-22 at 14:49 -0800, Peter Geoghegan wrote: > I don't think that your proposed wording for this is an improvement. Well, the existing wording is impenetrable even for someone with some PostgreSQL knowledge, like me. Yours, Laurenz Albe

Re: [DOCS] Confusing Trigger Docs.

2023-11-22 Thread Peter Geoghegan
On Wed, Nov 22, 2023 at 1:13 PM Bruce Momjian wrote: > I think I found out what it trying to say by looking at the INSERT > manual page: > > Note that the effects of all per-row BEFORE > INSERT triggers are reflected in > excluded values, since those effects may > h

Re: [DOCS] Confusing Trigger Docs.

2023-11-22 Thread David G. Johnston
On Wed, Nov 22, 2023 at 2:13 PM Bruce Momjian wrote: > On Wed, Nov 22, 2023 at 10:31:25AM +0100, Laurenz Albe wrote: > > I agree that the paragraph you are trying to improve needs it. > > > > I am not sure about that last sentence you added: > > > > The modification of > > EXCLUDED columns ha

Re: [DOCS] Double negation in parameter description

2023-11-22 Thread Bruce Momjian
On Wed, Feb 8, 2017 at 03:27:43PM +, a...@robillo.net wrote: > The following documentation comment has been logged on the website: > > Page: > https://www.postgresql.org/docs/9.6/static/sql-refreshmaterializedview.html > Description: > > In the description of the CONCURRENTLY parameter (3rd

Re: [DOCS] Confusing Trigger Docs.

2023-11-22 Thread Bruce Momjian
On Wed, Nov 22, 2023 at 10:31:25AM +0100, Laurenz Albe wrote: > I agree that the paragraph you are trying to improve needs it. > > I am not sure about that last sentence you added: > > The modification of > EXCLUDED columns has similar interactions. > > How do you modify an EXCLUDED column?

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread David G. Johnston
On Wed, Nov 22, 2023 at 12:26 PM Bruce Momjian wrote: > On Wed, Nov 22, 2023 at 06:26:45PM +0100, Álvaro Herrera wrote: > > On 2023-Nov-22, Laurenz Albe wrote: > > > > > I think the example had best be at "8.5.2. Date/Time Output", in > > > doc/src/sgml/datatype.sgml around line 2552. > > > > Act

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread Bruce Momjian
On Wed, Nov 22, 2023 at 06:26:45PM +0100, Álvaro Herrera wrote: > On 2023-Nov-22, Laurenz Albe wrote: > > > I think the example had best be at "8.5.2. Date/Time Output", in > > doc/src/sgml/datatype.sgml around line 2552. > > Actually, isn't that a strange location? Chapter 8.5.2 is about the >

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread Alvaro Herrera
On 2023-Nov-22, Laurenz Albe wrote: > I think the example had best be at "8.5.2. Date/Time Output", in > doc/src/sgml/datatype.sgml around line 2552. Actually, isn't that a strange location? Chapter 8.5.2 is about the datatype itself, and there's already a cross-link to Section 9.8 for to_char()

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread Erik Wienhold
On 2023-11-22 17:58 +0100, Bruce Momjian wrote: > On Wed, Nov 22, 2023 at 02:02:02PM +0100, Erik Wienhold wrote: > > > > + > > > > + > > > > +to_char(current_timestamp AT TIME ZONE 'UTC', > > > > +'-MM-DD"T"HH24:MI:SSZ') outputs the current UTC > > > > This might be

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread Bruce Momjian
On Wed, Nov 22, 2023 at 02:02:02PM +0100, Erik Wienhold wrote: > > > + > > > + > > > +to_char(current_timestamp AT TIME ZONE 'UTC', > > > +'-MM-DD"T"HH24:MI:SSZ') outputs the current UTC > > This might be excessive, but should we have an example with other time > zon

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread Erik Wienhold
On 2023-11-22 10:14 +0100, Laurenz Albe wrote: > On Tue, 2023-11-21 at 23:33 -0500, Bruce Momjian wrote: > > On Fri, Feb 17, 2017 at 04:01:54PM +, juha.musto...@iki.fi wrote: > > > The following documentation comment has been logged on the website: > > > > > > Page: https://www.postgresql.org/

Re: [DOCS] Confusing Trigger Docs.

2023-11-22 Thread Laurenz Albe
On Tue, 2023-11-21 at 21:01 -0500, Bruce Momjian wrote: > On Thu, Aug 31, 2017 at 09:22:22AM -0700, Peter Geoghegan wrote: > > On Thu, Aug 31, 2017 at 6:25 AM, Bruce Momjian wrote: > > > On Mon, Jul 3, 2017 at 08:07:10PM +, n...@fairwindsoft.com wrote: > > > > The following documentation comm

Re: [DOCS] intagg.sgml: example wrongly named and does not compile

2023-11-22 Thread Laurenz Albe
On Tue, 2023-11-21 at 22:27 -0500, Bruce Momjian wrote: > I like this six year old patch so would like to apply it to master, > attached. +1, since it is arguably a bug fix. Yours, Laurenz Albe

Re: [DOCS] Add example about date ISO format

2023-11-22 Thread Laurenz Albe
On Tue, 2023-11-21 at 23:33 -0500, Bruce Momjian wrote: > On Fri, Feb 17, 2017 at 04:01:54PM +, juha.musto...@iki.fi wrote: > > The following documentation comment has been logged on the website: > > > > Page: https://www.postgresql.org/docs/9.6/static/functions-formatting.html > > Description