Re: column_name of ALTER MATERIALIZED VIEW should only refer to an existing column

2024-05-21 Thread Michael Paquier
On Wed, May 22, 2024 at 02:59:37AM +0200, Erik Wienhold wrote: > Here's a patch for $SUBJECT. Looks like the current wording was copied > from ALTER TABLE. In ALTER VIEW we correctly state that column_name > must be an existing column. Fun. You are right, none of the patterns supported by this

Re: Ambiguous description on new columns

2024-05-21 Thread David G. Johnston
On Tuesday, May 21, 2024, Peter Smith wrote: > > > > > Each publication can optionally specify which columns of each table are > replicated to subscribers. The table on the subscriber side must have at > least all the columns that are published. If no column list is specified, > then all columns

Re: Ambiguous description on new columns

2024-05-21 Thread Peter Smith
On Wed, May 22, 2024 at 1:22 PM David G. Johnston wrote: > > On Tue, May 21, 2024 at 7:48 PM Peter Smith wrote: >> >> >> I think the following small change will remove any ambiguity: >> >> BEFORE >> If no column list is specified, any columns added later are >> automatically replicated. >> >> SUG

Re: Ambiguous description on new columns

2024-05-21 Thread David G. Johnston
On Tue, May 21, 2024 at 7:48 PM Peter Smith wrote: > > I think the following small change will remove any ambiguity: > > BEFORE > If no column list is specified, any columns added later are > automatically replicated. > > SUGGESTION > If no column list is specified, any columns added to the table

Re: Ambiguous description on new columns

2024-05-21 Thread David G. Johnston
On Tue, May 21, 2024 at 3:40 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: > https://www.postgresql.org/docs/16/logical-replication-col-lists.html > Description: > > The documentation on this page mentions: > > "If no column list is

Re: Ambiguous description on new columns

2024-05-21 Thread Peter Smith
On Tue, May 21, 2024 at 8:40 PM PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/16/logical-replication-col-lists.html > Description: > > The documentation on this page mentions: > > "If no column list is

column_name of ALTER MATERIALIZED VIEW should only refer to an existing column

2024-05-21 Thread Erik Wienhold
Here's a patch for $SUBJECT. Looks like the current wording was copied from ALTER TABLE. In ALTER VIEW we correctly state that column_name must be an existing column. -- Erik >From 1d7accf2311f4fda2d8ef9a0485985620c5b4b39 Mon Sep 17 00:00:00 2001 From: Erik Wienhold Date: Wed, 22 May 2024 02:3

Re: Ambiguous description on new columns

2024-05-21 Thread Guillaume Lelarge
Hi, Le mar. 21 mai 2024 à 12:40, PG Doc comments form a écrit : > The following documentation comment has been logged on the website: > > Page: > https://www.postgresql.org/docs/16/logical-replication-col-lists.html > Description: > > The documentation on this page mentions: > > "If no column li

Re: 52.38 pg_proc (postgresql version 14)

2024-05-21 Thread Laurenz Albe
On Mon, 2024-05-20 at 21:07 +, PG Doc comments form wrote: > Page: https://www.postgresql.org/docs/14/catalog-pg-proc.html > Description: > > I don't know if this is a documentation problem or an error in pg_proc. > > The document, for the "prokind" column state the following: > f for

Ambiguous description on new columns

2024-05-21 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/logical-replication-col-lists.html Description: The documentation on this page mentions: "If no column list is specified, any columns added later are automatically replicated." It feels

52.38 pg_proc (postgresql version 14)

2024-05-21 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/catalog-pg-proc.html Description: I don't know if this is a documentation problem or an error in pg_proc. The document, for the "prokind" column state the following: f for a normal

Fundamental Architecture of PostgreSQL

2024-05-21 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/16/tutorial-arch.html Description: PostgreSQL uses a client/server architecture. As is typical of client/server applications, the client and the server can be on different hosts. In that case