Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-20 Thread Sergei Katkovsky
On Sat, Oct 18, 2025 at 2:36 AM Laurenz Albe wrote: > But perhaps it is really better to leave things as they are now, perhaps > replacing "blank-trimming", perhaps as "variable-length string that ignores > training blanks". Looks like nobody is against "insignificant/ignorable trailing whitespa

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-18 Thread Sergei Katkovsky
On Thu, Oct 16, 2025 at 11:18 PM David G. Johnston wrote: >> > Think of padding as a noun, not a verb. “The value contains padding”. >> > Not, “ I am padding the value”. > > In PostgreSQL the behavior and stored contents/representation of a value are > not influenced by a type modifier. It i

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Sergei Katkovsky
On Thu, Oct 16, 2025 at 10:11 PM David G. Johnston wrote: > The spaces added to the end of a bpchar manually can and are considered > “padding” - or “present but lack semantic/value significance”. The reason > they are not padding for varchar is that such spaces are considered part of > the st

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Sergei Katkovsky
> I don't understand why any of these variants are better than the > original wording "blank-padded". That has the non-negligible > advantage of corresponding to the type name, and furthermore > appears in many other places in our docs and source code. The wording for BPCHAR (not to be confused w

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Sergei Katkovsky
On Fri, Oct 17, 2025 at 4:49 PM Laurenz Albe wrote: > "bpchar" and "varchar", when used without type modifier, are actually > identical: > > SELECT octet_length(BPCHAR 'x '), >octet_length(VARCHAR 'x '), >octet_length(TEXT 'x '); > > octet_length │ octet_length │ octet_leng

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Sergei Katkovsky
On Fri, Oct 17, 2025 at 5:46 PM David G. Johnston wrote: > "Insignificant trailing blanks." OK, looks good to me too. With best regards, Sergei Katkovskii

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Sergei Katkovsky
Hello, > I think "blank-insignificant" is slightly better than "blank-ignoring". Yes, I agree. And there is also "blank-agnostic" if you prefer fancy expressions :) > Please take a look at the attached patch. If you'd like your name > included in the commit, please send it as you'd like it to

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-17 Thread Sergei Katkovsky
On Fri, Oct 17, 2025 at 1:08 AM David G. Johnston wrote: > > > I’m just trying to phrase the documentation for bpchar so that the “bp”, > which stands for “blank-padded”, is justified. That's what I thought. Yes, unfortunately, bp stands for “blank-padded”, but this name is wrong and misleading.

Re: BPCHAR description in 8.3. Character Types is misleading and incomplete

2025-10-16 Thread Sergei Katkovsky
On Thu, Oct 16, 2025 at 4:36 PM David G. Johnston wrote: > > A given value has a finite length and there is just no restriction on what > that length is. All trailing spaces in the input are considered padding for > purposes of comparison i.e., manually padding is added by the user as opposed