Re: 'value' has special behaviour in alter system

2023-10-31 Thread Bruce Momjian
On Tue, Oct 24, 2023 at 02:36:14PM -0400, Bruce Momjian wrote: > On Tue, Oct 24, 2023 at 02:05:53PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > I have developed the attached patch to document this. > > > > This seems a little imprecise: > > > > + Values with non-alphanumeric

Re: 'value' has special behaviour in alter system

2023-10-24 Thread Bruce Momjian
On Tue, Oct 24, 2023 at 02:05:53PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I have developed the attached patch to document this. > > This seems a little imprecise: > > + Values with non-alphanumeric characters must be quoted. > > I think accurate is more like "Values that are

Re: 'value' has special behaviour in alter system

2023-10-24 Thread Tom Lane
Bruce Momjian writes: > I have developed the attached patch to document this. This seems a little imprecise: + Values with non-alphanumeric characters must be quoted. I think accurate is more like "Values that are neither a number nor a valid identifier must be quoted." Also, that para

Re: 'value' has special behaviour in alter system

2023-10-24 Thread Bruce Momjian
On Thu, Dec 15, 2022 at 12:10:27PM -0500, Tom Lane wrote: > "Jonathan S. Katz" writes: > > On 12/15/22 10:50 AM, David G. Johnston wrote: > >> I suggest changing it to: > >> SET configuration_parameter { TO | = } { value [, ...] | DEFAULT } > > > +1 in general. I would also suggest we add an

Re: 'value' has special behaviour in alter system

2022-12-15 Thread Tom Lane
"Jonathan S. Katz" writes: > On 12/15/22 10:50 AM, David G. Johnston wrote: >> I suggest changing it to: >> SET configuration_parameter { TO | = } { value [, ...] | DEFAULT } > +1 in general. I would also suggest we add an example in the Examples > section to show what the output is when you

Re: 'value' has special behaviour in alter system

2022-12-15 Thread Jonathan S. Katz
On 12/15/22 10:50 AM, David G. Johnston wrote: On Thu, Dec 15, 2022 at 4:45 AM PG Doc comments form mailto:nore...@postgresql.org>> wrote: The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/15/sql-altersystem.html

Re: 'value' has special behaviour in alter system

2022-12-15 Thread David G. Johnston
On Thu, Dec 15, 2022 at 4:45 AM PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/15/sql-altersystem.html > Description: > > Documentation say > ALTER SYSTEM SET configuration_parameter { TO | = } { value |

'value' has special behaviour in alter system

2022-12-15 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/15/sql-altersystem.html Description: Documentation say ALTER SYSTEM SET configuration_parameter { TO | = } { value | 'value' | DEFAULT } The variant 'value' has special, not obvious