11.7. Indexes on Expressions

2021-12-16 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/indexes-expressional.html Description: Regarding the paragraph (_emphasis_ added): > Index expressions are relatively expensive to maintain, because the derived expression(s) must be comp

11.7. Indexes on Expressions

2020-04-10 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/indexes-expressional.html Description: It appears as if the paragraph beginning: "If we were to declare this index UNIQUE..." actually belongs just before the paragraph beginning: "Expres

Re: 11.7. Indexes on Expressions

2021-12-16 Thread Bruce Momjian
On Thu, Dec 16, 2021 at 04:57:37PM +, PG Doc comments form wrote: > The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/14/indexes-expressional.html > Description: > > Regarding the paragraph (_emphasis_ added): > > > Index expression

Re: 11.7. Indexes on Expressions

2021-12-17 Thread Chris Lowder
Thank you for that (speedy) explanation and patch Bruce! That all makes perfect sense.  Cheers, - Chris On December 16, 2021, Bruce Momjian wrote: > On Thu, Dec 16, 2021 at 04:57:37PM +, PG Doc comments form wrote: > > The following documentation comment has been logged on the website: > > 

Re: 11.7. Indexes on Expressions

2021-12-17 Thread Bruce Momjian
On Fri, Dec 17, 2021 at 09:41:32AM +, Chris Lowder wrote: > Thank you for that (speedy) explanation and patch Bruce! That all makes > perfect > sense.  There are actually two questions being addressed here: 1. In what cases are new index entries added, and for which indexes? 2. In what cas

Re: 11.7. Indexes on Expressions

2021-12-22 Thread David G. Johnston
On Fri, Dec 17, 2021 at 2:43 PM Bruce Momjian wrote: > I am attaching an updated patch which mentions non-HOT updates for > expression indexes. > Thanks. I'm a bit concerned that before this patch the only place we mentioned HOTin the docs is in the appendix acronym listing which points to the

Re: 11.7. Indexes on Expressions

2021-12-22 Thread Bruce Momjian
On Wed, Dec 22, 2021 at 02:40:12PM -0700, David G. Johnston wrote: > On Fri, Dec 17, 2021 at 2:43 PM Bruce Momjian wrote: > > I am attaching an updated patch which mentions non-HOT updates for > expression indexes. > > > Thanks.  I'm a bit concerned that before this patch the only place

Re: 11.7. Indexes on Expressions

2021-12-22 Thread David G. Johnston
On Wed, Dec 22, 2021 at 2:45 PM Bruce Momjian wrote: > On Wed, Dec 22, 2021 at 02:40:12PM -0700, David G. Johnston wrote: > > On Fri, Dec 17, 2021 at 2:43 PM Bruce Momjian wrote: > > > > I am attaching an updated patch which mentions non-HOT updates for > > expression indexes. > > > > >

Re: 11.7. Indexes on Expressions

2021-12-22 Thread Bruce Momjian
On Wed, Dec 22, 2021 at 03:06:12PM -0700, David G. Johnston wrote: > On Wed, Dec 22, 2021 at 2:45 PM Bruce Momjian wrote: > Not sure what else we can do --- it would be odd to explain it in the > expression index docs. > > > > Found another one: > > https://www.postgresql.org/docs/curr

Re: 11.7. Indexes on Expressions

2021-12-22 Thread Bruce Momjian
On Wed, Dec 22, 2021 at 05:09:53PM -0500, Bruce Momjian wrote: > On Wed, Dec 22, 2021 at 03:06:12PM -0700, David G. Johnston wrote: > > On Wed, Dec 22, 2021 at 2:45 PM Bruce Momjian wrote: > > Not sure what else we can do --- it would be odd to explain it in the > > expression index docs.

Re: 11.7. Indexes on Expressions

2021-12-22 Thread David G. Johnston
On Wed, Dec 22, 2021 at 3:09 PM Bruce Momjian wrote: > On Wed, Dec 22, 2021 at 03:06:12PM -0700, David G. Johnston wrote: > > On Wed, Dec 22, 2021 at 2:45 PM Bruce Momjian wrote: > > Not sure what else we can do --- it would be odd to explain it in the > > expression index docs. > > > >

Re: 11.7. Indexes on Expressions

2021-12-22 Thread David G. Johnston
On Wed, Dec 22, 2021 at 3:13 PM Bruce Momjian wrote: > I think our _big_ missing information is a definition of HOT updates and > that updating a column involved in an index disables HOT updates. > Along those lines adding "51.7 Special Considerations for Updates" would be minimally invasive. H

Re: 11.7. Indexes on Expressions

2021-12-22 Thread Peter Geoghegan
On Wed, Dec 22, 2021 at 2:13 PM Bruce Momjian wrote: > I think our _big_ missing information is a definition of HOT updates and > that updating a column involved in an index disables HOT updates. I *strongly* agree that that's the single most important piece of information, by far. Though we coul

Re: 11.7. Indexes on Expressions

2020-04-10 Thread Tom Lane
PG Doc comments form writes: > Page: https://www.postgresql.org/docs/12/indexes-expressional.html > It appears as if the paragraph beginning: "If we were to declare this index > UNIQUE..." > actually belongs just before the paragraph beginning: "Expression indexes > also allow control over..." >

11.7 Indexes on Expressions: editorial correction

2020-05-19 Thread PG Doc comments form
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/12/indexes-expressional.html Description: The paragraph that begins "If we were to declare this index UNIQUE,..." refers to the index test1_lower_col1_idx, not to the test1_uniq_int index it

Re: 11.7 Indexes on Expressions: editorial correction

2020-05-19 Thread Tom Lane
PG Doc comments form writes: > The paragraph that begins "If we were to declare this index UNIQUE,..." > refers to the index test1_lower_col1_idx, not to the test1_uniq_int index it > currently follows. It would appear the latter example was spliced into the > middle of discussing the former. Yes

Re: 11.7 Indexes on Expressions: editorial correction

2020-05-21 Thread Bruce Momjian
On Tue, May 19, 2020 at 10:32:01AM -0400, Tom Lane wrote: > PG Doc comments form writes: > > The paragraph that begins "If we were to declare this index UNIQUE,..." > > refers to the index test1_lower_col1_idx, not to the test1_uniq_int index it > > currently follows. It would appear the latter ex