Re: Add small detail to RAISE statement descripton

2024-07-18 Thread Tom Lane
Laurenz Albe writes: > On Mon, 2024-07-15 at 21:30 +0300, Igor Gnatyuk wrote: >> Attached you will find new patch version fix_doc_raise_v4.patch, >> please check it out. > Thanks. I have marked the patch as "ready for committer". I fooled with the wording a bit more and pushed it. Thanks for th

Re: Add small detail to RAISE statement descripton

2024-07-15 Thread Laurenz Albe
On Mon, 2024-07-15 at 21:30 +0300, Igor Gnatyuk wrote: > I tried to take your comments into account: > > - added a missing comma > - still left a verbose version ;) > - made the last sentence more complete (according to the 2nd option). > > Attached you will find new patch version fix_doc_raise_v

Re: Add small detail to RAISE statement descripton

2024-07-15 Thread Igor Gnatyuk
Hi, thanks for the review. I tried to take your comments into account: - added a missing comma - still left a verbose version ;) - made the last sentence more complete (according to the 2nd option). Attached you will find new patch version fix_doc_raise_v4.patch, please check it out. Thanks again

Re: Add small detail to RAISE statement descripton

2024-07-10 Thread Laurenz Albe
On Wed, 2024-05-22 at 18:34 +0300, Igor Gnatyuk wrote: > fix_doc_raise_v3-bios.patch. Please check it out. I think the patch is fine. > + > +condition_name and > +sqlstate specify > +error condition name and the five-character SQLSTATE code respectively. > +See for more inform

Re: Add small detail to RAISE statement descripton

2024-05-23 Thread jian he
On Wed, May 22, 2024 at 11:35 PM Igor Gnatyuk wrote: > > Hi, > > thanks for the response and for your corrections to the patch. > But I checked my changes by running make html, make postgres-A4.pdf, > make postgres-US.pdf and viewing > the results: everything is OK. > > Message > 'old mode 100644

Re: Add small detail to RAISE statement descripton

2024-05-22 Thread Igor Gnatyuk
Hi, thanks for the response and for your corrections to the patch. But I checked my changes by running make html, make postgres-A4.pdf, make postgres-US.pdf and viewing the results: everything is OK. Message 'old mode 100644 new mode 100755' this means, imho, that access rights were changed durin

Re: Add small detail to RAISE statement descripton

2024-05-22 Thread jian he
On Wed, May 22, 2024 at 4:18 PM Igor Gnatyuk wrote: > > Hi. > > Thanks for the comments. I fixed my mistakes by specifying sqlcode > instead of sqlstate and changed the phrase > with an explicit listing of options in USING. In addition, I moved the > paragraph with it below. > Please check out the

Re: Add small detail to RAISE statement descripton

2024-05-22 Thread Igor Gnatyuk
Hi. Thanks for the comments. I fixed my mistakes by specifying sqlcode instead of sqlstate and changed the phrase with an explicit listing of options in USING. In addition, I moved the paragraph with it below. Please check out the new patch version in the attachment. Regards, Igor Gnatyuk вс, 19

Re: Add small detail to RAISE statement descripton

2024-05-19 Thread jian he
On Fri, May 17, 2024 at 4:39 PM Igor Gnatyuk wrote: > > Hi. > > Thank you for your letter. I tried to take your comments into account: > I added explanations to the condition_name, sqlstate options and > slightly changed > the explanations for USING. Attached you will find new patch version. > Tha

Re: Add small detail to RAISE statement descripton

2024-05-17 Thread Igor Gnatyuk
Hi. Thank you for your letter. I tried to take your comments into account: I added explanations to the condition_name, sqlstate options and slightly changed the explanations for USING. Attached you will find new patch version. Thank you for your help. Ragards, Igor Gnatyuk ср, 15 мая 2024 г. в

Re: Add small detail to RAISE statement descripton

2024-05-15 Thread jian he
On Tue, May 14, 2024 at 11:09 PM Igor Gnatyuk wrote: > > Hi, > > There is a slight syntax inaccuracy in the description of the RAISE > statement - assignments of parameter values in USING. > (Chapter 43. PL/pgSQL — SQL Procedural Language / 43.9 Errors and > Messages / 43.9.1 Reporting Errors and

Add small detail to RAISE statement descripton

2024-05-14 Thread Igor Gnatyuk
Hi, There is a slight syntax inaccuracy in the description of the RAISE statement - assignments of parameter values in USING. (Chapter 43. PL/pgSQL — SQL Procedural Language / 43.9 Errors and Messages / 43.9.1 Reporting Errors and Messages): "...You can attach additional information to the error