Re: Link t the souce code

2021-07-22 Thread Alvaro Herrera
On 2021-Jul-21, Tom Lane wrote: > Alvaro Herrera writes: > > Well, we can remove that first paragraph from there and just refer the > > reader to the appendix ... something like this, perhaps. > > +1, though I think you're short a or so. Two markup errors actually, and there were a couple of

Re: Link t the souce code

2021-07-21 Thread Tom Lane
Alvaro Herrera writes: > On 2021-Jul-21, Tom Lane wrote: >> I'm having qualms about recommending this in this particular spot, >> rather than back in Appendix I. Seems like the wrong audience is >> going to be reading this chapter. > Well, we can remove that first paragraph from there and just r

Re: Link t the souce code

2021-07-21 Thread Tom Lane
Peter Eisentraut writes: > On 21.07.21 19:21, Alvaro Herrera wrote: >> Oh, so the current `tar x` knows to uncompress the file without any >> additional options? I've been pointlessly adding 'z', 'j', 'a' for years ... >> That means we can remove the `gunzip` line and replace it with nothing. >

Re: Link t the souce code

2021-07-21 Thread Alvaro Herrera
On 2021-Jul-21, Tom Lane wrote: > Hm ... actually, now that I read the committed patch, I realize that > it's effectively recommending that people build their installations > from the latest commit on master. That might be what aspiring PG > hackers want to do, but it's quite unlikely that Joe DB

Re: Link t the souce code

2021-07-21 Thread Tom Lane
Alvaro Herrera writes: > Seems reasonable -- pushed with that last change. Hm ... actually, now that I read the committed patch, I realize that it's effectively recommending that people build their installations from the latest commit on master. That might be what aspiring PG hackers want to do,

Re: Link t the souce code

2021-07-21 Thread Peter Eisentraut
On 21.07.21 19:21, Alvaro Herrera wrote: On 2021-Jul-21, Peter Eisentraut wrote: On 21.07.21 01:45, Alvaro Herrera wrote: -gunzip postgresql-&version;.tar.gz -tar xf postgresql-&version;.tar +tar xfa postgresql-&version;.tar.gz The "a" option only applies when creating a tar archiv

Re: Link t the souce code

2021-07-21 Thread Alvaro Herrera
On 2021-Jul-21, Tom Lane wrote: > Alvaro Herrera writes: > > That means we can remove the `gunzip` line and replace it with nothing. > > WFM ... > > WFM too. The other thing I wonder about is whether the example shouldn't > be assuming that you chose the .bz2 file instead of the .gz one. Seem

Re: Link t the souce code

2021-07-21 Thread Tom Lane
Alvaro Herrera writes: > Oh, so the current `tar x` knows to uncompress the file without any > additional options? I've been pointlessly adding 'z', 'j', 'a' for years ... I wonder whether that's GNU-tar-specific. But we have GNU-isms elsewhere, eg we removed references to "gmake" years ago. I

Re: Link t the souce code

2021-07-21 Thread Alvaro Herrera
On 2021-Jul-21, Peter Eisentraut wrote: > On 21.07.21 01:45, Alvaro Herrera wrote: > > > > -gunzip postgresql-&version;.tar.gz > > -tar xf postgresql-&version;.tar > > +tar xfa postgresql-&version;.tar.gz > > > > The "a" option only applies when creating a tar archive ("c" command). So > ad

Re: Link t the souce code

2021-07-21 Thread Peter Eisentraut
On 21.07.21 01:45, Alvaro Herrera wrote: -gunzip postgresql-&version;.tar.gz -tar xf postgresql-&version;.tar +tar xfa postgresql-&version;.tar.gz The "a" option only applies when creating a tar archive ("c" command). So adding it here does nothing.

Re: Link t the souce code

2021-07-20 Thread Tom Lane
Alvaro Herrera writes: > v3 rewrites the text more aggressively, so that it opens with > instructions to clone the Git repo, and the released version tarballs > are mentioned further down. The bad thing about this one is that in the > devel version it still talks about files that don't exist; for

Re: Link t the souce code

2021-07-20 Thread Alvaro Herrera
On 2021-May-06, Tom Lane wrote: > Alvaro Herrera writes: > > 3. add a separate paragraph that says to obtain the source from the > > other dir if it's the development one. > > I kinda prefer the last one, because then we could also suggest to use a > > Git repo instead of a tarball, which I supp

Re: Link t the souce code

2021-05-06 Thread Tom Lane
Alvaro Herrera writes: > This text seems to work fine for released versions, but not very well > for development, because it says this: True. > 3. add a separate paragraph that says to obtain the source from the > other dir if it's the development one. > I kinda prefer the last one, because then

Re: Link t the souce code

2021-05-06 Thread Alvaro Herrera
On 2021-May-06, Jonathan S. Katz wrote: > On 5/6/21 6:05 PM, Tom Lane wrote: > > Alvaro Herrera writes: > >> I agree -- if the user wanted packages, they would not be reading that > >> page of the docs. I'd just have it point to the same page that the > >> download page points to for source down

Re: Link t the souce code

2021-05-06 Thread Jonathan S. Katz
On 5/6/21 6:05 PM, Tom Lane wrote: > Alvaro Herrera writes: >> I agree -- if the user wanted packages, they would not be reading that >> page of the docs. I'd just have it point to the same page that the >> download page points to for source downloads, not a version-specific >> one, as in the att

Re: Link t the souce code

2021-05-06 Thread Tom Lane
Alvaro Herrera writes: > I agree -- if the user wanted packages, they would not be reading that > page of the docs. I'd just have it point to the same page that the > download page points to for source downloads, not a version-specific > one, as in the attached patch. +1. I think people reading

Re: Link t the souce code

2021-05-06 Thread Alvaro Herrera
Hello On 2021-May-04, Daniel Westermann (DWE) wrote: > reading this: https://www.postgresql.org/docs/13/install-getsource.html > ... > I wonder if the link should not directly point to the relevant release, e.g.: > https://www.postgresql.org/ftp/source/v13.2/ > > To me that seems to be more conv

Link t the souce code

2021-05-04 Thread Daniel Westermann (DWE)
Hi, reading this: https://www.postgresql.org/docs/13/install-getsource.html ... I wonder if the link should not directly point to the relevant release, e.g.: https://www.postgresql.org/ftp/source/v13.2/ To me that seems to be more convenient than figuring that out on https://www.postgresql.org/d