Re: [DOCS] CIDR address in pg_hba.conf

2011-06-13 Thread Bruce Momjian
Robert Haas wrote: > On Thu, Jun 9, 2011 at 8:42 PM, Bruce Momjian wrote: > > Tom Lane wrote: > >> Fujii Masao writes: > >> > http://developer.postgresql.org/pgdocs/postgres/auth-pg-hba-conf.html > >> >> An IP address is specified in standard dotted decimal notation with > >> >> a CIDR mask lengt

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> Bruce Momjian writes: >>> Perhaps we should allow any SVG file to be imported, but only allow >>> modifications by a single SVG editor. >> How is that sensible? The first change to the file will result in >> exactly the mass of cosmetic diffs that we w

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > I think the big question is whether we can afford to allow multiple SVG > > editor file formats to be checked in, and hence support git diff churn > > as we switch SVG editors for commits. This doesn't seem likely to > > improve anytime soon so we shoul

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Tom Lane
Bruce Momjian writes: > I think the big question is whether we can afford to allow multiple SVG > editor file formats to be checked in, and hence support git diff churn > as we switch SVG editors for commits. This doesn't seem likely to > improve anytime soon so we should just decide and move for

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Bruce Momjian
Ross J. Reedstrom wrote: > On Mon, Jun 13, 2011 at 09:17:04PM +, Thom Brown wrote: > > > > > > xmllint --format for_test_here.svg | wc -l > > > > That restores some of the newlines, but inkscape seems to place tag > > attributes on their own separate lines for readability, so the outputs > > s

Re: [DOCS] Please help me to build docs on the latest 9.1

2011-06-13 Thread MauMau
From: "Robert Haas" 2011/5/15 MauMau : Hello, I'm developing my first patch for PostgreSQL. The target is v9.2. I'm trying to build HTML docs on Windows Vista (32-bit) with the latest v9.1 Git branch, but the build fails. I followed the procedures in the v9.0 manual. Could you tell me what

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Ross J. Reedstrom
On Mon, Jun 13, 2011 at 09:17:04PM +, Thom Brown wrote: > > > > xmllint --format for_test_here.svg | wc -l > > That restores some of the newlines, but inkscape seems to place tag > attributes on their own separate lines for readability, so the outputs > still differ, unless you pass both throu

Re: [DOCS] 7.2. Table Expressions FULL join is only supported with merge-joinable join conditions

2011-06-13 Thread Kevin Grittner
Robert Haas wrote: > Grzegorz Szpetkowski wrote: >> "The join condition specified with ON can also contain conditions >> that do not relate directly to the join." I think the trouble starts with that sentence, which I believe to be completely false and misleading. Simplifying a real-life inst

Re: [DOCS] Improve warnings around CREATE INDEX CONCURRENTLY

2011-06-13 Thread Alvaro Herrera
Excerpts from Robert Haas's message of lun jun 13 12:11:48 -0400 2011: > On Thu, May 26, 2011 at 11:52 AM, Alvaro Herrera > wrote: > >> Back to the doc patch I submitted...is that a useful step toward making > >> this issue visible enough to users for now to help? > Alvaro, did you commit this?

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Thom Brown
On 13 June 2011 20:59, Ross J. Reedstrom wrote: > On Mon, Jun 13, 2011 at 06:36:12PM +, Thom Brown wrote: >> On 13 June 2011 14:35, Greg Smith wrote: >> > I just created a drawing, saved it, then >> > modified it a bit.  The spurious diff from the GUI was quite small:  three >> > lines of jun

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Greg Smith
On 06/13/2011 04:59 PM, Ross J. Reedstrom wrote: However, my copy of OpenOffice.org (3.2.1.4) does evil things to a pencil squiggle drawn in Inkscape. That's why I referred to the lists of open issues in this area. It's possible to get various levels of SVG support working in OpenOffice/Libr

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Ross J. Reedstrom
On Mon, Jun 13, 2011 at 06:36:12PM +, Thom Brown wrote: > On 13 June 2011 14:35, Greg Smith wrote: > > I just created a drawing, saved it, then > > modified it a bit.  The spurious diff from the GUI was quite small:  three > > lines of junk with the filename change and some windowing metadata.

Re: [DOCS] DROP TABLE can be issued by schema owner as well as table owner

2011-06-13 Thread Derrick Rice
> The sentence really should be written a way that indicates that we're > talking about who can execute this particular command, rather than who > can manage to accomplish the removal of the object. I don't think > it's practical to document the latter. We'd have to include: > > - the owner of th

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Joshua D. Drake
On 06/13/2011 07:35 AM, Greg Smith wrote: On 06/13/2011 09:36 AM, Rafael Martinez wrote: It refers among other things to Inkscape [2]. This program generates SVG diagrams and is not so difficult to use. One of the good things with Inkscape is that it works with a standard format so we are not bo

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Thom Brown
On 13 June 2011 14:35, Greg Smith wrote: > I just created a drawing, saved it, then > modified it a bit.  The spurious diff from the GUI was quite small:  three > lines of junk with the filename change and some windowing metadata.  And the > new material added showed in a pretty readable diff as I

Re: [DOCS] Information about WAL Configuration needs an update

2011-06-13 Thread Rafael Martinez
On Mon, 2011-06-13 at 13:24 -0400, Robert Haas wrote: > On Fri, Jun 3, 2011 at 3:42 AM, Rafael Martinez > > > > You can see the graph with the generation of WAL files + some extra > > information for this test here: http://folk.uio.no/rafael/total_wal/ > > > > What do you think? Shouldn't we update

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Ross J. Reedstrom
On Mon, Jun 13, 2011 at 10:35:41AM -0400, Greg Smith wrote: > On 06/13/2011 09:36 AM, Rafael Martinez wrote: > >It refers among other things to Inkscape [2]. This program generates SVG > >diagrams and is not so difficult to use. One of the good things with > >Inkscape is that it works with a standa

Re: [DOCS] Information about WAL Configuration needs an update

2011-06-13 Thread Robert Haas
On Fri, Jun 3, 2011 at 3:42 AM, Rafael Martinez wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Hello > > I am sending this email because I think the section > "28.4. WAL Configuration" [1] of the manual needs to be improved to > avoid some potential configuration problems. > > I have

Re: [DOCS] CIDR address in pg_hba.conf

2011-06-13 Thread Robert Haas
On Thu, Jun 9, 2011 at 8:42 PM, Bruce Momjian wrote: > Tom Lane wrote: >> Fujii Masao writes: >> > http://developer.postgresql.org/pgdocs/postgres/auth-pg-hba-conf.html >> >> An IP address is specified in standard dotted decimal notation with >> >> a CIDR mask length. The mask length indicates th

Re: [DOCS] Add link to current_schemas in config.sgml

2011-06-13 Thread Brendan Jurd
On 14 June 2011 02:39, Robert Haas wrote: > On Tue, May 31, 2011 at 2:27 AM, Brendan Jurd wrote: >> This is just a quick docs patch to add a link to the mention of the >> current_schemas function from 18.10.1. Statement Behavior. > > Your patch got mangled by my email client, but I committed what

Re: [DOCS] Add link to current_schemas in config.sgml

2011-06-13 Thread Brendan Jurd
On 14 June 2011 02:58, Robert Haas wrote: > On Mon, Jun 13, 2011 at 12:55 PM, Brendan Jurd wrote: >> On 14 June 2011 02:39, Robert Haas wrote: >>> On Tue, May 31, 2011 at 2:27 AM, Brendan Jurd wrote: This is just a quick docs patch to add a link to the mention of the current_schemas f

Re: [DOCS] Add link to current_schemas in config.sgml

2011-06-13 Thread Robert Haas
On Mon, Jun 13, 2011 at 1:01 PM, Brendan Jurd wrote: > On 14 June 2011 02:58, Robert Haas wrote: >> On Mon, Jun 13, 2011 at 12:55 PM, Brendan Jurd wrote: >>> On 14 June 2011 02:39, Robert Haas wrote: On Tue, May 31, 2011 at 2:27 AM, Brendan Jurd wrote: > This is just a quick docs patc

Re: [DOCS] 7.2. Table Expressions suggestion about NATURAL JOIN

2011-06-13 Thread Robert Haas
On Tue, May 17, 2011 at 9:47 PM, Grzegorz Szpetkowski wrote: > http://www.postgresql.org/docs/9.0/static/queries-table-expressions.html > http://www.postgresql.org/docs/9.0/static/sql-select.html > > Respectively: > > "Finally, NATURAL is a shorthand form of USING: it forms a USING list > consisti

Re: [DOCS] Add link to current_schemas in config.sgml

2011-06-13 Thread Robert Haas
On Mon, Jun 13, 2011 at 12:55 PM, Brendan Jurd wrote: > On 14 June 2011 02:39, Robert Haas wrote: >> On Tue, May 31, 2011 at 2:27 AM, Brendan Jurd wrote: >>> This is just a quick docs patch to add a link to the mention of the >>> current_schemas function from 18.10.1. Statement Behavior. >> >> Y

Re: [DOCS] DROP TABLE can be issued by schema owner as well as table owner

2011-06-13 Thread Robert Haas
On Fri, May 20, 2011 at 11:42 AM, Derrick Rice wrote: > According to > > http://www.postgresql.org/docs/9.0/interactive/sql-droptable.html > > "DROP TABLE removes tables from the database. Only its owner can drop a > table." > > In fact, the schema owner can drop the table, which is clearly stated

Re: [DOCS] Add link to current_schemas in config.sgml

2011-06-13 Thread Robert Haas
On Tue, May 31, 2011 at 2:27 AM, Brendan Jurd wrote: > This is just a quick docs patch to add a link to the mention of the > current_schemas function from 18.10.1. Statement Behavior. Your patch got mangled by my email client, but I committed what I believe to be the same change. -- Robert Haas

Re: [DOCS] synchronous_standby_names and hot_standby_feedback

2011-06-13 Thread Robert Haas
On Mon, Jun 13, 2011 at 6:29 AM, Fujii Masao wrote: > The GucContext of synchronous_standby_names and hot_standby_feedback > is PGC_SIGHUP, so the following should be added into the explanations about > those parameters. Attached patch does that. Committed. -- Robert Haas EnterpriseDB: http://w

Re: [DOCS] Improve warnings around CREATE INDEX CONCURRENTLY

2011-06-13 Thread Robert Haas
On Thu, May 26, 2011 at 11:52 AM, Alvaro Herrera wrote: > Excerpts from Greg Smith's message of mié may 25 17:04:03 -0400 2011: > >> Sure.  Simon's command string idea might work better, and doing some >> extra lock decoration as you suggested in the above thread would be >> another level of impro

Re: [DOCS] 7.2. Table Expressions FULL join is only supported with merge-joinable join conditions

2011-06-13 Thread Robert Haas
On Mon, May 16, 2011 at 7:32 PM, Grzegorz Szpetkowski wrote: > http://www.postgresql.org/docs/9.0/static/queries-table-expressions.html > > "The join condition specified with ON can also contain conditions that > do not relate directly to the join. This can prove useful for some > queries but need

Re: [DOCS] 7.1. Overview (The SQL Language)

2011-06-13 Thread Tom Lane
Robert Haas writes: > On Wed, May 11, 2011 at 3:38 PM, Grzegorz Szpetkowski > wrote: >> Maybe it's worth adding: >> >> "Assuming that there is a table called table1, this command would >> retrieve all rows and all columns (excluding system columns described >> at Section 5.4) from table1." > Si

Re: [DOCS] Please help me to build docs on the latest 9.1

2011-06-13 Thread Robert Haas
2011/5/15 MauMau : > Hello, > > I'm developing my first patch for PostgreSQL. The target is v9.2. > > I'm trying to build HTML docs on Windows Vista (32-bit) with the latest v9.1 > Git branch, but the build fails. I followed the procedures in the v9.0 > manual. Could you tell me what might be the c

Re: [DOCS] 7.1. Overview (The SQL Language)

2011-06-13 Thread Robert Haas
On Wed, May 11, 2011 at 3:38 PM, Grzegorz Szpetkowski wrote: > http://www.postgresql.org/docs/9.0/static/queries-overview.html > > "Assuming that there is a table called table1, this command would > retrieve all rows and all columns from table1." > > Maybe it's worth adding: > > "Assuming that the

Re: [DOCS] psql's ON_ERROR_STOP is misdocumented

2011-06-13 Thread Robert Haas
On Thu, May 5, 2011 at 11:20 AM, Tom Lane wrote: > The documentation for ON_ERROR_STOP states, or at least implies by > omission, that it only affects the behavior in non-interactive scripts: > >        By default, if non-interactive scripts encounter an error, such >        as a malformed SQL com

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Greg Smith
On 06/13/2011 09:36 AM, Rafael Martinez wrote: It refers among other things to Inkscape [2]. This program generates SVG diagrams and is not so difficult to use. One of the good things with Inkscape is that it works with a standard format so we are not bound to a specific program or non standard f

Re: [DOCS] Missing doc for operator args in alter extension

2011-06-13 Thread Robert Haas
On Thu, Apr 7, 2011 at 9:49 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Apr 4, 2011 at 9:10 PM, Daniele Varrazzo >> wrote: >>> the documentation for ALTER EXTENSION is missing the description for >>> the arguments of the form ADD OPERATOR name (left_type, right_type). > >> I think we mi

Re: [DOCS] [COMMITTERS] pgsql: More foreign table documentation improvements.

2011-06-13 Thread Robert Haas
On Mon, Jun 13, 2011 at 9:56 AM, Fujii Masao wrote: > On Mon, Jun 13, 2011 at 9:30 PM, Robert Haas wrote: >> More foreign table documentation improvements. >> >> Shigeru Hanada, with some additional wordsmithing by me > > This commit caused the following error when I did make html. > >    openjad

Re: [DOCS] [COMMITTERS] pgsql: More foreign table documentation improvements.

2011-06-13 Thread Fujii Masao
On Mon, Jun 13, 2011 at 9:30 PM, Robert Haas wrote: > More foreign table documentation improvements. > > Shigeru Hanada, with some additional wordsmithing by me This commit caused the following error when I did make html. openjade:ddl.sgml:3024:50:E: element "FILE" undefined Attached patch

Re: [DOCS] Documentation and explanatory diagrams

2011-06-13 Thread Rafael Martinez
On Sun, 2011-06-12 at 17:44 -0400, Bruce Momjian wrote: > Thom Brown wrote: > > > > Obviously nothing for this happened in time to make it for 9.1. So > > are diagrams still something we plan to have? > > Agreed, we need to move forward with something, and I am afraid we got > into bike-sheeting

[DOCS] synchronous_standby_names and hot_standby_feedback

2011-06-13 Thread Fujii Masao
Hi, The GucContext of synchronous_standby_names and hot_standby_feedback is PGC_SIGHUP, so the following should be added into the explanations about those parameters. Attached patch does that. - This parameter can only be set in the postgresql.conf file or on the server comman