Re: [DOCS] startup message -> StartupMessage

2016-06-23 Thread Dmitry Igrishin
2016-06-23 16:38 GMT+03:00 Tom Lane : > Bruce Momjian writes: >> On Thu, Jun 23, 2016 at 07:47:10AM +0300, Dmitry Igrishin wrote: >>> Yes, but see the next sentence: "This message includes the names of >>> the user and of the database the user wants to connec

Re: [DOCS] startup message -> StartupMessage

2016-06-22 Thread Dmitry Igrishin
2016-06-23 1:53 GMT+03:00 Bruce Momjian : > On Thu, Jun 9, 2016 at 03:38:40PM +0300, Dmitry Igrishin wrote: >> Hi, >> >> At https://www.postgresql.org/docs/9.6/static/protocol-flow.html >> The StartupMessage instead of "startup message" may looks better for &g

[DOCS] Inaccuracy in fe-protocol3.c

2016-06-15 Thread Dmitry Igrishin
Hi, https://github.com/postgres/postgres/blob/master/src/interfaces/libpq/fe-protocol3.c#L166 says "ERROR messages are displayed using the notice processor". But actually "ERROR messages are handled using the notice receiver". -- // Dmitry. -- Sent via pgsql-docs mailing list (pgsql-docs@postg

[DOCS] startup message -> StartupMessage

2016-06-09 Thread Dmitry Igrishin
Hi, At https://www.postgresql.org/docs/9.6/static/protocol-flow.html The StartupMessage instead of "startup message" may looks better for the reader (at least for me). -- // Dmitry. -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://ww

Re: [DOCS] Typo.

2016-06-07 Thread Dmitry Igrishin
2016-06-07 16:47 GMT+03:00 Tom Lane : > Dmitry Igrishin writes: >> 2016-06-07 15:44 GMT+03:00 Kevin Grittner : >>> I'm pretty sure that this has been discussed on this list before >>> and decided in favor of omitting the hyphenation in such cases. > >> Hm,

Re: [DOCS] Typo.

2016-06-07 Thread Dmitry Igrishin
2016-06-07 15:44 GMT+03:00 Kevin Grittner : > On Tue, Jun 7, 2016 at 6:26 AM, Dmitry Igrishin wrote: > >> In "Internal position: this is defined the same as the P field, but it >> is used when the cursor position refers to an internally generated", >> "i

Re: [DOCS] Typo.

2016-06-07 Thread Dmitry Igrishin
2016-06-07 14:26 GMT+03:00 Dmitry Igrishin : > Hi, > > In "Internal position: this is defined the same as the P field, but it > is used when the cursor position refers to an internally generated", > "internally generated" should be replaced with "internally-

[DOCS] Typo.

2016-06-07 Thread Dmitry Igrishin
Hi, In "Internal position: this is defined the same as the P field, but it is used when the cursor position refers to an internally generated", "internally generated" should be replaced with "internally-generated". https://www.postgresql.org/docs/9.6/static/protocol-error-fields.html -- // Dmitr

Re: [DOCS] pg_prepared_statements

2016-06-02 Thread Dmitry Igrishin
2016-06-03 7:37 GMT+03:00 Peter Eisentraut : > On 6/2/16 1:59 AM, Dmitry Igrishin wrote: >> >> I suggest to use phrase "the PREPARE SQL command" at >> >> https://www.postgresql.org/docs/current/static/view-pg-prepared-statements.html >> Thus, I would repl

[DOCS] pg_prepared_statements

2016-06-01 Thread Dmitry Igrishin
Hi, I suggest to use phrase "the PREPARE SQL command" at https://www.postgresql.org/docs/current/static/view-pg-prepared-statements.html Thus, I would replace: "For prepared statements created via SQL, this is the PREPARE statement submitted by the client. For prepared statements created via the

Re: [DOCS] Moving documentation to XML

2015-11-03 Thread Dmitry Igrishin
2015-11-03 20:46 GMT+03:00 Oleg Bartunov : > > > On Mon, Oct 26, 2015 at 11:53 AM, Alexander Lakhin < > a.lak...@postgrespro.ru> wrote: > >> Hello, Peter. >> >> I've managed to speed up html generation from xml (make xslthtml) from 32 >> min. (in my environment) to 4 min. by modifying slowest XSL

Re: [DOCS] 36.3 Writing Tigger Functions in C

2015-08-11 Thread Dmitry Igrishin
2015-08-11 14:32 GMT+03:00 Marko Tiikkaja : > On 8/11/15 12:47 PM, Dmitry Igrishin wrote: > >> tg_trigtuple: >> I'm not sure why "skip the operation" is here: >> "if you don't want to replace the row with a different one (in the >> case of IN

Re: [DOCS] 36.3 Writing Tigger Functions in C

2015-08-11 Thread Dmitry Igrishin
2015-08-11 13:47 GMT+03:00 Dmitry Igrishin : > Subparagparh 3: > I suggest to replace: > "but it is passed a "context" pointer pointing to a TriggerData > structure" > with > "but it is passed a "context" pointer to a structure of type > Tr

[DOCS] "SQL null" vs "SQL NULL".

2015-08-11 Thread Dmitry Igrishin
I've noticed that there are both of "SQL null" and "SQL NULL" are presents. I'm not sure what is more correct, but I think it would be better to make it consistent. -- // Dmitry.

[DOCS] 36.3 Writing Tigger Functions in C

2015-08-11 Thread Dmitry Igrishin
Subparagparh 3: I suggest to replace: "but it is passed a "context" pointer pointing to a TriggerData structure" with "but it is passed a "context" pointer to a structure of type TriggerData" tg_trigtuple: I'm not sure why "skip the operation" is here: "if you don't want to replace the row with a

[DOCS] 36.2 Visibility of Data Changes

2015-08-11 Thread Dmitry Igrishin
Subparagraph 1: I suggest to replace "Statement-level triggers follow simple visibility rules: none of the changes made by a statement are visible to statement-level triggers that are invoked before the statement, whereas all modifications are visible to statement-level AFTER triggers." with "State

[DOCS] 36.1 Overview of Trigger Behavior

2015-08-11 Thread Dmitry Igrishin
Subparagraph 8: I suggest to replace "BEFORE row-level triggers to execute" with "row-level BEFORE triggers to execute" for consistency. Subparagraph 14: While WHEN can be used with INSERT too, I suggest to replace "However, in an AFTER trigger, the WHEN condition is evaluated just after the row u

[DOCS] 25.1. Comparison of Different Solutions

2015-08-04 Thread Dmitry Igrishin
In "Statement-Based Replication Middleware", in "(PREPARE TRANSACTION and COMMIT PREPARED." missed closing parenthesis. In "Synchronous Multimaster Replication" mentioned that "PostgreSQL does not offer this type of replication, though PostgreSQL two-phase commit (PREPARE TRANSACTION and COMMIT PR

[DOCS] 21.3 Template database

2015-08-04 Thread Dmitry Igrishin
The sentence of 2nd paragraph says: "This is particularly handy when restoring a pg_dump dump" I suggest to add apostrophe: "This is particularly handy when restoring a pg_dump's dump" The sentece of 5th paragraph says: "The principal limitation is that no other sessions can be connected to the so

Re: [DOCS] Confused by example in 13.2.2

2015-08-03 Thread Dmitry Igrishin
2015-08-03 4:35 GMT+03:00 Kevin Grittner : > Dmitry Igrishin wrote: > > > I'm confused a bit by example in 13.2.2: > > In current docs that is the "Repeatable Read Isolation Level" > section. > > > "For example, even a read only transaction at

[DOCS] Confused by example in 13.2.2

2015-08-02 Thread Dmitry Igrishin
Hello, I'm confused a bit by example in 13.2.2: "For example, even a read only transaction at this level may see a control record updated to show that a batch has been completed but not see one of the detail records which is logically part of the batch because it read an earlier revision of the co