On Tue, Nov 11, 2014 at 3:20 PM, Michael Paquier
wrote:
> On Tue, Nov 11, 2014 at 5:26 PM, Marti Raudsepp wrote:
>> Perhaps should be:
>> SELECT and HAVING clauses are evaluated.
> Let's do so then
Oops, that should be my task, but you got there first. :)
>
On Tue, Nov 11, 2014 at 9:52 AM, Michael Paquier
wrote:
> Ah, OK. I wasn't aware of this execution order. Now we could as well
> split the description flow into more tiny paragraphs but this does not
> seem worth it.
Agreed.
Actually now that I read it...
+ values. All aggregate functions
Hi
On Tue, Nov 11, 2014 at 9:14 AM, Michael Paquier
wrote:
> This patch does not compile properly as a is missing, and I
> think that you actually want to add this sect2 block at the bottom the
> sect1 block for conditional functions.
Sorry, I never got around to testing the build because I fou
On Mon, Oct 13, 2014 at 2:05 PM, wrote:
> case when sum( column1 ) = 0
> then 0
> else round( sum( price
> * hours
> / column1 ), 2 )
> I would expect that the else part would never be evaluated.
> Documentation
mno;
Other than that, there's not much to review here, marking as "Ready
for Committer"
Alternative patch attached, let the committer decide.
Regards,
Marti
From 1f90090a65c48bba0057b3866f454e28e3f45f55 Mon Sep 17 00:00:00 2001
From: Marti Raudsepp
Date: Wed, 8 Oct 2014 22:2
On Sat, Aug 30, 2014 at 8:43 PM, Tom Lane wrote:
> I would argue against applying patch 2 at all.
I don't feel strongly about this, I originally didn't plan to submit
this patch at all. But I don't agree with:
> doing it only because some style guide tells
> you to is not the way to approach the
On Mon, Aug 25, 2014 at 10:13 PM, Kevin Grittner wrote:
> For the initial patch, I agree with all except the first change of
> "others'" to "other's" -- the start of the sentence uses "All", so
> there is clearly more than one "other", so the the apostrophe
> belongs after the "s".
Not arguing ag
ns better
> when the combination of words is used as an adjective.
Attached these as patch 0003 so someone who feels more confident can
take a look.
Regards,
Marti
From 05b48b6ce2e0cdf1edbdd76df838a4dc5cdc254a Mon Sep 17 00:00:00 2001
From: Marti Raudsepp
Date: Mon, 25 Aug 2014 19:57:17 +0300
Subject: [
Hi
I ran the Topy typo-fixer (https://github.com/intgr/topy , using rules
developed for Wikipedia) over the PostgreSQL documentation directory.
Attached is a patch with hand-picked fixes that are clearly an
improvement.
There are also some changes that I didn't include that seem somewhat
opiniona
On Fri, Aug 1, 2014 at 2:43 PM, Marko Tiikkaja wrote:
> But the claim about "exactly matching" data types is completely bogus, too
My bad. I remember having a hard time with matching data types in
PL/pgSQL in one instance, but turns out that was with RETURN QUERY,
not INTO.
Anyway, I'd prefer ad
On Fri, Aug 1, 2014 at 12:34 AM, Marko Tiikkaja wrote:
> Here's a patch removing the incorrect part.
I can see how this doc statement can be misunderstood, but I think the
claims are actually about data types, not the number of columns in the
INTO list.
I think clarifying the number of columns q
Hi list,
I was checking out the new JSON features coming in 9.3, really cool stuff!
I noticed a small discrepancy in the documentation, the
"hstore_to_json_loose" example uses hstore_to_json() by accident.
Patch attached.
Regards,
Marti
0001-Fix-discrepancy-in-hstore_to_json_loose-documentati
On Sat, Mar 3, 2012 at 02:16, Marti Raudsepp wrote:
> The documentation needs some updates now that we have index-only
> scans.
Bump. No response for 2 weeks. Anyone?
Regards,
Marti
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription
Hi list,
The documentation needs some updates now that we have index-only
scans. Patch attached. Perhaps the wording can be improved by someone
whose native language is English. But something like this should be
added.
(Not tested, as I couldn't figure out how to build docs on my system)
Regards
On Tue, Dec 6, 2011 at 05:14, Josh Kupershmidt wrote:
> Maybe just tweak
> "will be executed" to "will often be executed", or change "using a
> sequential scan of the entire table." to "using a sequential scan of
> the table, or an index-only scan of one of its indexes".
I don't think we need to
On Wed, Oct 12, 2011 at 19:48, Robert Haas wrote:
> Well, I committed about five doc patches that day, and I had to decide
> for each one whether it was worth back-patching,
> I decided against back-patching this one
Sounds fair.
For what it's worth, I wasn't doubting your judgement. Just that
On Mon, Oct 10, 2011 at 19:58, Robert Haas wrote:
> Committed.
Thanks!
Do you think it should be backported to earlier versions too? As it
stands, the documentation is misleading.
Regards,
Marti
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscripti
On Sat, Sep 17, 2011 at 22:43, Marti Raudsepp wrote:
> Currently the documentation for DELETE and UPDATE doesn't mention that
> the number returned in the command tag is affected by triggers which
> may suppress the change.
Bump! What's the right procedure for submitting do
updates were suppressed by a BEFORE UPDATE trigger. If
count is 0, no rows were
updated by the query (this is not considered an error).
Patch attached.
Regards,
Marti
From e792a7a13fb703d077f2c5d901663e8c1391c6be Mon Sep 17 00:00:00 2001
From: Marti Raudsepp
Date: Sat, 17 Sep 2011 22:14:4
On Fri, Nov 19, 2010 at 05:29, Greg Smith wrote:
> The open question for this one then is the right way for exceptions to act.
> Marti, since you've looked at this a bit already, any thoughts on what that
> should look like? You initially commented that what happens was surprising,
> but I'm not
On Mon, Nov 15, 2010 at 22:25, Tom Lane wrote:
> My inclination is to forget about these doc changes and spend our time
> on fixing the behavior instead.
I thought the first step in fixing a problem is admitting the problem ;)
But you raise a fair point.
Regards,
Marti
--
Sent via pgsql-docs m
t post with the documentation).
Attached is a documentation patch that will apply to PostgreSQL 8.1 - 8.4
Regards,
Marti
From 190d58287b750ad7492485faaf829f262b93e39e Mon Sep 17 00:00:00 2001
From: Marti Raudsepp
Date: Sun, 14 Nov 2010 11:24:43 +0200
Subject: [PATCH] Document current PL/Pytho
the "Database Access" section.
Regards,
Marti
From a9a83614624760d5adc4d0d31f9daa245b88cd72 Mon Sep 17 00:00:00 2001
From: Marti Raudsepp
Date: Tue, 9 Nov 2010 18:19:50 +0200
Subject: [PATCH 1/2] Document current PL/Python exception raising semantics
---
doc/src/sgml/plpython.s
tion "foo"
Regards,
Marti
From b058cb36433aabc34325ce7eb8f5fb67aa2441cb Mon Sep 17 00:00:00 2001
From: Marti Raudsepp
Date: Tue, 9 Nov 2010 12:15:39 +0200
Subject: [PATCH] docs: plpython has plpy.Error instead of plpy.ERROR
---
doc/src/sgml/plpython.sgml |4 ++--
1 files change
24 matches
Mail list logo
