Re: [DOCS] log_min_duration_statement units

2009-04-07 Thread Tom Lane
Bruce Momjian writes: > However, keep in mind that units are _not_ displayed for zero values: Well, zero is zero, so that seems fine. regards, tom lane -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postg

Re: [DOCS] log_min_duration_statement units

2009-04-07 Thread Bruce Momjian
Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian writes: > > > Tom Lane wrote: > > >> You know, it suddenly strikes me that this is going in largely the wrong > > >> direction. > > > > > Right, the problem particularly is with the -1/special values that don't > > > have a real unit. > >

Re: [DOCS] log_min_duration_statement units

2009-04-07 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> You know, it suddenly strikes me that this is going in largely the wrong > >> direction. > > > Right, the problem particularly is with the -1/special values that don't > > have a real unit. > > I don't object to what you did to pos

Re: [DOCS] log_min_duration_statement units

2009-04-07 Thread Tom Lane
Bruce Momjian writes: > Tom Lane wrote: >> You know, it suddenly strikes me that this is going in largely the wrong >> direction. > Right, the problem particularly is with the -1/special values that don't > have a real unit. I don't object to what you did to postgresql.conf.sample, but I think y

Re: [DOCS] log_min_duration_statement units

2009-04-07 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Euler Taveira de Oliveira wrote: > >> My English is not as good as yours but here is another try. Personally, I > >> prefer the second one but... > > > Great, I used your second version. I had already done some of the ones > > you found, but you had m

Re: [DOCS] log_min_duration_statement units

2009-04-07 Thread Tom Lane
Bruce Momjian writes: > Euler Taveira de Oliveira wrote: >> My English is not as good as yours but here is another try. Personally, I >> prefer the second one but... > Great, I used your second version. I had already done some of the ones > you found, but you had many more. I also used your "0

Re: [DOCS] log_min_duration_statement units

2009-04-07 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > Euler Taveira de Oliveira wrote: > > > Bruce Momjian escreveu: > > > > Oops, here is the patch; Euler, would you look to see if you can find > > > > anything else missing; you seem to be good at that. :-) > > > > > > > My English is not as good a

Re: [DOCS] log_min_duration_statement units

2009-04-07 Thread Alvaro Herrera
Bruce Momjian wrote: > Euler Taveira de Oliveira wrote: > > Bruce Momjian escreveu: > > > Oops, here is the patch; Euler, would you look to see if you can find > > > anything else missing; you seem to be good at that. :-) > > > > > My English is not as good as yours but here is another try. Per

Re: [DOCS] log_min_duration_statement units

2009-04-07 Thread Bruce Momjian
Euler Taveira de Oliveira wrote: > Bruce Momjian escreveu: > > Oops, here is the patch; Euler, would you look to see if you can find > > anything else missing; you seem to be good at that. :-) > > > My English is not as good as yours but here is another try. Personally, I > prefer the second o

Re: [DOCS] log_min_duration_statement units

2009-04-06 Thread Euler Taveira de Oliveira
Bruce Momjian escreveu: Oops, here is the patch; Euler, would you look to see if you can find anything else missing; you seem to be good at that. :-) My English is not as good as yours but here is another try. Personally, I prefer the second one but... -- Euler Taveira de Oliveira htt

Re: [DOCS] log_min_duration_statement units

2009-04-06 Thread Bruce Momjian
Bruce Momjian wrote: > Euler Taveira de Oliveira wrote: > > Bruce Momjian escreveu: > > > Someone complained that the default units for log_min_duration_statement > > > was not mentioned in postgresql.conf; this applied patch fixes that. > > > > > IMHO -1ms doesn't make much sense. Also, some oth

Re: [DOCS] log_min_duration_statement units

2009-04-06 Thread Bruce Momjian
Euler Taveira de Oliveira wrote: > Bruce Momjian escreveu: > > Someone complained that the default units for log_min_duration_statement > > was not mentioned in postgresql.conf; this applied patch fixes that. > > > IMHO -1ms doesn't make much sense. Also, some other parameters don't have > units

Re: [DOCS] log_min_duration_statement units

2009-04-06 Thread Tom Lane
Bruce Momjian writes: > It seems illogical to document it this way Yeah, that's what I thought, so why did you do it that way? You could do something like #log_min_duration_statement = -1# -1 is disabled, 0 logs all statements # default unit is ms

Re: [DOCS] log_min_duration_statement units

2009-04-06 Thread Euler Taveira de Oliveira
Bruce Momjian escreveu: Someone complained that the default units for log_min_duration_statement was not mentioned in postgresql.conf; this applied patch fixes that. IMHO -1ms doesn't make much sense. Also, some other parameters don't have units too. They are: archive_timeout, autovacuum_vacuu

Re: [DOCS] log_min_duration_statement units

2009-04-06 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > ! #log_min_duration_statement = -1 # -1 is disabled, 0 logs all statements > > > ! #log_min_duration_statement = -1ms# -1 is disabled, 0 logs all > > statements > > This is not sensible -- there are no units for the "-1" setting. I > seem

Re: [DOCS] log_min_duration_statement units

2009-04-06 Thread Tom Lane
Bruce Momjian writes: > ! #log_min_duration_statement = -1# -1 is disabled, 0 logs all statements > ! #log_min_duration_statement = -1ms # -1 is disabled, 0 logs all statements This is not sensible -- there are no units for the "-1" setting. I seem to recall that it won't even work; did

[DOCS] log_min_duration_statement units

2009-04-06 Thread Bruce Momjian
Someone complained that the default units for log_min_duration_statement was not mentioned in postgresql.conf; this applied patch fixes that. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ