Re: Re: Re: Enabling checksums on a streaming replica

2019-06-28 Thread Michael Paquier
On Fri, Jun 28, 2019 at 07:43:30AM -0400, Brad Nicholson wrote: > So if all the checksums are being recalculated on the replica, this > approach should be relatively safe, should it not? Yep. > Assuming pg_checksums is doing the right thing (and it looks to me like it > should be). The constrain

Re: Re: Re: Enabling checksums on a streaming replica

2019-06-28 Thread Brad Nicholson
Michael Paquier wrote on 06/27/2019 11:17:10 PM: > From: Michael Paquier > To: Brad Nicholson > Cc: Grigory Smolkin , pgsql- > gene...@lists.postgresql.org > Date: 06/27/2019 11:17 PM > Subject: [EXTERNAL] Re: Re: Enabling checksums on a streaming replica > > On Wed, Ju

Re: Re: Enabling checksums on a streaming replica

2019-06-27 Thread Michael Paquier
On Wed, Jun 26, 2019 at 02:08:19PM -0400, Brad Nicholson wrote: > In testing, it doesn't appear to matter. I've ensured that I've generated > some full page writes (confirmed via pg_waldump), and those apply > fine. Full pages writes are first written from shared buffers to WAL, where their check

Re: Re: Enabling checksums on a streaming replica

2019-06-26 Thread Brad Nicholson
Grigory Smolkin wrote on 06/26/2019 12:37:10 PM: > From: Grigory Smolkin > To: pgsql-general@lists.postgresql.org > Date: 06/26/2019 12:37 PM > Subject: [EXTERNAL] Re: Enabling checksums on a streaming replica > > Hello! > Very interesting idea, but what about full pa

Re: Enabling checksums on a streaming replica

2019-06-26 Thread Grigory Smolkin
Hello! Very interesting idea, but what about full page writes, that comes from master? Can they be a problem? On 6/26/19 6:32 PM, Brad Nicholson wrote: I'm wondering about the validity of using the pg_checksums utility to enable checksum's on a streaming replication standby, and then promo

Enabling checksums on a streaming replica

2019-06-26 Thread Brad Nicholson
I'm wondering about the validity of using the pg_checksums utility to enable checksum's on a streaming replication standby, and then promoting that standby as a way to enable checksums on existing clusters. I've tested the process out, and it "works" (by works I mean doesn't blow up or log any er