Re: Error when compiling postgresql 9.6.7 with Visual Studio 15.5.6

2018-02-19 Thread Michael Paquier
On Mon, Feb 19, 2018 at 04:17:18PM -0500, Tom Lane wrote: > Well, as far as I'm concerned the patch that was proposed there is > far too fragile to be acceptable. We need to find out what the > Microsoft-approved way of getting the information is. Assuming that > we know the contents of non-expor

Re: Error when compiling postgresql 9.6.7 with Visual Studio 15.5.6

2018-02-19 Thread Tom Lane
Aditya Nugraha writes: > Found out that the patch that is included in that discussion is > working fine for Visual Studio 2017 15.5.6, i think postgresql > developer should include it on upstream branch or 9.6.x variant. Well, as far as I'm concerned the patch that was proposed there is far too f

Re: Error when compiling postgresql 9.6.7 with Visual Studio 15.5.6

2018-02-19 Thread Aditya Nugraha
Found out that the patch that is included in that discussion is working fine for Visual Studio 2017 15.5.6, i think postgresql developer should include it on upstream branch or 9.6.x variant. Thanks a lot Tom! @Thomas I haven't checked it out but as above mentioned, the patch is working fine so

Re: Error when compiling postgresql 9.6.7 with Visual Studio 15.5.6

2018-02-19 Thread Thomas Munro
On Tue, Feb 20, 2018 at 6:23 AM, Tom Lane wrote: > Aditya Nugraha writes: >>When trying to compile postgresql 9.6.7 with Visual Studio 15.5.6, >> i am getting errors at these following line : >> src/backend/utils/adt/pg_locale.c(927): error C2037: left of >> 'locale_name' specifies undefine

Re: Error when compiling postgresql 9.6.7 with Visual Studio 15.5.6

2018-02-19 Thread Tom Lane
Aditya Nugraha writes: >When trying to compile postgresql 9.6.7 with Visual Studio 15.5.6, > i am getting errors at these following line : > src/backend/utils/adt/pg_locale.c(927): error C2037: left of > 'locale_name' specifies undefined struct/union '__crt_lo > cale_data' > [C:\Users\namel