Re: [GENERAL] PostgreSQL driver for Joomla review

2009-10-21 Thread Thom Brown
2009/10/21 Csaba Nagy : > Hi Thom, > > Sorry for the delay, I got sick in the meantime. I see that others > already did some review, I will do a quick one too, later maybe I'll > actually try it out... so after a quick review: > > * on line 218, the " ENCODING '$DBname')" part feels wrong, you prob

Re: [GENERAL] PostgreSQL driver for Joomla review

2009-10-21 Thread Csaba Nagy
Hi Thom, Sorry for the delay, I got sick in the meantime. I see that others already did some review, I will do a quick one too, later maybe I'll actually try it out... so after a quick review: * on line 218, the " ENCODING '$DBname')" part feels wrong, you probably want hardcoded UTF8 encoding th

Re: [GENERAL] PostgreSQL driver for Joomla review

2009-10-20 Thread Thom Brown
2009/10/20 Alban Hertroys : > You miss a keyword in your query in renameTable; it should be " RENAME TO ", > not " TO ". Thanks for spotting that. I've made my amendments for next submit. > Wouldn't it be convenient to have an EXPLAIN ANALYSE version of explain()? > Maybe with a boolean paramete

Re: [GENERAL] PostgreSQL driver for Joomla review

2009-10-20 Thread Alban Hertroys
On 20 Oct 2009, at 14:02, Thom Brown wrote: If anyone has a moment, could they review the PostgreSQL driver I wrote for Joomla's next major release? The developers at Joomla have listened to the persistent noise created about only having MySQL as an option and are now accepting submissions for

Re: [GENERAL] PostgreSQL driver for Joomla review

2009-10-20 Thread Thom Brown
2009/10/20 Merlin Moncure : > On Tue, Oct 20, 2009 at 8:02 AM, Thom Brown wrote: >> If anyone has a moment, could they review the PostgreSQL driver I >> wrote for Joomla's next major release?  The developers at Joomla have >> listened to the persistent noise created about only having MySQL as an >

Re: [GENERAL] PostgreSQL driver for Joomla review

2009-10-20 Thread Merlin Moncure
On Tue, Oct 20, 2009 at 8:02 AM, Thom Brown wrote: > If anyone has a moment, could they review the PostgreSQL driver I > wrote for Joomla's next major release?  The developers at Joomla have > listened to the persistent noise created about only having MySQL as an > option and are now accepting sub

Re: [GENERAL] PostgreSQL driver for Joomla review

2009-10-20 Thread Thom Brown
2009/10/20 Reid Thompson : > your attachment contains this... > > >         "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";> > http://www.w3.org/1999/xhtml"; xml:lang="en" lang="en"> >   >  403 - Forbidden >   >   >  403 - Forbidden >   > > Erk.. that's weird. I got that too even af

Re: [GENERAL] PostgreSQL driver for Joomla review

2009-10-20 Thread Thom Brown
2009/10/20 Csaba Nagy : > Hi Thom, > > I would like to review it, but I get "403 - Forbidden" when clicking: > > http://downloads.joomlacode.org/trackeritem/4/5/0/45041/postgresql.php > > Not sure what that means, probably I need some kind of login to the > joomla tracker system, and I don't have o

Re: [GENERAL] PostgreSQL driver for Joomla review

2009-10-20 Thread Csaba Nagy
Hi Thom, I would like to review it, but I get "403 - Forbidden" when clicking: http://downloads.joomlacode.org/trackeritem/4/5/0/45041/postgresql.php Not sure what that means, probably I need some kind of login to the joomla tracker system, and I don't have one, and I would prefer not to create

[GENERAL] PostgreSQL driver for Joomla review

2009-10-20 Thread Thom Brown
If anyone has a moment, could they review the PostgreSQL driver I wrote for Joomla's next major release? The developers at Joomla have listened to the persistent noise created about only having MySQL as an option and are now accepting submissions for alternative database systems. (see http://grou