Re: [GENERAL] pg_upgrade ?deficiency

2013-11-22 Thread Bruce Momjian
On Thu, Nov 21, 2013 at 06:22:50AM -0800, Kevin Grittner wrote: Well, pg_upgrade can't handle every possible configuration.  How do we even restore into such a database?  You marked the database as read-only, and pg_upgrade is going to honor that and not modify it. That interpretation

Re: [GENERAL] pg_upgrade ?deficiency

2013-11-22 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Not sure about backpatching. default_transaction_read_only has been around since 7.4. Setting it to true would cause pg_dump to fail unless you changed the database setting, and pg_dumpall would fail completely as there is no way to turn off the

Re: [GENERAL] pg_upgrade ?deficiency

2013-11-22 Thread Karsten Hilbert
Bruce Momjian br...@momjian.us writes: Not sure about backpatching. default_transaction_read_only has been around since 7.4. Setting it to true would cause pg_dump to fail unless you changed the database setting, and pg_dumpall would fail completely as there is no way to turn off the

Re: [GENERAL] pg_upgrade ?deficiency

2013-11-22 Thread Bruce Momjian
On Fri, Nov 22, 2013 at 03:13:33PM -0500, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Not sure about backpatching. default_transaction_read_only has been around since 7.4. Setting it to true would cause pg_dump to fail unless you changed the database setting, and pg_dumpall

Re: [GENERAL] pg_upgrade ?deficiency

2013-11-21 Thread Karsten Hilbert
On Thu, Nov 21, 2013 at 06:22:50AM -0800, Kevin Grittner wrote: I would be happy to supply a patch to treat default_transaction_read_only the same as statement_timeout or standard_conforming_strings in pg_dump and related utilities. Since it causes backup/restore failure ... (and pg_upgrade

Re: [GENERAL] pg_upgrade ?deficiency

2013-11-21 Thread Kevin Grittner
Bruce Momjian br...@momjian.us wrote: On Wed, Nov 20, 2013 at 02:36:08PM +0100, Karsten Hilbert wrote: Karsten Hilbert wrote: Let me try to rephrase: Fact: pg_upgrade can NOT properly upgrade clusters which    contain databases that are set to    default_transaction_read_only on

Re: [GENERAL] pg_upgrade ?deficiency

2013-11-20 Thread Bruce Momjian
On Tue, Nov 19, 2013 at 11:22:47AM +0100, Karsten Hilbert wrote: ERROR: transaction is read-only Now, this is quite understandable since one of the databases is set to ALTER DATABASE ... SET DEFAULT_TRANSACTION_READ_ONLY TO ON; However, since the above setting is something

Re: [GENERAL] pg_upgrade ?deficiency

2013-11-20 Thread Karsten Hilbert
On Tue, Nov 19, 2013 at 11:22:47AM +0100, Karsten Hilbert wrote: ERROR: transaction is read-only Now, this is quite understandable since one of the databases is set to ALTER DATABASE ... SET DEFAULT_TRANSACTION_READ_ONLY TO ON; However, since the above setting is

Re: [GENERAL] pg_upgrade ?deficiency

2013-11-20 Thread Albe Laurenz
Karsten Hilbert wrote: Let me try to rephrase: Fact: pg_upgrade can NOT properly upgrade clusters which contain databases that are set to default_transaction_read_only on Question: Is this intended ? I am pretty sure that this is an oversight and hence a bug. Yours, Laurenz Albe

Re: [GENERAL] pg_upgrade ?deficiency

2013-11-20 Thread Karsten Hilbert
Karsten Hilbert wrote: Let me try to rephrase: Fact: pg_upgrade can NOT properly upgrade clusters which contain databases that are set to default_transaction_read_only on Question: Is this intended ? I am pretty sure that this is an oversight and hence a bug. oversight,

Re: [GENERAL] pg_upgrade ?deficiency

2013-11-20 Thread Bruce Momjian
On Wed, Nov 20, 2013 at 02:36:08PM +0100, Karsten Hilbert wrote: Karsten Hilbert wrote: Let me try to rephrase: Fact: pg_upgrade can NOT properly upgrade clusters which contain databases that are set to default_transaction_read_only on Question: Is this intended ?

Re: [GENERAL] pg_upgrade ?deficiency

2013-11-20 Thread Karsten Hilbert
On Wed, Nov 20, 2013 at 02:36:08PM +0100, Karsten Hilbert wrote: Karsten Hilbert wrote: Let me try to rephrase: Fact: pg_upgrade can NOT properly upgrade clusters which contain databases that are set to default_transaction_read_only on Question: Is this intended

Re: [GENERAL] pg_upgrade ?deficiency

2013-11-20 Thread Bruce Momjian
On Wed, Nov 20, 2013 at 04:07:59PM +0100, Karsten Hilbert wrote: On Wed, Nov 20, 2013 at 02:36:08PM +0100, Karsten Hilbert wrote: Karsten Hilbert wrote: Let me try to rephrase: Fact: pg_upgrade can NOT properly upgrade clusters which contain databases that are set

[GENERAL] pg_upgrade ?deficiency

2013-11-19 Thread Karsten Hilbert
Hello all, I am upgrading a 8.4 cluster to 9.1 and am seeing the following: SQL command failed CREATE TEMPORARY TABLE info_rels (reloid) AS SELECT c.oid FROM pg_catalog.pg_class c JOIN pg_catalog.pg_namespace n ON