Re: [GENERAL] pg_upgrade from 8.3.4 issue

2011-09-01 Thread Bruce Momjian
FYI, also, yesterday, I fixed a pg_upgrade bug when upgrading from 8.3 --- I suggest you wait for 9.0.5 or pull git head for the release you want. --- Tom Lane wrote: > I wrote: > > I think it'd be a lot safer to modify (or

Re: [GENERAL] pg_upgrade from 8.3.4 issue

2011-08-30 Thread Tom Lane
I wrote: > I think it'd be a lot safer to modify (or just remove) the test in > pg_upgrade. It looks like a one-liner: Specifically, the attached patch takes care of the problem. Thanks for reporting it! regards, tom lane diff --git a/contrib/pg_upgrade/check.c b/contr

Re: [GENERAL] pg_upgrade from 8.3.4 issue

2011-08-30 Thread Justin Arnold
Thanks Tom and Merlin, I removed that logic from check.c, rebuilt, and it worked fine. On Tue, Aug 30, 2011 at 2:47 PM, Tom Lane wrote: > Merlin Moncure writes: > > It looks like some time after 8.3 was released that function was > > changed from returning 'record'. This is making me wonder if

Re: [GENERAL] pg_upgrade from 8.3.4 issue

2011-08-30 Thread Tom Lane
Merlin Moncure writes: > It looks like some time after 8.3 was released that function was > changed from returning 'record'. This is making me wonder if the > upgrade process was ever tested/verified on 8.3. Not lately, apparently :-( > I absolutely do not > advise doing this without taking a l

Re: [GENERAL] pg_upgrade from 8.3.4 issue

2011-08-30 Thread Merlin Moncure
On Tue, Aug 30, 2011 at 12:48 PM, Justin Arnold wrote: > Hey, I am trying to upgrade a CentOS 5.4 32bit test server running postgres > 8.3.4 to postgres 9.1 RC1 and am running into an error I haven't seen > mentioned in the forums (at least dealing with the upgrade process). The > steps I ran thro

[GENERAL] pg_upgrade from 8.3.4 issue

2011-08-30 Thread Justin Arnold
Hey, I am trying to upgrade a CentOS 5.4 32bit test server running postgres 8.3.4 to postgres 9.1 RC1 and am running into an error I haven't seen mentioned in the forums (at least dealing with the upgrade process). The steps I ran through for the upgrade are... >Stop postgres >move /usr/local/pgsq