Re: Protect syscache from bloating with negative cache entries

2017-12-16 Thread Andres Freund
On 2017-12-16 22:25:48 -0500, Robert Haas wrote: > On Wed, Dec 13, 2017 at 11:20 PM, Kyotaro HORIGUCHI > wrote: > > Thank you very much for the valuable suggestions. I still would > > like to solve this problem and the > > a-counter-freely-running-in-minute(or several seconds)-resolution > > and p

Re: Race to build pg_isolation_regress in "make -j check-world"

2017-12-16 Thread Noah Misch
On Mon, Nov 06, 2017 at 12:07:52AM -0800, Noah Misch wrote: > I've been enjoying the speed of parallel check-world, but I get spurious > failures from makefile race conditions. Commit c66b438 fixed the simple ones. > More tricky is this problem of multiple "make" processes entering > src/test/regr

Re: [HACKERS] Custom compression methods

2017-12-16 Thread Robert Haas
On Thu, Dec 14, 2017 at 12:23 PM, Tomas Vondra wrote: > Can you give an example of such algorithm? Because I haven't seen such > example, and I find arguments based on hypothetical compression methods > somewhat suspicious. > > FWIW I'm not against considering such compression methods, but OTOH it

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-12-16 Thread Robert Haas
On Thu, Dec 14, 2017 at 5:45 AM, Masahiko Sawada wrote: > Here is the result. > I've measured the through-put with some cases on my virtual machine. > Each client loads 48k file to each different relations located on > either xfs filesystem or ext4 filesystem, for 30 sec. > > Case 1: COPYs to rela

Re: Protect syscache from bloating with negative cache entries

2017-12-16 Thread Robert Haas
On Wed, Dec 13, 2017 at 11:20 PM, Kyotaro HORIGUCHI wrote: > Thank you very much for the valuable suggestions. I still would > like to solve this problem and the > a-counter-freely-running-in-minute(or several seconds)-resolution > and pruning-too-long-unaccessed-entries-on-resizing seems to me >

Re: pg_(total_)relation_size and partitioned tables

2017-12-16 Thread Robert Haas
On Thu, Dec 14, 2017 at 12:23 AM, Amit Langote wrote: > You may have guessed from $subject that the two don't work together. It works exactly as documented: pg_total_relation_size(regclass) - Total disk space used by the specified table, including all indexes and TOAST data It says nothing abou

Re: [HACKERS] Proposal: Local indexes for partitioned table

2017-12-16 Thread Robert Haas
On Fri, Dec 15, 2017 at 5:18 PM, Alvaro Herrera wrote: > We have two options for marking valid: > > 1. after each ALTER INDEX ATTACH, verify whether the set of partitions > that contain the index is complete; if so, mark it valid, otherwise do > nothing. This sucks because we have to check that o

Re: Package version in PG_VERSION and version()

2017-12-16 Thread Robert Haas
On Fri, Dec 15, 2017 at 10:23 AM, Tom Lane wrote: > Christoph Berg writes: >> Re: Michael Paquier 2017-12-15 >> >>> Why reinventing the wheel when there is already --with-extra-version >>> that you can use for the same purpose? > >> That modifies the PG version number as such, as what psql is s

Re: Why does array_position_common bitwise NOT an Oid type?

2017-12-16 Thread Tom Lane
David Rowley writes: > I was puzzled to see the following code: > my_extra->element_type = ~element_type; > It looks quite wrong, but if its right then I think it needs a comment > to explain it. I don't see any in the area which mentions it. My best > guess would be that it's using this to know

Why does array_position_common bitwise NOT an Oid type?

2017-12-16 Thread David Rowley
Hi, I was puzzled to see the following code: my_extra->element_type = ~element_type; It looks quite wrong, but if its right then I think it needs a comment to explain it. I don't see any in the area which mentions it. My best guess would be that it's using this to know if the type data has been

Re: [sqlsmith] Parallel worker executor crash on master

2017-12-16 Thread Andreas Seltenreich
Thomas Munro writes: > On Sat, Dec 16, 2017 at 10:13 PM, Andreas Seltenreich > wrote: >> Core was generated by `postgres: smith regression [local] SELECT >>'. >> Program terminated with signal SIGSEGV, Segmentation fault. >> #0 gather_getnext (gatherstate=0x555a5fff1350)

Re: [sqlsmith] Parallel worker executor crash on master

2017-12-16 Thread Thomas Munro
On Sat, Dec 16, 2017 at 10:13 PM, Andreas Seltenreich wrote: > Amit Kapila writes: > >> This seems to be another symptom of the problem related to >> es_query_dsa for which Thomas has sent a patch on a different thread >> [1]. After applying that patch, I am not able to see the problem. I >> thi

Re: Reproducible builds: genbki.pl vs schemapg.h

2017-12-16 Thread Tom Lane
Christoph Berg writes: >> Agreed so far as the script name goes. However, two out of three of these >> scripts also print their input file names, and I'm suspicious that that >> output is also gonna change in a VPATH build. I'm a little less inclined >> to buy the claim that we're not losing any

Re: Reproducible builds: genbki.pl vs schemapg.h

2017-12-16 Thread Christoph Berg
Re: Tom Lane 2017-12-16 <5525.1513381...@sss.pgh.pa.us> > >>> As per > >>> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/postgresql-10.html, > >>> that's the only place that makes it into the resulting binary. > > I'm fairly confused by this claim. Since the string in questio

Re: genomic locus

2017-12-16 Thread Andrew Dunstan
On 12/15/2017 05:50 PM, Michael Paquier wrote: > >> I have seen a lot of bit rot in other extensions (never contributed) that I >> have not maintained since 2009 and I now I am unable to fix some of them, so >> I wonder how much of old knowledge is still applicable. In other words, is >> what I s

Re: Backfill bgworker Extension?

2017-12-16 Thread Peter Eisentraut
On 12/15/17 23:50, Jeremy Finzel wrote: > The common ground is some column in some table needs to be bulk updated. > I may not be explaining well, but in our environment we have done > hundreds of these using a generic framework to build a backfill. So I’m > not sure what you are questioning about

Re: [sqlsmith] Parallel worker executor crash on master

2017-12-16 Thread Andreas Seltenreich
Amit Kapila writes: > This seems to be another symptom of the problem related to > es_query_dsa for which Thomas has sent a patch on a different thread > [1]. After applying that patch, I am not able to see the problem. I > think due to the wrong usage of dsa across nodes, it can lead to > sendi