Re: csv format for psql

2018-04-07 Thread Daniel Verite
Isaac Morland wrote: > OK, mostly trying to avoid commenting because I doubt I have much to add. > But. If I ask for CSV and don't specify any overrides, I expect to get > "C"omma separated values, not some other character. More specifically, if I > say --csv I expect to get files that are

Re: [HACKERS] Runtime Partition Pruning

2018-04-07 Thread David Rowley
On 8 April 2018 at 01:18, Alvaro Herrera wrote: > Amit had it as "indexes" also in his original. I wanted to avoid using > the "indexes" word alone, whose meaning is so overloaded. hmm, good point. > How about this? > "... which are then executed to produce a set of partitions (as indexes > of

Re: [HACKERS] Runtime Partition Pruning

2018-04-07 Thread Alvaro Herrera
David Rowley wrote: > It's not exactly wrong but: > > + * are turned into a set of "pruning steps", which are then executed to > + * produce a set of RTIs of partitions whose bounds satisfy the constraints > in > + * the step. Partitions not in the set are said to have been pruned. > > It's on

Re: Bring atomic flag fallback up to snuff

2018-04-07 Thread Magnus Hagander
This is the same one you already committed right? Not a further one on top of that? That said,+1 for not bothering to back patch it. /Magnus On Sat, Apr 7, 2018, 00:39 Andres Freund wrote: > Hi, > > As Daniel pointed out in: > https://postgr.es/m/fb948276-7b32-4b77-83e6-d00167f8e...@yesql.se

Re: WIP: Covering + unique indexes. (the good and the bad)

2018-04-07 Thread Erik Rijkers
On 2018-04-07 14:27, Alexander Korotkov wrote: On Sat, Apr 7, 2018 at 2:57 PM, Erik Rijkers wrote: On 2018-04-06 20:08, Alexander Korotkov wrote: [0001-Covering-v15.patch] After some more testing I notice there is also a down-side/slow-down to this patch that is not so bad but more than ne

Re: [HACKERS] Runtime Partition Pruning

2018-04-07 Thread David Rowley
On 8 April 2018 at 00:23, Alvaro Herrera wrote: > I edited it as attached, to 1. avoid mentioning functionality that > doesn't yet exist, and 2. avoid excessive internal detail (we want a > high-level overview here), which from experience gets outdated pretty > quickly. It's not exactly wrong but

Re: Mop-up for the bootstrap data conversion patch

2018-04-07 Thread Michael Paquier
On Sat, Apr 07, 2018 at 09:25:44AM -0300, Alvaro Herrera wrote: > Tom Lane wrote: >> I've always felt that the pg_foo_fn.h business was a kluge, and would >> be happy to get rid of it. But one could also argue that it would be >> a good design, if we adopted it uniformly instead of haphazardly. >>

Re: WIP: Covering + unique indexes. (the good and the bad)

2018-04-07 Thread Alexander Korotkov
On Sat, Apr 7, 2018 at 2:57 PM, Erik Rijkers wrote: > On 2018-04-06 20:08, Alexander Korotkov wrote: > >> >> [0001-Covering-v15.patch] >> >> > After some more testing I notice there is also a down-side/slow-down to > this patch that is not so bad but more than negligible, and I don't think > it h

Re: WIP: Covering + unique indexes. (the good and the bad)

2018-04-07 Thread Teodor Sigaev
Thank you!   create unique index ${t}uniqueinclude_idx on $t using btree (c1, c2) include (c3, c4); or for HEAD, just:   create unique index ${t}unique_idx on $t using btree (c1, c2); -- explain analyze select c1, c2 from nt0___1 where c1 < 1 -- explain analyze select c1, c2

Re: Mop-up for the bootstrap data conversion patch

2018-04-07 Thread Alvaro Herrera
Tom Lane wrote: > I've always felt that the pg_foo_fn.h business was a kluge, and would > be happy to get rid of it. But one could also argue that it would be > a good design, if we adopted it uniformly instead of haphazardly. > But that'd require more code churn, and there's no longer a lot to b

Re: [HACKERS] Runtime Partition Pruning

2018-04-07 Thread Alvaro Herrera
Amit Langote wrote: > See if the attached makes it any better. > > Now I know we don't have the runtime pruning in yet, but since the > proposed patch would extend its functionality I have included its > description in the comment. Thanks! I edited it as attached, to 1. avoid mentioning functio

Re: csv format for psql

2018-04-07 Thread Daniel Verite
Peter Eisentraut wrote: > Another thought: Isn't CSV just the same as unaligned output plus some > quoting? Could we add a quote character setting and then define --csv > to be quote-character = " and fieldsep = , ? Plus footer set to off. So --csv would be like \pset format unaligned \p

Re: csv format for psql

2018-04-07 Thread Pavel Stehule
2018-04-07 13:55 GMT+02:00 Daniel Verite : > Pavel Stehule wrote: > > > so we can to have > > > > \pset format xxx > > > > and set of local possibly changed defaults > > > > \pset csv_fieldsep , > > \pset csv_tuplesonly on > > \pset unaligned_fieldsep | > > \pset unaligned_tuplesonly off >

Re: WIP: Covering + unique indexes. (the good and the bad)

2018-04-07 Thread Erik Rijkers
On 2018-04-06 20:08, Alexander Korotkov wrote: [0001-Covering-v15.patch] After some more testing I notice there is also a down-side/slow-down to this patch that is not so bad but more than negligible, and I don't think it has been mentioned (but I may have missed something in this thread t

Re: csv format for psql

2018-04-07 Thread Daniel Verite
Pavel Stehule wrote: > so we can to have > > \pset format xxx > > and set of local possibly changed defaults > > \pset csv_fieldsep , > \pset csv_tuplesonly on > \pset unaligned_fieldsep | > \pset unaligned_tuplesonly off tuples_only (\t) is a single setting that is currently used by a

Re: [HACKERS] path toward faster partition pruning

2018-04-07 Thread Alvaro Herrera
Andres Freund wrote: > Hi, > > On 2018-04-07 15:49:54 +1200, David Rowley wrote: > > Right, I suggest we wait and see if all members go green again as a > > result of 40e42e1024c, and if they're happy then we could maybe leave > > it as is with the 2 alternatives output files. > > At least the fi

Re: WIP: a way forward on bootstrap data

2018-04-07 Thread Alvaro Herrera
John Naylor wrote: > On 4/6/18, Tom Lane wrote: > > > I don't think there's any great need to incorporate this into your patch > > set. As far as I'm concerned, v14 is ready as-is, and I'll just apply > > this over the top of it. (Note that I'll probably smash the whole thing > > to one commit

Re: Online enabling of checksums

2018-04-07 Thread Michael Banck
Hi, On Sat, Apr 07, 2018 at 08:57:03AM +0200, Magnus Hagander wrote: > On Sat, Apr 7, 2018 at 6:26 AM, Andres Freund wrote: > > If it's not obvious: This isn't ready, should be reverted, cleaned up, > > and re-submitted for v12. > > While I do think that it's still definitely fixable in time for

Re: Corrupted data due to system power failure

2018-04-07 Thread Gaetano Mendola
This kind of reports is the exact reason you should never install the OS in a different language than english. you could have at least googled for the exact phrase "controllo di integrita fallito" to see how other people have solved it. On Mon, 12 Mar 2018 at 14:50 Enzo Diletti wrote: > A de

<    1   2