Re: Postgres 11 release notes

2018-05-12 Thread Michael Paquier
On Fri, May 11, 2018 at 11:08:52AM -0400, Bruce Momjian wrote: > I have committed the first draft of the Postgres 11 release notes. I > will add more markup soon. You can view the most current version > here: Thanks for gathering all the commits in one piece, Bruce. > I expect a torrent of feed

Re: Postgres 11 release notes

2018-05-12 Thread Bruce Momjian
On Sat, May 12, 2018 at 01:22:55PM -0700, Peter Geoghegan wrote: > On Fri, May 11, 2018 at 2:06 PM, Bruce Momjian wrote: > > Done and URL updated. > > I have some feedback on "Allow NOT NULL to be added to columns without > requiring a table rewrite". I suggest that this be phrased as "Avoid a >

explain (verbose off, normalized) vs query planid

2018-05-12 Thread legrand legrand
Hello, as described in: http://www.postgresql-archive.org/Re-FEATURE-PATCH-pg-stat-statements-with-plans-v02-td6015488.html I'm wondering about the best way to build a query planid. It seems natural (to me) to calculate a hash value based on the normalized plan text generated by explain (cost

Re: lazy detoasting

2018-05-12 Thread Tom Lane
Peter Eisentraut writes: > Here is a more complete patch. I made a call graph to get to the > bottom, literally, of how variable assignments happen in PL/pgSQL. (See > attached.) There are four leaf functions to patch up. > Also, I wrote some isolation tests to hit each of these cases. I wasn'

Re: Compiler warnings with --enable-dtrace

2018-05-12 Thread Peter Geoghegan
On Fri, May 11, 2018 at 11:46 PM, Christoph Berg wrote: > Re: Peter Geoghegan 2018-05-12 > >> It seems to be surprisingly low overhead in many cases. > > I was pondering adding --enable-dtrace in the Debian packages, but > Andres advised against it, "because it affects code generation". > > So f

Re: Postgres 11 release notes

2018-05-12 Thread Peter Geoghegan
On Fri, May 11, 2018 at 2:06 PM, Bruce Momjian wrote: > Done and URL updated. I have some feedback on "Allow NOT NULL to be added to columns without requiring a table rewrite". I suggest that this be phrased as "Avoid a table rewrite when ALTER TABLE ADD COLUMN sets a default value for a column".

Re: pg_locale compilation error with Visual Studio 2017

2018-05-12 Thread Tom Lane
Michael Paquier writes: > On Fri, May 11, 2018 at 10:39:07AM -0400, Tom Lane wrote: >> Another idea would be to replace the whole mess with a lookup table, >> although how to fill the table or maintain it in future would be >> problematic too. > Let's never do that.. Well, I dunno. There are a

Re: Should we add GUCs to allow partition pruning to be disabled?

2018-05-12 Thread Alvaro Herrera
Hello Amit Langote wrote: > +1 to this more radical overhaul of this part of the documentation. Thanks. I pushed now after some more tweaking, including your suggested corrections. I removed the examples, because they were both wrong. We can give this more polish if anybody has the energy, bu

Re: pg_locale compilation error with Visual Studio 2017

2018-05-12 Thread Michael Paquier
On Fri, May 11, 2018 at 10:39:07AM -0400, Tom Lane wrote: > In the other thread, Munro wondered if ResolveLocaleName() would do > the trick, but AFAICS nobody has tried it. Indeed. I am pretty sure that it would be worth looking into that. The VS docs shine by being obscure with this area, and e