Re: JIT compiling with LLVM v12

2018-08-25 Thread Fabien COELHO
Now you can say that'd be solved by bumping the cost up, sure. But obviously the row / cost model is pretty much out of whack here, I don't see how we can make reasonable decisions in a trivial query that has a misestimation by five orders of magnitude. Before JIT, it didn't matter whether the

wal_sender_timeout should ignore server-side latency

2018-08-25 Thread Noah Misch
WalSndLoop() does this, simplifying considerably: for (;;) { /* does: last_reply_timestamp = GetCurrentTimestamp() */ ProcessRepliesIfAny(); send_data(); /* e.g. XLogSendPhysical(), which calls XLogRead() */ WalSnd

Re: has_table_privilege for a table in unprivileged schema causes an error

2018-08-25 Thread Tom Lane
Robert Haas writes: > I'm not sure that it's a good idea to change this behavior. > In the case of an unqualified name, the permissions on the schemas in > the search path can affect which table is chosen in the first place. > ... So I think this only matters for qualified names. Yeah, that agre

Re: simplehash.h comment

2018-08-25 Thread Thomas Munro
On Mon, Aug 20, 2018 at 4:57 PM Michael Paquier wrote: > > On Mon, Aug 20, 2018 at 04:38:20PM +1200, Thomas Munro wrote: > > "For examples of usage look at simplehash.c ..." > > > > There is no such file in the tree. Maybe this should say tidbitmap.c? > > And execGrouping.c... Some more comments

RE: [HACKERS] Proposal to add work_mem option to postgres_fdw module

2018-08-25 Thread Shinoda, Noriyoshi (PN Japan GCS Delivery)
Robert-san, Thank you very much for your comment. I will try to modify it so that GUC can be added more generically. When specifying multiple GUC settings for PQconnectdbParams, is it correct to describe as follows? -- keywords [n] = "options"; values [n] = "-c work_mem=8MB -c maintenance_work_m

Re: has_table_privilege for a table in unprivileged schema causes an error

2018-08-25 Thread Robert Haas
On Fri, Aug 24, 2018 at 5:31 AM, Yugo Nagata wrote: > Although the behavior of the original function would reflect pg_class.relacl, > it seems to > me that the function fixed in my patch is more useful for users because this > reflects > the actual accessibility during query execution. I'm not

Re: JIT compiling with LLVM v12

2018-08-25 Thread Robert Haas
On Wed, Aug 22, 2018 at 6:43 PM, Andres Freund wrote: > Now you can say that'd be solved by bumping the cost up, sure. But > obviously the row / cost model is pretty much out of whack here, I don't > see how we can make reasonable decisions in a trivial query that has a > misestimation by five ord

Re: [HACKERS] WIP: long transactions on hot standby feedback replica / proof of concept

2018-08-25 Thread Robert Haas
On Tue, Aug 21, 2018 at 9:10 AM, Alexander Korotkov wrote: > After heap truncation using this algorithm, shared buffers may contain > past-OEF buffers. But those buffers are empty (no used items) and > clean. So, real-only queries shouldn't hint those buffers dirty > because there are no used it

Re: Postgres 11 release notes

2018-08-25 Thread Peter Geoghegan
On Sat, Aug 25, 2018 at 2:18 PM, Bruce Momjian wrote: >> I think that's less "our" logic and more yours, that has become >> established because you've done most of the major release notes for a >> long time. I'm not trying to say that that's wrong or anything, just > > I don't do my work in a vacu

Re: Postgres 11 release notes

2018-08-25 Thread Bruce Momjian
On Sat, Aug 25, 2018 at 12:17:17PM -0700, Andres Freund wrote: > Hi, > > On 2018-08-25 14:47:20 -0400, Bruce Momjian wrote: > > Well, our normal logical is whether the average user would adjust their > > behavior based on this change, or whether it is user visible. I thought > > it was a contrive

Re: Postgres 11 release notes

2018-08-25 Thread Andres Freund
Hi, On 2018-08-25 14:47:20 -0400, Bruce Momjian wrote: > Well, our normal logical is whether the average user would adjust their > behavior based on this change, or whether it is user visible. I thought > it was a contrived-enough query that this was not the case, but I would > be interested to h

Re: Postgres 11 release notes

2018-08-25 Thread Bruce Momjian
On Sat, Aug 25, 2018 at 11:42:35AM -0700, Andres Freund wrote: > > > On August 25, 2018 11:41:11 AM PDT, Bruce Momjian wrote: > >On Sun, Aug 12, 2018 at 11:21:26AM +0200, Adrien Nayrat wrote: > >> Hello, > >> > >> It seems this feature is missing in releases notes ? > >> > >> commit 1f6d515a67

Re: Postgres 11 release notes

2018-08-25 Thread Andres Freund
On August 25, 2018 11:41:11 AM PDT, Bruce Momjian wrote: >On Sun, Aug 12, 2018 at 11:21:26AM +0200, Adrien Nayrat wrote: >> Hello, >> >> It seems this feature is missing in releases notes ? >> >> commit 1f6d515a67ec98194c23a5db25660856c9aab944 >> Author: Robert Haas >> Date: Mon Aug 21 14:

Re: Postgres 11 release notes

2018-08-25 Thread Bruce Momjian
On Sun, Aug 12, 2018 at 11:21:26AM +0200, Adrien Nayrat wrote: > Hello, > > It seems this feature is missing in releases notes ? > > commit 1f6d515a67ec98194c23a5db25660856c9aab944 > Author: Robert Haas > Date: Mon Aug 21 14:43:01 2017 -0400 > > Push limit through subqueries to underlying

Re: JIT compiling with LLVM v12

2018-08-25 Thread Noah Misch
On Wed, Aug 22, 2018 at 06:20:21AM +, Noah Misch wrote: > On Wed, Mar 28, 2018 at 02:27:51PM -0700, Andres Freund wrote: > > For now LLVM is enabled by default when compiled --with-llvm. I'm mildly > > inclined to leave it like that until shortly before the release, and > > then disable it by d

Re: Doc patch: pg_upgrade page and checkpoint location consistency with replicas

2018-08-25 Thread Bruce Momjian
On Fri, Aug 17, 2018 at 09:57:08AM +0200, Paul Bonaud wrote: > I shared the pach in plain textin the email body and figured out that > all other patches are submitted as an attachement. Sorry for that, here > is the patch attached to this email. Patch applied through 9.5, where the "match" text fi

Re: C99 compliance for src/port/snprintf.c

2018-08-25 Thread Tom Lane
Andres Freund writes: > On 2018-08-16 11:41:30 -0400, Tom Lane wrote: >> Andres Freund writes: >>> While I'd personally have no problem kicking gcc 3.4 to the curb, I'm >>> still confused what causes this error mode. Kinda looks like >>> out-of-sync headers with gcc or something. >> Yeah, this

Re: Reference link for applicable_roles view is missing in the documentation of enabled_roles

2018-08-25 Thread Bruce Momjian
On Fri, Aug 24, 2018 at 05:38:44PM +0530, Ashutosh Sharma wrote: > Hi All, > > The redirect link for applicable_roles view is missing in the > documentation page for enabled_roles view. Attached is the patch that > adds the same. Please refer to the following URL for details. > > https://www.post

Re: Problem while setting the fpw with SIGHUP

2018-08-25 Thread Amit Kapila
On Wed, Aug 1, 2018 at 12:56 PM Kyotaro HORIGUCHI wrote: > > Thank you, Amit, Michael. > Can you verify the first patch that I have posted above [1]? We can commit it separately. > > It's a long time ago.. Let me have a bit of time to blow dust off.. > > https://www.postgresql.org/message-id/20