Re: remove deprecated @@@ operator ?

2018-10-21 Thread Oleg Bartunov
On Sun, Oct 21, 2018 at 11:24 PM Tom Lane wrote: > > Oleg Bartunov writes: > > The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years > > old, may be we could remove deprecated @@@ operator ? > > Is it actually causing any problem? AFAICS it's just a couple extra > pg_operator

Re: Side effect of CVE-2017-7484 fix?

2018-10-21 Thread David Fetter
On Mon, Oct 22, 2018 at 11:10:09AM +0530, Dilip Kumar wrote: > As part of the security fix > (e2d4ef8de869c57e3bf270a30c12d48c2ce4e00c), we have restricted the > users from accessing the statistics of the table if the user doesn't > have privileges on the table and the function is not leakproof. >

Re: Side effect of CVE-2017-7484 fix?

2018-10-21 Thread Stephen Frost
Greetings, * Dilip Kumar (dilipbal...@gmail.com) wrote: > As part of the security fix > (e2d4ef8de869c57e3bf270a30c12d48c2ce4e00c), we have restricted the > users from accessing the statistics of the table if the user doesn't > have privileges on the table and the function is not leakproof. Now,

Side effect of CVE-2017-7484 fix?

2018-10-21 Thread Dilip Kumar
As part of the security fix (e2d4ef8de869c57e3bf270a30c12d48c2ce4e00c), we have restricted the users from accessing the statistics of the table if the user doesn't have privileges on the table and the function is not leakproof. Now, as a side effect of this, if the user has the privileges on the

Re: SQL:2011 PERIODS vs Postgres Ranges?

2018-10-21 Thread Pavel Stehule
Hi ne 21. 10. 2018 v 21:47 odesílatel Paul A Jungwirth < p...@illuminatedcomputing.com> napsal: > On Sun, Oct 21, 2018 at 12:11 PM Heikki Linnakangas > wrote: > > On 21/10/2018 21:17, Paul A Jungwirth wrote: > > > 3. Build our own abstractions on top of ranges, and then use those to > > >

Re: Number of buckets/partitions of dshash

2018-10-21 Thread Kyotaro HORIGUCHI
Hello. At Fri, 12 Oct 2018 06:19:12 +, "Ideriha, Takeshi" wrote in <4E72940DA2BF16479384A86D54D0988A6F1C1779@G01JPEXMBKW04> > Hi, let me clarify my understanding about the $title. > > It seems that the number of hash partitions is fixed at 128 in dshash and > right now we cannot change it

Re: found xmin x from before relfrozenxid y

2018-10-21 Thread Tom Lane
Andres Freund writes: > On 2018-10-21 10:24:16 -0400, Tom Lane wrote: >> (Well, I see the short answer: the code layer throwing the error >> doesn't know. But that could be fixed easily enough.) > I wonder if the better approach wouldn't be to add an errcontext for > vaccuum, where continually

Re: pgsql: Avoid duplicate XIDs at recovery when building initial snapshot

2018-10-21 Thread Michael Paquier
(moving to -hackers) On Sun, Oct 14, 2018 at 10:42:40AM -0700, Andres Freund wrote: > I'm unhappy this approach was taken over objections. Without a real > warning. Oops, that was not clear to me. Sorry about that! I did not see you objecting again after the last arguments I raised. The end

Re: relhassubclass and partitioned indexes

2018-10-21 Thread Amit Langote
Hi, On 2018/10/22 11:09, Michael Paquier wrote: > On Fri, Oct 19, 2018 at 06:46:15PM +0900, Amit Langote wrote: >> Thanks. Attached a patch to set relhassubclass when an index partition is >> added to a partitioned index. > > Thanks, committed after adding a test with ALTER TABLE ONLY, and >

Re: relhassubclass and partitioned indexes

2018-10-21 Thread Michael Paquier
On Fri, Oct 19, 2018 at 06:46:15PM +0900, Amit Langote wrote: > Thanks. Attached a patch to set relhassubclass when an index partition is > added to a partitioned index. Thanks, committed after adding a test with ALTER TABLE ONLY, and checking upgrades as well as ATTACH partition for ALTER INDEX

Re: found xmin x from before relfrozenxid y

2018-10-21 Thread Andres Freund
Hi, On 2018-10-21 10:24:16 -0400, Tom Lane wrote: > =?UTF-8?Q?Johannes_Gra=c3=abn?= writes: > > after upgrading to version 11, I see the error pattern "found xmin x > > from before relfrozenxid y" in different databases on different hosts. > > From

Re: More issues with pg_verify_checksums and checksum verification in base backups

2018-10-21 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Sun, Oct 21, 2018 at 11:03:30AM -0400, Stephen Frost wrote: > > This doesn't change my opinion of the bigger question though, which is > > to what extent we should be implicitly supporting extensions and > > whatever else putting

RE: WAL archive (archive_mode = always) ?

2018-10-21 Thread Tsunakawa, Takayuki
From: Adelino Silva [mailto:adelino.j.si...@googlemail.com] > What is the advantage to use archive_mode = always in a slave server compared > to archive_mode = on (shared WAL archive) ? > > I only see duplication of Wal files, what is the purpose of this feature ? This also saves you the network

Re: More issues with pg_verify_checksums and checksum verification in base backups

2018-10-21 Thread Michael Paquier
On Sun, Oct 21, 2018 at 11:03:30AM -0400, Stephen Frost wrote: > This doesn't change my opinion of the bigger question though, which is > to what extent we should be implicitly supporting extensions and > whatever else putting files into the database and tablespace > directories. Well, the whole

Re: Patch to avoid SIGQUIT accident

2018-10-21 Thread Renato dos Santos
I agree with your arguments, and if instead we put an option to disable this before compiling or a set in the psql cli? On Sun, Oct 21, 2018, 20:20 Tom Lane wrote: > Renato dos Santos writes: > > I have been using psql for quite a few days. And I have accidentally > pressed the CTRL + \ keys

Re: Patch to avoid SIGQUIT accident

2018-10-21 Thread Tom Lane
Renato dos Santos writes: > I have been using psql for quite a few days. And I have accidentally pressed > the CTRL + \ keys that sends the signal QUIT+Coredump (CTRL+4 also sends the > same signal). > I hope it's relevant to more people. (This has bothered me.) > this patch avoids the output

Re: Pluggable Storage - Andres's take

2018-10-21 Thread Alexander Korotkov
On Thu, Oct 18, 2018 at 6:28 AM Haribabu Kommi wrote: > On Tue, Oct 16, 2018 at 6:06 AM Alexander Korotkov > wrote: >> * 0002-add-costing-function-to-API.patch – adds function for costing >> sequential and table sample scan to tableam API. zheap costing >> function are now copies of heap

Re: [PATCH] XLogReadRecord returns pointer to currently read page

2018-10-21 Thread Heikki Linnakangas
On 17/08/2018 06:47, Andrey Lepikhov wrote: I propose the patch for fix one small code defect. The XLogReadRecord() function reads the pages of a WAL segment that contain a WAL-record. Then it creates a readRecordBuf buffer in private memory of a backend and copy record from the pages to the

Re: remove deprecated @@@ operator ?

2018-10-21 Thread Tom Lane
Oleg Bartunov writes: > The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years > old, may be we could remove deprecated @@@ operator ? Is it actually causing any problem? AFAICS it's just a couple extra pg_operator entries, so why not leave it? I'd be +1 for removing it from the

remove deprecated @@@ operator ?

2018-10-21 Thread Oleg Bartunov
Hello, The commit 9b5c8d45f62bd3d243a40cc84deb93893f2f5122 is now 10+ years old, may be we could remove deprecated @@@ operator ? Author: Tom Lane Date: Mon Apr 14 17:05:34 2008 + Push index operator lossiness determination down to GIST/GIN opclass "consistent" functions, and

Re: SQL:2011 PERIODS vs Postgres Ranges?

2018-10-21 Thread Paul A Jungwirth
On Sun, Oct 21, 2018 at 12:11 PM Heikki Linnakangas wrote: > On 21/10/2018 21:17, Paul A Jungwirth wrote: > > 3. Build our own abstractions on top of ranges, and then use those to > > implement PERIOD-based features. > +1 on this approach. I think [7] got the model right. If we can > implement

Re: SQL:2011 PERIODS vs Postgres Ranges?

2018-10-21 Thread Heikki Linnakangas
On 21/10/2018 21:17, Paul A Jungwirth wrote: 3. Build our own abstractions on top of ranges, and then use those to implement PERIOD-based features. This is the least clear option, and I imagine it would require a lot more design effort. Our range types are already a step in this direction. Does

Re: SQL:2011 PERIODS vs Postgres Ranges?

2018-10-21 Thread Isaac Morland
On Sun, 21 Oct 2018 at 14:18, Paul A Jungwirth wrote: > Also, just how strictly do we have to follow the standard? Requiring > sentinels like '01 JAN 3000` just seems so silly. Could Postgres > permit nullable start/end PERIOD columns, and give them the same > meaning as ranges (unbounded)? Even

SQL:2011 PERIODS vs Postgres Ranges?

2018-10-21 Thread Paul A Jungwirth
Hello, I'm interested in contributing some temporal database functionality to Postgres, starting with temporal primary and foreign keys. I know some other folks nearby interested in helping out, too. But before we begin I'd like to ask the community about complying with the SQL:2011 standard [1]

Patch to avoid SIGQUIT accident

2018-10-21 Thread Renato dos Santos
Hello,I have been using psql for quite a few days. And I have accidentally pressed the CTRL + \ keys that sends the signal QUIT+Coredump (CTRL+4 also sends the same signal).I hope it's relevant to more people. (This has bothered me.)this patch avoids the output of the CLI using ctrl + \ is the

Re: More issues with pg_verify_checksums and checksum verification in base backups

2018-10-21 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > This is a follow-up of the following thread: > https://www.postgresql.org/message-id/20181012010411.re53cwcistcpi...@alap3.anarazel.de Thanks for starting this thread Michael. > pg_verify_checksums used first a blacklist to decide if

Re: found xmin x from before relfrozenxid y

2018-10-21 Thread Tom Lane
=?UTF-8?Q?Johannes_Gra=c3=abn?= writes: > after upgrading to version 11, I see the error pattern "found xmin x > from before relfrozenxid y" in different databases on different hosts. > From https://www.postgresql.org/docs/10/static/release-10-3.html, I > learned that this was an error caused by

More issues with pg_verify_checksums and checksum verification in base backups

2018-10-21 Thread Michael Paquier
Hi all, This is a follow-up of the following thread: https://www.postgresql.org/message-id/20181012010411.re53cwcistcpi...@alap3.anarazel.de In a nutshell, b34e84f1 has added TAP tests for pg_verify_checksums, and the buildfarm has immediately complained about files generated by EXEC_BACKEND