On Tue, Feb 05, 2019 at 05:46:55PM +1300, David Rowley wrote:
> I did leave a couple untouched as there was quite a bit of escaping
> going on already. I didn't think switching between \Q and \E would
> have made those ones any more pleasing to the eye.
-qr/^ALTER TABLE dump_test.test_table EN
On Tue, Feb 5, 2019 at 4:29 PM Andres Freund wrote:
> Hi,
>
> trigger.c goes through some trouble to free the tuples returned by
> trigger functions. There's plenty codepaths that look roughly like:
> if (oldtuple != newtuple && oldtuple != slottuple)
> hea
Hi,
On 2019-02-05 06:57:06 +0100, Fabien COELHO wrote:
> > > > I'm wondering (possibly again) about the existing early exit if one
> > > > block
> > > > cannot be read on retry: the command should count this as a kind of bad
> > > > block, proceed on checking other files, and obviously fail in th
Hallo Michael,
I'm wondering (possibly again) about the existing early exit if one block
cannot be read on retry: the command should count this as a kind of bad
block, proceed on checking other files, and obviously fail in the end, but
having checked everything else and generated a report. I d
On Monday, February 4, 2019, David Rowley
wrote:
> On Tue, 5 Feb 2019 at 01:12, Daniel Gustafsson wrote:
> > We may also want to use the + metacharacter instead of * in a few
> places, since
> > the intent is to always match something, where matching nothing should be
> > considered an error:
>
Hi,
trigger.c goes through some trouble to free the tuples returned by
trigger functions. There's plenty codepaths that look roughly like:
if (oldtuple != newtuple && oldtuple != slottuple)
heap_freetuple(oldtuple);
if (newtuple == NULL)
On Tue, 5 Feb 2019 at 01:12, Daniel Gustafsson wrote:
> We may also want to use the + metacharacter instead of * in a few places,
> since
> the intent is to always match something, where matching nothing should be
> considered an error:
>
> - qr/^ALTER TEXT SEARCH DICTIONARY dump_
On Tue, 5 Feb 2019 at 14:41, Michael Paquier wrote:
> Instead of the approach you are
> proposing, perhaps it would make sense to extend this way of doing
> things then? For example some tests with CREATE CONVERSION do so. It
> looks much more portable than having to escape every dot.
I'm not
On Wed, 28 Nov 2018 at 01:55, David Rowley wrote:
> If this looks like a good path to go in, then I can produce something
> a bit more finished. I'm just a bit unsure when exactly I can do that
> as I'm on leave and have other commitments to take care of.
This patch is still on my list, so I had
On Mon, Feb 04, 2019 at 04:10:09PM +0100, Andreas Karlsson wrote:
> Should I submit it as a separate CF entry or is it easiest if my refactoring
> and Mi Tar's feature are reviewed together?
The refactoring patch is talking about changing the way objects are
created within a CTAS, which is quite d
On Mon, Feb 04, 2019 at 04:32:05PM +0100, Adrien NAYRAT wrote:
> Could it be acceptable if I set log_min_duration_statement = 0?
At least this has the merit to make the behavior not rely on
randomness. I have not looked at the patch in details so I cannot say
for sure, but I am not sure if it is
On Mon, Feb 04, 2019 at 11:58:28AM +0100, Peter Eisentraut wrote:
> I think the recovery parameters
>
> archive_cleanup_command
Only triggered by the checkpointer.
> promote_trigger_file
> recovery_end_command
> recovery_min_apply_delay
Only looked at by the startup process.
>
On 04.02.2019 10:04, Michael Paquier wrote:
> On Tue, Dec 18, 2018 at 10:41:48AM +0500, Andrey Lepikhov wrote:
>> Ok. It is used only for demonstration.
>
> The latest patch set needs a rebase, so moved to next CF, waiting on
> author as this got no reviews.
The new version in attachment.
> --
> M
On Fri, Feb 1, 2019 at 8:19 AM Masahiko Sawada
wrote:
> On Wed, Jan 30, 2019 at 2:06 AM Haribabu Kommi
> wrote:
> >
> >
> >
> >
> > + * Before starting parallel index vacuum and parallel cleanup index we
> launch
> > + * parallel workers. All parallel workers will exit after processed all
> inde
On Mon, Feb 4, 2019 at 2:27 PM John Naylor
wrote:
>
> On Mon, Feb 4, 2019 at 8:41 AM Amit Kapila
wrote:
> >
> > The change seems to have worked. All the buildfarm machines that were
> > showing the failure are passed now.
>
> Excellent!
>
> Now that the buildfarm is green as far as this patch go
>From: br...@momjian.us [mailto:br...@momjian.us]
>On Mon, Feb 4, 2019 at 08:23:39AM +, Tsunakawa, Takayuki wrote:
>> Horiguchi-san, Bruce, all, So, why don't we make
>> syscache_memory_target the upper limit on the total size of all
>> catcaches, and rethink the past LRU management?
>
>I was g
From: br...@momjian.us [mailto:br...@momjian.us]
> On Mon, Feb 4, 2019 at 08:23:39AM +, Tsunakawa, Takayuki wrote:
> > Horiguchi-san, Bruce, all, So, why don't we make
> > syscache_memory_target the upper limit on the total size of all
> > catcaches, and rethink the past LRU management?
>
> I
On Tue, Feb 05, 2019 at 01:50:50PM +1300, David Rowley wrote:
> I think I've done all the ones that use \E. Those \Q ones don't need
> any escaping. I assume that's the ones you've found. I didn't do an
> exhaustive check though.
Oh, good point. I didn't know that anything between \Q and \E are
On Tue, 5 Feb 2019 at 13:15, Michael Paquier wrote:
> Some tests are missing the update, and it seems to me that
> tightening things up is a good thing, still we ought to do it
> consistently. Some places missing the update:
> - ALTER OPERATOR FAMILY
> - ALTER OPERATOR CLASS
> - ALTER SEQUENCE
>
On Mon, Feb 04, 2019 at 01:12:48PM +0100, Daniel Gustafsson wrote:
> +1 for tightening it up, and the patch looks good to me.
>
> We may also want to use the + metacharacter instead of * in a few places,
> since
> the intent is to always match something, where matching nothing should be
> conside
Actually, index-based replica identities failed in pg_dump: we first
create the index ONLY on the partitioned table (marking it as invalid),
so when we immediately do the ALTER TABLE/REPLICA IDENTITY, it rejects
the invalid index. If we change the code to allow invalid indexes on
partitioned table
On Thu, 31 Jan 2019 at 17:22, David Rowley wrote:
> I've also attached a rebased patch.
Rebased again.
--
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
v12-0001-Forgo-generating-single-subpath-Append-and-Merge.patch
Desc
On Mon, Feb 4, 2019 at 08:23:39AM +, Tsunakawa, Takayuki wrote:
> Horiguchi-san, Bruce, all, So, why don't we make
> syscache_memory_target the upper limit on the total size of all
> catcaches, and rethink the past LRU management?
I was going to say that our experience with LRU has been that t
Some things from this thread were left for post-11; see attached patch.
Specifically, this changes pg_dump and ruleutils.c to use the FUNCTION
keyword instead of PROCEDURE in trigger and event trigger definitions,
which was postponed because of the required catversion bump.
--
Peter Eisentraut
On 2/3/19, 1:48 PM, "Masahiko Sawada" wrote:
> On Sat, Feb 2, 2019 at 7:00 PM Alvaro Herrera
> wrote:
>>
>> On 2019-Feb-01, Bossart, Nathan wrote:
>>
>> > IMHO we could document this feature at a slightly higher level without
>> > leaving out any really important user-facing behavior. Here's a
On 2019-Feb-04, Alvaro Herrera wrote:
> I'll now look more carefully at the cases involving indexes; thus far I
> was looking at the ones using FULL. Those seem to work as intended.
Yeah, that didn't work so well -- it was trying to propagate the command
verbatim to each partition, and obviously
Hi,
po 4. 2. 2019 v 6:10 odesílatel Michael Paquier
napsal:
> On Fri, Jan 04, 2019 at 02:17:49PM +0100, Pavel Stehule wrote:
> > It means to write own lexer and preparse source code before I start
> > checking.
> >
> > I think so block level PRAGMA is significantly better solution
>
> Please not
> I propose to change the behavior to:
... this patch.
I'll now look more carefully at the cases involving indexes; thus far I
was looking at the ones using FULL. Those seem to work as intended.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support,
Hello
If you do ALTER TABLE .. REPLICA IDENTITY to a partitioned table, the
command operates on the parent table itself and does not propagate to
partitions. Why is this? Maybe not recursing was the right call when
we only had regular inheritance (back in 9.4), but since partitioned
tables got i
Hi,
On 31.01.2019 9:21, Arseny Sher wrote:
My colleague Alexander Lakhin has noticed an assertion failure in
reorderbuffer.c:1330. Here is a simple snippet reproducing it:
SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot',
'test_decoding');
create table t(k int);
begin;
On 2/4/19 3:26 AM, Michael Paquier wrote:
These would take time to execute, even if you need to measure one
second, and may be hard to make stable on slow machines.
Could it be acceptable if I set log_min_duration_statement = 0?
Moved to next CF.
Thanks
On 2/4/19 7:09 AM, Michael Paquier wrote:
On Tue, Jan 22, 2019 at 03:10:17AM +0100, Andreas Karlsson wrote:
On 1/21/19 3:31 AM, Andreas Karlsson wrote:
Here is a a stab at refactoring this so the object creation does not
happen in a callback.
Rebased my patch on top of Andres's pluggable stor
Hi Tomas,
On 14.01.2019 21:23, Tomas Vondra wrote:
Attached is an updated patch series, merging fixes and changes to TAP
tests proposed by Alexey. I've merged the fixes into the appropriate
patches, and I've kept the TAP changes / new tests as separate patches
towards the end of the series.
I
On Mon, Feb 4, 2019 at 12:02 AM David Rowley
wrote:
> If the PartitionDesc from the parallel worker has an extra partition
> than what was there when the plan was built then the partition index
> to subplan index translation will be incorrect as the
> find_matching_subplans_recurse() will call get
> On 4 Feb 2019, at 11:54, David Rowley wrote:
>
> There are a few regexes in pg_dump's tap tests that are neglecting to
> escape the dot in "schema.table" type expressions. This could result
> in the test passing when it shouldn't. It seems worth putting that
> right.
+1 for tightening it up,
Merge back in some code changes made in the Ryu patch that really belong
here, in preparation for rebasing Ryu on top of this (since this is
really a separate functional change). Posting this mainly to let cfbot
take a look at it.
--
Andrew (irc:RhodiumToad)
diff --git a/configure b/configure
in
This could probably use a quick note in the docs.
There are a few regexes in pg_dump's tap tests that are neglecting to
escape the dot in "schema.table" type expressions. This could result
in the test passing when it shouldn't. It seems worth putting that
right.
Patch attached.
--
David Rowley http://www.2ndQuadrant.com/
Po
I think the recovery parameters
archive_cleanup_command
promote_trigger_file
recovery_end_command
recovery_min_apply_delay
can be changed from PGC_POSTMASTER to PGC_SIGHUP without any further
complications (unlike for example primary_conninfo, which is being
discussed elsewhere).
On Mon, Feb 4, 2019 at 8:29 AM Michael Paquier wrote:
>
> This patch needs a rebase because of conflicts done recently for
> pluggable storage, so moved to next CF, waiting on author.
> --
>
Thank you . rebased against current master
regards
Surafel
diff --git a/doc/src/sgml/ref/select.sgml b/d
On 2019-Feb-04, Tomas Vondra wrote:
> On 2/4/19 6:54 AM, Michael Paquier wrote:
> > On Tue, Oct 02, 2018 at 11:49:05AM +0900, Michael Paquier wrote:
> >> The latest patch set does not apply cleanly. Could you rebase it? I
> >> have moved the patch to CF 2018-10 for now, waiting on author.
> >
>
On 2/4/19 6:54 AM, Michael Paquier wrote:
> On Tue, Oct 02, 2018 at 11:49:05AM +0900, Michael Paquier wrote:
>> The latest patch set does not apply cleanly. Could you rebase it? I
>> have moved the patch to CF 2018-10 for now, waiting on author.
>
> It's been some time since that request, so I a
On 2/4/19 5:53 AM, Michael Paquier wrote:
> On Sun, Feb 03, 2019 at 02:43:24AM -0800, Andres Freund wrote:
>> Are you planning to update the patch, or should the entry be marked as
>> RWF?
>
> Moved the patch to next CF for now, waiting on author as the last
> review happened not so long ago.
Thanks for looking at this.
On Fri, 1 Feb 2019 at 11:45, Alvaro Herrera wrote:
>
> I only have cosmetic suggestions for this patch. For one thing, I think
> the .c file should be in src/port and its header should be in
> src/include/port/, right beside the likes of pg_bswap.h and pg_crc32c.h.
I
On Sat, Feb 2, 2019 at 11:26 AM Fabien COELHO wrote:
>
> Hello David,
>
> > Wondering if you have anything else here? I'm happy for the v13
> > version to be marked as ready for committer.
>
> I still have a few comments.
>
> Patch applies cleanly, compiles, global & local make check are ok.
>
>
Mohammad Sherafat wrote:
> In the name of god!
It is not considered good style to hurt people's religious feelings
by using the name of god in vain.
> What happens if checkpoint haven't completed until the next checkpoint
> interval or max_wal_size?
Then you have two checkpoints active at the s
On Mon, Feb 4, 2019 at 8:41 AM Amit Kapila wrote:
> > Yeah that can also work, but we still need to be careful about the
> > alignment of that one tuple, otherwise, there will could be different
> > free space on the fifth page. The probably easier way could be to use
> > an even number of intege
Horiguchi-san, Bruce, all,
I hesitate to say this, but I think there are the following problems with the
proposed approach:
1) Tries to prune the catalog tuples only when the hash table is about to
expand.
If no tuple is found to be eligible for eviction at first and the hash table
expands, it
48 matches
Mail list logo
