Hi, hackers!
I'm a student participating in GSoC 2019 and my project is related to TOAST
slices.
When I'm getting familiar with the postgresql codebase, I find that
PG_DETOAST_DATUM_SLICE, when to run on a compressed TOAST entry, will fetch
all compressed data chunks then extract the relevant slice
cpluspluscheck's expanded coverage is now passing cleanly for me on
the macOS laptop I was testing it with at PGCon. But on returning
home, I find there's still some issues on some other boxes:
* On Linux (at least Fedora and RHEL), I get variants of this:
/usr/include/arpa/inet.h:84: error: dec
The unused_oids script has gone from being something of interest to
everybody that wants to write a patch that creates a new catalog
entry, to something that patch authors could do without in many cases.
I think that its output should prominently advertise that patches
should use random OIDs in the
Hi James,
On Fri, May 31, 2019 at 03:51:57PM -0400, James Coleman wrote:
I've rebased the patch on master and confirmed make check world passes.
Thanks for the rebase! I think the patch is in pretty good shape - I'm
sure we'll find ways to make it more efficient etc. but IMO that's fine
and sh
Thanks for finding these ; I think a few hunks are false positives and should
be removed. A few more are debatable and could be correct either way:
Kazakstan
alloced - not an English word, but a technical one;
delink - "unlink" is better for the filesystem operation, but I don't think
"delink" i
On Tue, May 28, 2019 at 12:15:35PM -0400, Magnus Hagander wrote:
> On Fri, May 24, 2019 at 11:24 AM Noah Misch wrote:
> > On Thu, May 23, 2019 at 06:56:49PM +0200, Magnus Hagander wrote:
> > > On Thu, May 23, 2019, 18:54 Peter Eisentraut
> > > wrote:
> > > > To recap, the idea here was to change
On Sat, Jun 01, 2019 at 12:44:05PM -0700, Andres Freund wrote:
> "I'm fine with adding those for 12", so no, I'm not strongly opposed.
OK, fixed this one for now.
--
Michael
signature.asc
Description: PGP signature
On Sun, Jun 02, 2019 at 04:42:57PM -0500, Justin Pryzby wrote:
> Thanks for finding these ; I think a few hunks are false positives and should
> be removed.
Yes, some of them are the changes in imath.c and snowball/, which we
include in Postgres but in reality are independent projects, so these
sh
Donald Dong writes:
> I noticed that debug_print_rel outputs "unknown expr" when the fields
> in baserestrictinfo are typed as varchar.
> ...
> I wonder if this is a proper way of fixing it?
It's hard to muster much enthusiasm for extending print_expr(),
considering how incomplete and little-used
On Thu, Apr 11, 2019 at 9:13 AM Haribabu Kommi
wrote:
> I fixed all the comments that you have raised above and attached the
> updated
> patches.
>
Rebased patches are attached.
Regards,
Haribabu Kommi
Fujitsu Australia
0001-New-pg_basebackup-g-option-to-control-the-group-acce.patch
Descripti
Hi, hackers!
I'm a student participating in GSoC 2019 and my project is related to TOAST
slices.
When I'm getting familiar with the postgresql codebase, I find that
PG_DETOAST_DATUM_SLICE, when to run on a compressed TOAST entry, will fetch
all compressed data chunks then extract the relevant slice
cpluspluscheck's expanded coverage is now passing cleanly for me on
the macOS laptop I was testing it with at PGCon. But on returning
home, I find there's still some issues on some other boxes:
* On Linux (at least Fedora and RHEL), I get variants of this:
/usr/include/arpa/inet.h:84: error: dec
The unused_oids script has gone from being something of interest to
everybody that wants to write a patch that creates a new catalog
entry, to something that patch authors could do without in many cases.
I think that its output should prominently advertise that patches
should use random OIDs in the
Hi James,
On Fri, May 31, 2019 at 03:51:57PM -0400, James Coleman wrote:
I've rebased the patch on master and confirmed make check world passes.
Thanks for the rebase! I think the patch is in pretty good shape - I'm
sure we'll find ways to make it more efficient etc. but IMO that's fine
and sh
Thanks for finding these ; I think a few hunks are false positives and should
be removed. A few more are debatable and could be correct either way:
Kazakstan
alloced - not an English word, but a technical one;
delink - "unlink" is better for the filesystem operation, but I don't think
"delink" i
On Tue, May 28, 2019 at 12:15:35PM -0400, Magnus Hagander wrote:
> On Fri, May 24, 2019 at 11:24 AM Noah Misch wrote:
> > On Thu, May 23, 2019 at 06:56:49PM +0200, Magnus Hagander wrote:
> > > On Thu, May 23, 2019, 18:54 Peter Eisentraut
> > > wrote:
> > > > To recap, the idea here was to change
On Sat, Jun 01, 2019 at 12:44:05PM -0700, Andres Freund wrote:
> "I'm fine with adding those for 12", so no, I'm not strongly opposed.
OK, fixed this one for now.
--
Michael
signature.asc
Description: PGP signature
On Sun, Jun 02, 2019 at 04:42:57PM -0500, Justin Pryzby wrote:
> Thanks for finding these ; I think a few hunks are false positives and should
> be removed.
Yes, some of them are the changes in imath.c and snowball/, which we
include in Postgres but in reality are independent projects, so these
sh
Donald Dong writes:
> I noticed that debug_print_rel outputs "unknown expr" when the fields
> in baserestrictinfo are typed as varchar.
> ...
> I wonder if this is a proper way of fixing it?
It's hard to muster much enthusiasm for extending print_expr(),
considering how incomplete and little-used
On Thu, Apr 11, 2019 at 9:13 AM Haribabu Kommi
wrote:
> I fixed all the comments that you have raised above and attached the
> updated
> patches.
>
Rebased patches are attached.
Regards,
Haribabu Kommi
Fujitsu Australia
0001-New-pg_basebackup-g-option-to-control-the-group-acce.patch
Descripti
20 matches
Mail list logo
