Re: implicit declaration of datumIsEqual in parse_coerce.c

2020-05-02 Thread Noah Misch
On Tue, Apr 07, 2020 at 10:39:30PM -0400, Tom Lane wrote: > > On Tue, Apr 07, 2020 at 05:16:58PM -0400, Tom Lane wrote: > >> That's inside "#ifdef RANDOMIZE_ALLOCATED_MEMORY", which probably > >> explains why most of us aren't seeing it. My guess is somebody > >> removed an #include without realiz

Re: full-text search with GiST indexes seems to be getting slower since 9.1

2020-05-02 Thread Tom Lane
Tomas Vondra writes: > over the past couple of weeks I've been running various benchmarks with > the intent to demonstrate how the performance evolved since ~8.3. In > most tests we're doing pretty good, but I've noticed that full-text > search using GiST indexes is an annoying exception - it's ge

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

2020-05-02 Thread Justin Pryzby
On Sun, Apr 12, 2020 at 01:53:40PM +0200, Fabien COELHO wrote: > About v15, seen as one patch. Thanks for looking. > - I'm wondering whether could pg_stat_file call pg_ls_dir_files without > too much effort? ISTM that the output structure nearly the same. I do > not like much having one funct

Re: design for parallel backup

2020-05-02 Thread Andres Freund
Hi, On 2020-05-01 16:32:15 -0400, Robert Haas wrote: > On Thu, Apr 30, 2020 at 6:06 PM Robert Haas wrote: > > On Thu, Apr 30, 2020 at 3:52 PM Andres Freund wrote: > > > Why 8kb? That's smaller than what we currently do in pg_basebackup, > > > afaictl, and you're actually going to be bottlenecked

Re: pg_stat_reset_slru(name) doesn't seem to work as documented

2020-05-02 Thread Atsushi Torikoshi
On Sat, May 2, 2020 at 11:05 PM Tomas Vondra wrote > Pushed. Thanks for the report. > Thanks! -- Atsushi Torikoshi

Re: Failed test 'pg_recvlogical acknowledged changes, nothing pending on slot'

2020-05-02 Thread Noah Misch
On Mon, Jan 29, 2018 at 10:09:49AM +1300, Thomas Munro wrote: > https://travis-ci.org/postgresql-cfbot/postgresql/builds/334334417 > > # Failed test 'pg_recvlogical acknowledged changes, nothing pending on slot' > # at t/006_logical_decoding.pl line 91. > # got: 'BEGIN > # table publi

Re: Fixes for two separate bugs in nbtree VACUUM's page deletion

2020-05-02 Thread Peter Geoghegan
On Thu, Apr 30, 2020 at 12:20 AM Masahiko Sawada wrote: > For the part of treating that case as an index corruption I will need > some time to review because of lacking knowledge of btree indexes. So > I'll review it later. I pushed the refactoring patch today. Thanks for the review. The final t

Re: Problems with GSS encryption and SSL in libpq in 12~

2020-05-02 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > On Mon, Apr 06, 2020 at 04:25:57PM +0900, Michael Paquier wrote: > > It is possible to enforce this flag to false by using > > gssencmode=disable, but that's not really user-friendly in my opinion > > because nobody is going to remember t

Re: Problems with GSS encryption and SSL in libpq in 12~

2020-05-02 Thread Stephen Frost
Greetings, * Michael Paquier (mich...@paquier.xyz) wrote: > A quick make check with Postgres 11 and 12 for src/test/ssl/ shows a > lot of difference in run time, using the same set of options with SSL > and the same compilation flags (OpenSSL 1.1.1f, with debugging and > assertions enabled among o

Re: Protocol problem with GSSAPI encryption?

2020-05-02 Thread Stephen Frost
Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Andrew Gierth (and...@tao11.riddles.org.uk) wrote: > > > "Peter" == Peter Eisentraut writes: > > > > >> It seems to me that this is a bug in ProcessStartupPacket, which > > >> should accept both GSS or SSL negotiation requests on a

Re: SLRU statistics

2020-05-02 Thread Tomas Vondra
On Sat, May 02, 2020 at 12:55:00PM +0200, Tomas Vondra wrote: On Sat, May 02, 2020 at 03:56:07PM +0900, Fujii Masao wrote: ... Another thing I found is; pgstat_send_slru() should be called also by other processes than backend? For example, since clog data is flushed basically by checkpointer

Re: WIP: WAL prefetch (another approach)

2020-05-02 Thread Dmitry Dolgov
> On Sat, Apr 25, 2020 at 09:19:35PM +0200, Dmitry Dolgov wrote: > > On Tue, Apr 21, 2020 at 05:26:52PM +1200, Thomas Munro wrote: > > > > One report I heard recently said that if you get rid of I/O stalls, > > pread() becomes cheap enough that the much higher frequency lseek() > > calls I've comp

Re: pg_stat_reset_slru(name) doesn't seem to work as documented

2020-05-02 Thread Tomas Vondra
On Sat, May 02, 2020 at 02:27:33PM +0200, Tomas Vondra wrote: On Fri, May 01, 2020 at 07:10:23PM +0900, Atsushi Torikoshi wrote: Hi, When I tried to reset a counter in pg_stat_slru using pg_stat_reset_slru(name), not only the specified counter but all the counters were reset. postgres=# SELECT

Re: Unify drop-by-OID functions

2020-05-02 Thread Ranier Vilela
Em sáb., 2 de mai. de 2020 às 05:01, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> escreveu: > On 2020-05-01 23:31, Ranier Vilela wrote: > > I can suggest improvements? > > > > 1. In case Object is cached, delay open_table until the last moment, for > > the row to be blocked as little as po

Re: pg_stat_reset_slru(name) doesn't seem to work as documented

2020-05-02 Thread Tomas Vondra
On Fri, May 01, 2020 at 07:10:23PM +0900, Atsushi Torikoshi wrote: Hi, When I tried to reset a counter in pg_stat_slru using pg_stat_reset_slru(name), not only the specified counter but all the counters were reset. postgres=# SELECT * FROM pg_stat_slru ; name | blks_zeroed | blks

Re: WAL usage calculation patch

2020-05-02 Thread Amit Kapila
On Thu, Apr 30, 2020 at 2:19 PM Julien Rouhaud wrote: > > On Thu, Apr 30, 2020 at 9:18 AM Julien Rouhaud wrote: > > > > On Thu, Apr 30, 2020 at 5:05 AM Amit Kapila wrote: > > > > > > Julien, are you planning to write a cleanup patch for this open item? > > > > Sorry Amit, I've been quite busy at

Re: Back-patch is necessary? Re: Don't try fetching future segment of a TLI.

2020-05-02 Thread Amit Kapila
On Thu, Apr 30, 2020 at 7:46 PM Fujii Masao wrote: > > On 2020/04/08 1:49, Fujii Masao wrote: > > > > > > On 2020/04/07 20:21, David Steele wrote: > >> > >> On 4/7/20 3:48 AM, Kyotaro Horiguchi wrote: > >>> At Tue, 7 Apr 2020 12:15:00 +0900, Fujii Masao > >>> wrote in > >> This doesn't seem

Re: Rotten parts of src/backend/replication/README

2020-05-02 Thread Amit Kapila
On Sat, May 2, 2020 at 8:16 AM Michael Paquier wrote: > > Hi all, > > The first part of src/backend/replication/README lists all the APIs > usable for a WAL receiver, but these have aged and lost track of most > changes that happened over the years. Four functions are listed in > the README, with

Re: SLRU statistics

2020-05-02 Thread Tomas Vondra
On Sat, May 02, 2020 at 03:56:07PM +0900, Fujii Masao wrote: On 2020/05/02 9:08, Tomas Vondra wrote: On Fri, May 01, 2020 at 11:49:51AM +0900, Fujii Masao wrote: On 2020/05/01 3:19, Tomas Vondra wrote: On Fri, May 01, 2020 at 03:02:59AM +0900, Fujii Masao wrote: On 2020/04/02 9:41, Toma

Re: Unify drop-by-OID functions

2020-05-02 Thread Peter Eisentraut
On 2020-05-01 23:31, Ranier Vilela wrote: I can suggest improvements? 1. In case Object is cached, delay open_table until the last moment, for the row to be blocked as little as possible and close the table as quickly as possible. 2. In case Object is cached and the tuple is invalid, do not o