Hello Tom,
oid OID
Meh. I'm not a fan of overuse of upper case --- it's well established
that that's harder to read than lower or mixed case. And it's definitely
project policy that type names are generally treated as identifiers not
keywords, even if some of them happen to be keywords
Hello Bruce,
* "DOCUMENT THE DEFAULT GENERATION METHOD"
=> The default is still to generate data client-side.
My point is that the docs are not clear about this.
Indeed.
Can you fix it?
Sure. Attached patch adds an explicit sentence about it, as it was only
hinted about in the
On Wed, May 6, 2020 at 4:19 AM Juan José Santamaría Flecha
wrote:
>
> On Tue, May 5, 2020 at 1:34 PM Amit Kapila wrote:
>>
>>
>> Apart from that, I have made a few other changes in comments, fixed
>> typos, and ran pgindent. Let me know what do you think of attached
>> patches?
>
>
> The
And one more question, what LogAccessExclusiveLocks in LogStandbySnapshot is
used for? Can We remove this.
> 2020年5月6日 上午10:36，邱宇航 写道：
>
> I mean that all resources protected by XLOG_STANDBY_LOCK should redo later.
> The semantics of XLOG_STANDBY_LOCK is still kept.
>
I mean that all resources protected by XLOG_STANDBY_LOCK should redo later.
The semantics of XLOG_STANDBY_LOCK is still kept.
> 2020年4月30日 下午7:12，Amit Kapila 写道：
>
> On Thu, Apr 30, 2020 at 4:07 PM 邱宇航 wrote:
>>
>> I noticed that in hot standby, XLOG_STANDBY_LOCK redo is sometimes block by
On 5/5/20 7:42 PM, Tom Lane wrote:
> Here's a really quick-n-dirty prototype patch that just converts the
> pg_aggregate table to the proposed style, plus a screenshot for those
> who don't feel like actually building the docs with the patch.
Not opposed to building the docs, but the screenshot
Only as a homework, is this function completely useless?
ItemPointerData
systable_scan_next(Relation heapRelation,
Oid indexId,
bool indexOK,
Snapshot snapshot,
int nkeys, ScanKey key)
{
SysScanDesc scan;
HeapTuple htup;
ItemPointerData tid;
scan =
On Tue, May 5, 2020 at 1:34 PM Amit Kapila wrote:
>
> Apart from that, I have made a few other changes in comments, fixed
> typos, and ran pgindent. Let me know what do you think of attached
> patches?
>
The patches are definitely in better shape.
I think that the definition of
On Wed, 6 May 2020 at 07:14, Peter Geoghegan wrote:
>
> On Tue, May 5, 2020 at 2:52 PM Masahiko Sawada
> wrote:
> > So IIUC the problem is that since we skip both,
> > oldst_btpo_xact could be seen as a "future" xid during vacuum. Which
> > will be a cause of that vacuum misses pages which can
On Tue, May 5, 2020 at 4:06 PM Michael Paquier wrote:
> On Mon, May 04, 2020 at 03:42:20PM +0200, Juan José Santamaría Flecha
> wrote:
> > +1, seems like the way to go to me.
>
> Attached is a patch for that and I have gone with a simple solution,
> with some bonus comments about the way things
On Tue, May 5, 2020 at 2:52 PM Masahiko Sawada
wrote:
> So IIUC the problem is that since we skip both,
> oldst_btpo_xact could be seen as a "future" xid during vacuum. Which
> will be a cause of that vacuum misses pages which can actually be
> recycled.
This is also my understanding of the
Em ter., 5 de mai. de 2020 às 18:11, Alvaro Herrera <
alvhe...@2ndquadrant.com> escreveu:
> On 2020-May-05, Ranier Vilela wrote:
>
> > And in that specific case, leaving resources blocked, which perhaps, in
> my
> > humble opinion, could be released quickly.
>
> I very much doubt that you can
On Sat, 18 Apr 2020 at 03:22, Robert Haas wrote:
>
> On Thu, Apr 16, 2020 at 6:49 PM Andres Freund wrote:
> > Yea. _bt_vacuum_needs_cleanup() needs to check if
> > metad->btm_oldest_btpo_xact is older than the FreezeLimit computed by
> > vacuum_set_xid_limits() and vacuum the index if so even if
On Tue, May 5, 2020 at 04:39:58PM -0500, Justin Pryzby wrote:
> On Tue, May 05, 2020 at 05:34:26PM -0400, Bruce Momjian wrote:
> > On Tue, May 5, 2020 at 02:37:16PM -0400, Bruce Momjian wrote:
> > > On Tue, May 5, 2020 at 12:50:11PM -0500, Justin Pryzby wrote:
> > > > Do you want to include any
On Tue, May 05, 2020 at 05:34:26PM -0400, Bruce Momjian wrote:
> On Tue, May 5, 2020 at 02:37:16PM -0400, Bruce Momjian wrote:
> > On Tue, May 5, 2020 at 12:50:11PM -0500, Justin Pryzby wrote:
> > > Do you want to include any of these?
> > >
> > > 5823677acc Provide pgbench --show-script to
On Tue, May 5, 2020 at 05:31:26PM -0400, Tom Lane wrote:
> Alvaro Herrera writes:
> > On 2020-May-05, Bruce Momjian wrote:
> >> I tried a few approaches but ended up with this:
> >>
> >> Improve control of prepared statement parameter logging (Alexey
> >> Bashtanov, lvaro Herrera)
> >>
> >>
On Tue, May 5, 2020 at 02:37:16PM -0400, Bruce Momjian wrote:
> On Tue, May 5, 2020 at 12:50:11PM -0500, Justin Pryzby wrote:
> > Do you want to include any of these?
> >
> > 5823677acc Provide pgbench --show-script to dump built-in scripts.
I have added the above entry to the release notes.
Alvaro Herrera writes:
> On 2020-May-05, Bruce Momjian wrote:
>> I tried a few approaches but ended up with this:
>>
>> Improve control of prepared statement parameter logging (Alexey
>> Bashtanov, lvaro Herrera)
>>
>> The GUC setting log_parameter_max_length controls the maximum
>> length of
On 2020-May-05, Ranier Vilela wrote:
> And in that specific case, leaving resources blocked, which perhaps, in my
> humble opinion, could be released quickly.
I very much doubt that you can measure any difference at all between
these two codings of the function.
I agree with the principle you
On Tue, May 5, 2020 at 03:44:37PM -0400, Alvaro Herrera wrote:
> On 2020-May-05, Bruce Momjian wrote:
>
> > On Tue, May 5, 2020 at 12:50:11PM -0500, Justin Pryzby wrote:
> > > Do you want to include any of these?
> > >
> > > 5823677acc Provide pgbench --show-script to dump built-in scripts.
>
On Tue, May 5, 2020 at 03:21:00PM -0400, Alvaro Herrera wrote:
> On 2020-May-05, Bruce Momjian wrote:
>
> > > |Allow incremental sorting (James Coleman, Alexander Korotkov)
> > > s/Allow/Implement/ ?
> >
> > Agreed.
>
> FWIW I think Tomas Vondra should be credited as coauthor of this
>
On Tue, May 5, 2020 at 01:45:37PM -0500, Justin Pryzby wrote:
> On Tue, May 05, 2020 at 02:10:24PM -0400, Bruce Momjian wrote:
> > > > > | This is controlled by GUC wal_skip_threshold.
> > > > > I think you should say that's a size threshold which determines which
> > > > > strategy
> > > > >
On Tue, May 5, 2020 at 11:44:33AM -0700, Jeff Davis wrote:
> On Mon, 2020-05-04 at 23:16 -0400, Bruce Momjian wrote:
> > I have committed the first draft of the PG 13 release notes. You can
> > see them here:
> >
> > https://momjian.us/pgsql_docs/release-13.html
> >
> > It still needs
On Tue, May 05, 2020 at 03:44:37PM -0400, Alvaro Herrera wrote:
> On 2020-May-05, Bruce Momjian wrote:
> > On Tue, May 5, 2020 at 12:50:11PM -0500, Justin Pryzby wrote:
> > > Do you want to include any of these?
> > >
> > > 5823677acc Provide pgbench --show-script to dump built-in scripts.
> > >
On 2020-May-05, Bruce Momjian wrote:
> On Tue, May 5, 2020 at 12:50:11PM -0500, Justin Pryzby wrote:
> > Do you want to include any of these?
> >
> > 5823677acc Provide pgbench --show-script to dump built-in scripts.
> > ce8f946764 Report the time taken by pgbench initialization steps.
>
> I
On 5/5/20 3:21 PM, Alvaro Herrera wrote:
On 2020-May-05, Bruce Momjian wrote:
|Allow incremental sorting (James Coleman, Alexander Korotkov)
s/Allow/Implement/ ?
Agreed.
FWIW I think Tomas Vondra should be credited as coauthor of this
feature. He didn't list himself as author in the
On 2020-May-05, Bruce Momjian wrote:
> > |Allow incremental sorting (James Coleman, Alexander Korotkov)
> > s/Allow/Implement/ ?
>
> Agreed.
FWIW I think Tomas Vondra should be credited as coauthor of this
feature. He didn't list himself as author in the commit message but I'm
pretty sure
On Tue, May 5, 2020 at 12:44 PM Amit Kapila wrote:
>
> On Mon, May 4, 2020 at 8:03 PM Julien Rouhaud wrote:
> >
> > On Mon, May 4, 2020 at 6:10 AM Amit Kapila wrote:
> > >
> > > On Thu, Apr 30, 2020 at 2:19 PM Julien Rouhaud wrote:
> > > >
> > > > Here's the patch. I included the content of
>
On Tue, May 05, 2020 at 02:10:24PM -0400, Bruce Momjian wrote:
> > > > | This is controlled by GUC wal_skip_threshold.
> > > > I think you should say that's a size threshold which determines which
> > > > strategy
> > > > to use (WAL or fsync).
> > >
> > > I went with:
> > > The WAL write
On Mon, 2020-05-04 at 23:16 -0400, Bruce Momjian wrote:
> I have committed the first draft of the PG 13 release notes. You can
> see them here:
>
> https://momjian.us/pgsql_docs/release-13.html
>
> It still needs markup, word wrap, and indenting. The community doc
> build should happen
On Tue, May 5, 2020 at 12:50:11PM -0500, Justin Pryzby wrote:
> Do you want to include any of these?
>
> 5823677acc Provide pgbench --show-script to dump built-in scripts.
> ce8f946764 Report the time taken by pgbench initialization steps.
I am kind of unclear how much of pgbench changes to put
Em ter., 5 de mai. de 2020 às 14:57, Robert Haas
escreveu:
> On Tue, May 5, 2020 at 1:43 PM Ranier Vilela wrote:
> > I see, the famous "cliché".
>
> By using the word cliché, and by putting it in quotes, you seem to
> suggest that you consider my argument dubious. However, I stand by it.
> Code
On Tue, May 5, 2020 at 12:50:01PM -0500, Justin Pryzby wrote:
> On Tue, May 05, 2020 at 01:18:09PM -0400, Bruce Momjian wrote:
> > > |Release date: 2020-05-03
> > > => Should say 2020-XX-XX, before someone like me goes and installs it
> > > everywhere in sight.
> >
> > Agreed!
> >
> > > |These
On Tue, May 5, 2020 at 1:43 PM Ranier Vilela wrote:
> I see, the famous "cliché".
By using the word cliché, and by putting it in quotes, you seem to
suggest that you consider my argument dubious. However, I stand by it.
Code shouldn't be changed without understanding the reasons behind the
Do you want to include any of these?
5823677acc Provide pgbench --show-script to dump built-in scripts.
ce8f946764 Report the time taken by pgbench initialization steps.
751c63cea0 Remove pg_regress' --load-language option.
33753ac9d7 Add object names to partition integrity violations.
246f136e76
On Tue, May 05, 2020 at 01:18:09PM -0400, Bruce Momjian wrote:
> > |Release date: 2020-05-03
> > => Should say 2020-XX-XX, before someone like me goes and installs it
> > everywhere in sight.
>
> Agreed!
>
> > |These triggers cannot change the destination partition.
> > => Maybe say "cannot
Em ter., 5 de mai. de 2020 às 14:29, Robert Haas
escreveu:
> On Tue, May 5, 2020 at 1:22 PM Ranier Vilela wrote:
> > Ok, so the question. If (3) is not safe, obvious we shouldn't use, and
> must call table_close, after systable_endscan.
> > Now (1) and (2), I would have no hesitation in using
On Tue, May 5, 2020 at 1:22 PM Ranier Vilela wrote:
> Ok, so the question. If (3) is not safe, obvious we shouldn't use, and must
> call table_close, after systable_endscan.
> Now (1) and (2), I would have no hesitation in using it.
> I work with ERP, and throughout the time, the later, lock
Em ter., 5 de mai. de 2020 às 13:06, Robert Haas
escreveu:
> On Fri, May 1, 2020 at 5:32 PM Ranier Vilela wrote:
> > I can suggest improvements?
> >
> > 1. In case Object is cached, delay open_table until the last moment, for
> the row to be blocked as little as possible and close the table as
On Tue, May 5, 2020 at 11:45:03AM -0500, Justin Pryzby wrote:
> |Release date: 2020-05-03
> => Should say 2020-XX-XX, before someone like me goes and installs it
> everywhere in sight.
Agreed!
> |These triggers cannot change the destination partition.
> => Maybe say "cannot change which
|Release date: 2020-05-03
=> Should say 2020-XX-XX, before someone like me goes and installs it
everywhere in sight.
|These triggers cannot change the destination partition.
=> Maybe say "cannot change which partition is the destination"
|Allow incremental sorting (James Coleman, Alexander
>
>
> >
> > Please do list Jürgen, Corey and Roger as authors of the glossary.
>
> (Actually I should be listed as well, as the time I spent on it was
> considerable.)
>
+1, the time spent was quite considerable
On Fri, May 1, 2020 at 5:32 PM Ranier Vilela wrote:
> I can suggest improvements?
>
> 1. In case Object is cached, delay open_table until the last moment, for the
> row to be blocked as little as possible and close the table as quickly as
> possible.
> 2. In case Object is cached and the tuple
On Tue, May 5, 2020 at 11:48:47AM -0400, Andrew Dunstan wrote:
>
> On 5/4/20 11:16 PM, Bruce Momjian wrote:
> > I have committed the first draft of the PG 13 release notes. You can
> > see them here:
> >
> > https://momjian.us/pgsql_docs/release-13.html
> >
> > It still needs markup, word
On 5/4/20 11:16 PM, Bruce Momjian wrote:
> I have committed the first draft of the PG 13 release notes. You can
> see them here:
>
> https://momjian.us/pgsql_docs/release-13.html
>
> It still needs markup, word wrap, and indenting. The community doc
> build should happen in a few hours.
On Tue, May 5, 2020 at 11:23:50AM -0400, Alvaro Herrera wrote:
> On 2020-May-05, Alvaro Herrera wrote:
>
> > On 2020-May-05, Bruce Momjian wrote:
> >
> > > On Tue, May 5, 2020 at 07:43:09AM +0200, Fabien COELHO wrote:
> >
> > > > I do not see a "documentation" section, whereas there has been
On Tue, May 5, 2020 at 11:14:11AM -0400, Alvaro Herrera wrote:
> On 2020-May-05, Bruce Momjian wrote:
>
> > On Tue, May 5, 2020 at 07:43:09AM +0200, Fabien COELHO wrote:
>
> > > I do not see a "documentation" section, whereas there has been significant
> > > doc changes, such as function table
On 2020-May-05, Alvaro Herrera wrote:
> On 2020-May-05, Bruce Momjian wrote:
>
> > On Tue, May 5, 2020 at 07:43:09AM +0200, Fabien COELHO wrote:
>
> > > I do not see a "documentation" section, whereas there has been significant
> > > doc changes, such as function table layouts (Tom), glossary
In this item
+
+
+
+
+Add the ability to remove a function's dependency on an extension (Alvaro
Herrera)
+
+
+
+The syntax is ALTER FUNCTION .. NO DEPENDS ON.
+
+
+
This works for several object types, not just a functions. I propose
Add the ability to remove an object's dependency on an
Oleksandr Shulgin writes:
> Would it be premature to complain about the not-that-great look of Table
> 9.1 now?
> Compare the two attached images: the screenshot from
> https://www.postgresql.org/docs/devel/functions-comparison.html
> vs the GIMP-assisted pipe dream of mine to align it to the
On 2020-May-05, Bruce Momjian wrote:
> On Tue, May 5, 2020 at 07:43:09AM +0200, Fabien COELHO wrote:
> > I do not see a "documentation" section, whereas there has been significant
> > doc changes, such as function table layouts (Tom), glossary (Corey, Jürgen,
>
> I did list the glossary.
On Tue, May 5, 2020 at 09:20:39PM +0800, John Naylor wrote:
> Hi Bruce, thanks for working on this again!
>
> +
> +Allow UTF-8 escapes, e.g., E'\u', in clients that don't use UTF-8
> encoding (Tom Lane)
> +
>
> I believe the term we want here is "Unicode escapes". This patch is
> about the
On Tue, May 5, 2020 at 10:07:35AM +0200, Juan José Santamaría Flecha wrote:
>
> On Tue, May 5, 2020 at 5:16 AM Bruce Momjian wrote:
>
> I have committed the first draft of the PG 13 release notes. You can
> see them here:
>
> https://momjian.us/pgsql_docs/release-13.html
Fabien COELHO writes:
> My 0.02€: I'm wondering whether the description could/should match SQL
> syntax, eg:
>oid OID
>adrelid OID REFERENCES pg_class(oid)
>adnum INT2 REFERENCES pg_attribute(attnum)
>…
> Or maybe just uppercase type names, especially when repeated?
Meh. I'm
On Tue, May 5, 2020 at 08:10:54AM +0200, Julien Rouhaud wrote:
> Hi,
>
> On Tue, May 5, 2020 at 7:47 AM Pavel Stehule wrote:
> >
> > Hi
> >
> > út 5. 5. 2020 v 5:16 odesílatel Bruce Momjian napsal:
> >>
> >> I have committed the first draft of the PG 13 release notes. You can
> >> see them
út 5. 5. 2020 v 16:18 odesílatel Bruce Momjian napsal:
> On Tue, May 5, 2020 at 07:46:34AM +0200, Pavel Stehule wrote:
> > Hi
> >
> > út 5. 5. 2020 v 5:16 odesílatel Bruce Momjian napsal:
> >
> > I have committed the first draft of the PG 13 release notes. You can
> > see them here:
>
On Tue, May 5, 2020 at 07:46:34AM +0200, Pavel Stehule wrote:
> Hi
>
> út 5. 5. 2020 v 5:16 odesílatel Bruce Momjian napsal:
>
> I have committed the first draft of the PG 13 release notes. You can
> see them here:
>
> https://momjian.us/pgsql_docs/release-13.html
>
>
Benjamin Schaller writes:
> Even though it's described as fairly complicated: If I would want to
> define my own index method, what would be a good approach to do so?
contrib/bloom would make a sensible template, perhaps.
regards, tom lane
Dean Rasheed writes:
> On Mon, 4 May 2020 at 22:22, Tom Lane wrote:
>> Now I could have done this example by spelling out all six varieties of
>> stddev() separately, and maybe I should've, but it seemed overly bulky
>> that way.
> FWIW, I prefer having each variety spelled out separately. For
On Mon, May 04, 2020 at 03:42:20PM +0200, Juan José Santamaría Flecha wrote:
> +1, seems like the way to go to me.
Attached is a patch for that and I have gone with a simple solution,
with some bonus comments about the way things happen. Here are the
patterns I tested for build.pl and the
On Tue, May 5, 2020 at 04:14:42PM +1200, Thomas Munro wrote:
> On Tue, May 5, 2020 at 3:16 PM Bruce Momjian wrote:
> > I have committed the first draft of the PG 13 release notes. You can
> > see them here:
> >
> > https://momjian.us/pgsql_docs/release-13.html
> >
> > It still needs
On Tue, May 5, 2020 at 07:43:09AM +0200, Fabien COELHO wrote:
>
> Hello Bruce,
>
> > I have committed the first draft of the PG 13 release notes. You can
> > see them here:
> >
> > https://momjian.us/pgsql_docs/release-13.html
> >
> > It still needs markup, word wrap, and indenting. The
Hi Bruce, thanks for working on this again!
+
+Allow UTF-8 escapes, e.g., E'\u', in clients that don't use UTF-8
encoding (Tom Lane)
+
I believe the term we want here is "Unicode escapes". This patch is
about the server encoding, which formerly needed to be utf-8 for
non-ascii characters. (I
Hi,
in the Postgres documentation it says: "PostgreSQLprovides the index
methods B-tree, hash, GiST, SP-GiST, GIN, and BRIN. Users can also
define their own index methods, but that is fairly complicated."
(https://www.postgresql.org/docs/12/sql-createindex.html)
Even though it's described
On Mon, May 4, 2020 at 11:16:00PM -0400, Bruce Momjian wrote:
> I have committed the first draft of the PG 13 release notes. You can
> see them here:
>
> https://momjian.us/pgsql_docs/release-13.html
>
> It still needs markup, word wrap, and indenting. The community doc
> build should
On Mon, May 4, 2020 at 11:22 PM Tom Lane wrote:
> I've now completed updating chapter 9 for the new layout,
> and the results are visible at
> https://www.postgresql.org/docs/devel/functions.html
> There is more to do --- for instance, various contrib modules
> have function/operator tables that
On Mon, May 4, 2020 at 6:59 PM Juan José Santamaría Flecha
wrote:
>
> On Thu, Apr 30, 2020 at 5:07 AM Amit Kapila wrote:
>>
>>
>> Okay, thanks. The key point to keep in mind is to avoid touching the
>> code related to prior MSVC versions as we might not have set up to
>> test those.
>
>
>
On Mon, May 4, 2020 at 8:03 PM Julien Rouhaud wrote:
>
> On Mon, May 4, 2020 at 6:10 AM Amit Kapila wrote:
> >
> > On Thu, Apr 30, 2020 at 2:19 PM Julien Rouhaud wrote:
> > >
> > > Here's the patch. I included the content of
> > > v3-fix_explain_wal_output.patch you provided before, and tried
On Mon, 4 May 2020 at 22:22, Tom Lane wrote:
>
> * is also quite sticky about inserting other sorts
> of font-changing environments inside it. As an example, it'll let
> you include but not , which seems pretty weird
> to me. This is problematic in some places where it's desirable to
> have
On Tue, May 5, 2020 at 5:16 AM Bruce Momjian wrote:
> I have committed the first draft of the PG 13 release notes. You can
> see them here:
>
> https://momjian.us/pgsql_docs/release-13.html
>
> It still needs markup, word wrap, and indenting. The community doc
> build should happen in
В Tue, 5 May 2020 15:45:48 +0900
Michael Paquier пишет:
> On Fri, May 01, 2020 at 12:48:17PM +0300, Victor Wagner wrote:
> > Maybe. But probably original author of this code was afraid of using
> > too long chain of ->{} in the string substitution.
> >
> > So, I left this style n place.
> >
>
On Fri, May 01, 2020 at 12:48:17PM +0300, Victor Wagner wrote:
> Maybe. But probably original author of this code was afraid of using
> too long chain of ->{} in the string substitution.
>
> So, I left this style n place.
>
> Nonetheless, using qq wouldn't save us from doubling backslashes.
Hi,
On Tue, May 5, 2020 at 7:47 AM Pavel Stehule wrote:
>
> Hi
>
> út 5. 5. 2020 v 5:16 odesílatel Bruce Momjian napsal:
>>
>> I have committed the first draft of the PG 13 release notes. You can
>> see them here:
>>
>> https://momjian.us/pgsql_docs/release-13.html
>>
>> It still needs
73 matches
Mail list logo
