Re: pgstat_report_activity() and parallel CREATE INDEX (was: Parallel index creation & pg_stat_activity)

2020-10-24 Thread Noah Misch
On Sat, Oct 17, 2020 at 08:39:35AM -0700, Peter Geoghegan wrote: > On Tue, Oct 13, 2020 at 7:26 PM Noah Misch wrote: > > 1. Disable parallelism for the index build under ExecuteTruncateGuts(). > >Nobody will mourn a performance loss from declining parallelism for an > >empty index, but I

Fix typo in src/backend/utils/cache/lsyscache.c

2020-10-24 Thread Hou, Zhijie
Hi I found the comment of function get_attgenerated(Oid relid, AttrNumber attnum) seems wrong. It seems the function is given the attribute number not the name. /* * get_attgenerated * - * Given the relation id and the attribute name, + * Given the relation id and

Re: Parallel Append can break run-time partition pruning

2020-10-24 Thread David Rowley
On Fri, 16 Oct 2020 at 03:01, Amit Langote wrote: > > Going over the last few emails, it seems that David held off from > committing the patch, because of the lack of confidence in its > robustness. With the patch, a sub-partitioned child's partial > Append's child paths will *always* be pulled

Re: pg_dump, ATTACH, and independently restorable child partitions

2020-10-24 Thread Justin Pryzby
On Fri, Oct 23, 2020 at 12:29:40AM -0500, Justin Pryzby wrote: > Since this commit, pg_dump CREATEs tables and then ATTACHes them: > > |commit 33a53130a89447e171a8268ae0b221bb48af6468 > |Author: Alvaro Herrera > |Date: Mon Jun 10 18:56:23 2019 -0400 > | > |Make pg_dump emit ATTACH

Re: Timing of relcache inval at parallel worker init

2020-10-24 Thread Noah Misch
On Wed, Oct 21, 2020 at 11:31:54AM -0400, Robert Haas wrote: > On Sat, Oct 17, 2020 at 7:53 AM Noah Misch wrote: > > Let's move InvalidateSystemCaches() later. > > Invalidation should follow any worker initialization step that changes the > > results of relcache validation; otherwise, we'd need

Re: Deleting older versions in unique indexes to avoid page splits

2020-10-24 Thread Peter Geoghegan
On Sat, Oct 24, 2020 at 2:55 AM Simon Riggs wrote: > The problem I highlighted is that the average UPDATE latency is x2 > what it is on current HEAD. That is not consistent with the reported > TPS, so it remains an issue and that isn't obvious. Why do you say that? I reported that the UPDATE

Re: Move catalog toast table and index declarations

2020-10-24 Thread John Naylor
On Thu, Oct 22, 2020 at 6:21 AM Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > [v1] Hi Peter, This part created a syntax error: --- a/src/include/catalog/unused_oids +++ b/src/include/catalog/unused_oids @@ -28,7 +28,7 @@ chdir $FindBin::RealBin or die "could not cd to

Re: [doc] remove reference to pg_dump pre-8.1 switch behaviour

2020-10-24 Thread Stephen Frost
Greetings, * Heikki Linnakangas (hlinn...@iki.fi) wrote: > On 23/10/2020 17:51, Tom Lane wrote: > >But anyway, this was about documentation not code. What I'm wondering > >about is when to drop things like, say, this bit in the regex docs: > > > > Two significant incompatibilities exist

Re: Deleting older versions in unique indexes to avoid page splits

2020-10-24 Thread Simon Riggs
On Fri, 23 Oct 2020 at 18:14, Peter Geoghegan wrote: > It's obvious that a page split is more expensive than the delete > operation (when it works out). The problem I highlighted is that the average UPDATE latency is x2 what it is on current HEAD. That is not consistent with the reported TPS,