Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

2020-12-12 Thread Peter Eisentraut
On 2020-12-11 21:27, Alvaro Herrera wrote: By the way-- What did you think of the idea of explictly marking the types used for bitmasks using types bits32 and friends, instead of plain int, which is harder to spot? If we want to make it clearer, why not turn the thing into a struct, as in the

Suggestion: optionally return default value instead of error on failed cast

2020-12-12 Thread Wolfgang Walther
Hi, currently a failed cast throws an error. It would be useful to have a way to get a default value instead. T-SQL has try_cast [1] Oracle has CAST(... AS .. DEFAULT ... ON CONVERSION ERROR) [2] The DEFAULT ... ON CONVERSION ERROR syntax seems like it could be implemented in PostgreSQL. Eve

Re: Asynchronous Append on postgres_fdw nodes.

2020-12-12 Thread Etsuro Fujita
On Fri, Nov 20, 2020 at 3:51 PM Kyotaro Horiguchi wrote: > At Tue, 17 Nov 2020 18:56:02 +0900, Etsuro Fujita > wrote in > > * In Robert's patch [1] (and Horiguchi-san's, which was created based > > on Robert's), ExecAppend() was modified to retrieve tuples from > > async-aware children *before*

Re: Asynchronous Append on postgres_fdw nodes.

2020-12-12 Thread Etsuro Fujita
On Fri, Nov 20, 2020 at 8:16 PM Kyotaro Horiguchi wrote: > I looked through the nodeAppend.c and postgres_fdw.c part and those > are I think the core of this patch. Thanks again for the review! > -* figure out which subplan we are currently processing > +* try to

Re: Feature Proposal: Add ssltermination parameter for SNI-based LoadBalancing

2020-12-12 Thread Lukas Meisegeier
Thanks for the provided ideas :) I use HaProxy for my load-balancing and unfortunately I can't define that I want to listen on a port for both ssl and non ssl requests. That means if I try to return a fixed response 'S' on the SSLRequest it fails with an SSL-Handshake failure cause the server expe

Re: Insert Documentation - Returning Clause and Order

2020-12-12 Thread James Coleman
On Friday, December 11, 2020, David G. Johnston wrote: > > On Fri, Dec 11, 2020 at 6:24 AM Ashutosh Bapat > wrote: >> >> On Thu, Dec 10, 2020 at 7:49 PM David G. Johnston >> wrote: >> >> > Yeah, the ongoing work on parallel inserts would seem to be an issue. We >> > should probably document t

Re: Insert Documentation - Returning Clause and Order

2020-12-12 Thread David G. Johnston
On Sat, Dec 12, 2020 at 7:02 AM James Coleman wrote: > > Certainly almost every ORM, and maybe even other forms of application > code, need to be able to associate the serial column value returned > with what it inserted. > Yet most ORM would perform single inserts at a time, not in bulk, making

Re: pglz compression performance, take two

2020-12-12 Thread Andrey Borodin
> 9 дек. 2020 г., в 12:44, Andrey Borodin написал(а): > PFA the patch with some editorialisation by me. > I saw some reports of bottlenecking in pglz WAL compression [1]. I've checked that on my machine simple test echo "wal_compression = on" >> $PGDATA/postgresql.conf pgbench -i -s 20 && pgbe

Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

2020-12-12 Thread Justin Pryzby
On Sat, Dec 12, 2020 at 09:20:35AM +0100, Peter Eisentraut wrote: > On 2020-12-11 21:27, Alvaro Herrera wrote: > > By the way-- What did you think of the idea of explictly marking the > > types used for bitmasks using types bits32 and friends, instead of plain > > int, which is harder to spot? >

Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

2020-12-12 Thread Justin Pryzby
On Sat, Dec 12, 2020 at 01:45:26PM -0600, Justin Pryzby wrote: > On Sat, Dec 12, 2020 at 09:20:35AM +0100, Peter Eisentraut wrote: > > On 2020-12-11 21:27, Alvaro Herrera wrote: > > > By the way-- What did you think of the idea of explictly marking the > > > types used for bitmasks using types bit

Re: Insert Documentation - Returning Clause and Order

2020-12-12 Thread James Coleman
On Sat, Dec 12, 2020 at 10:11 AM David G. Johnston wrote: > > On Sat, Dec 12, 2020 at 7:02 AM James Coleman wrote: >> >> >> Certainly almost every ORM, and maybe even other forms of application >> code, need to be able to associate the serial column value returned >> with what it inserted. > > >