Re: In-placre persistance change of a relation

2021-01-12 Thread Kyotaro Horiguchi
At Fri, 08 Jan 2021 17:52:21 +0900 (JST), Kyotaro Horiguchi wrote in > At Fri, 08 Jan 2021 14:47:05 +0900 (JST), Kyotaro Horiguchi > wrote in > > This version RelationChangePersistence() is changed not to choose > > in-place method for indexes other than btree. It seems to be usable > > with

Re: Track replica origin progress for Rollback Prepared

2021-01-12 Thread Ajin Cherian
On Wed, Jan 6, 2021 at 11:56 PM Amit Kapila wrote: > Now, let us see how the tests mentioned by me cover this code. In the > first test (check that 2PC gets replicated to subscriber then ROLLBACK > PREPARED), we do below on publisher and wait for it to be applied on > the subscriber. > BEGIN; >

Re: Logical Replication - behavior of ALTER PUBLICATION .. DROP TABLE and ALTER SUBSCRIPTION .. REFRESH PUBLICATION

2021-01-12 Thread japin
On Tue, 12 Jan 2021 at 14:38, Amit Kapila wrote: > On Tue, Jan 12, 2021 at 11:39 AM Bharath Rupireddy > wrote: >> >> On Tue, Jan 12, 2021 at 9:05 AM Amit Kapila wrote: >> > >> > On Mon, Jan 11, 2021 at 6:51 PM Bharath Rupireddy >> > wrote: >> > > >> > > Hi, >> > > >> > > While providing though

Re: logical replication worker accesses catalogs in error context callback

2021-01-12 Thread Bharath Rupireddy
On Tue, Jan 12, 2021 at 9:40 AM Masahiko Sawada wrote: > > On Mon, Jan 11, 2021 at 4:46 PM Bharath Rupireddy > wrote: > > > > On Mon, Jan 11, 2021 at 10:56 AM Masahiko Sawada > > wrote: > > > Agreed. Attached the updated patch. > > > > Thanks for the updated patch. Looks like the comment crosse

Re: Spurious "apparent wraparound" via SimpleLruTruncate() rounding

2021-01-12 Thread Noah Misch
On Mon, Jan 11, 2021 at 11:22:05AM +0500, Andrey Borodin wrote: > I'm marking patch as ready for committer. Thanks. > I can't tell should we backpatch insurance patch or not: it potentially fixes > unknown bugs, and potentially contains unknown bugs. I can't reason because > of such uncertainty

Re: Parallel Inserts in CREATE TABLE AS

2021-01-12 Thread Luc Vlaming
On 06-01-2021 09:32, Bharath Rupireddy wrote: On Tue, Jan 5, 2021 at 1:25 PM Luc Vlaming wrote: wrt v18-0002patch: It looks like this introduces a state machine that goes like: - starts at CTAS_PARALLEL_INS_UNDEF - possibly moves to CTAS_PARALLEL_INS_SELECT - CTAS_PARALLEL_INS_TUP_COST_CAN

Re: [Bug Fix] Logical replication on partition table is very slow and CPU is 99%

2021-01-12 Thread Amit Kapila
On Mon, Jan 11, 2021 at 6:31 PM Ashutosh Bapat wrote: > > On Mon, Jan 4, 2021 at 7:07 PM 赵锐 <875941...@qq.com> wrote: > > > > > > > This patch adds the missed decrement to resolve the problem. > > > > > > > Previous discussion is here: > > https://www.postgresql.org/message-id/flat/CA+HiwqH=Y85vR

Re: adding partitioned tables to publications

2021-01-12 Thread Amit Kapila
On Mon, Jan 11, 2021 at 5:44 PM Mark Zhao <875941...@qq.com> wrote: > > Thanks for your reply. The patch is exactly what I want. > My English name is Mark Zhao, which should be the current email name. > Pushed the fix. -- With Regards, Amit Kapila.

Re: New Table Access Methods for Multi and Single Inserts

2021-01-12 Thread Luc Vlaming
On 06-01-2021 14:06, Bharath Rupireddy wrote: On Wed, Jan 6, 2021 at 12:56 PM Luc Vlaming wrote: The main reason for me for wanting a single API is that I would like the decision of using single or multi inserts to move to inside the tableam. For e.g. a heap insert we might want to put the thre

<    1   2