Re: Windows default locale vs initdb

2021-05-15 Thread Noah Misch
On Mon, Apr 19, 2021 at 05:42:51PM +1200, Thomas Munro wrote: > Currently initdb sets up template databases with old-style Windows > locale names reported by the OS, and they seem to have caused us quite > a few problems over the years: > > db29620d "Work around Windows locale name with non-ASCII

Re: compute_query_id and pg_stat_statements

2021-05-15 Thread Alvaro Herrera
On 2021-May-15, Bruce Momjian wrote: > On Sat, May 15, 2021 at 05:32:58PM -0400, Bruce Momjian wrote: > > I also added Alvaro as an author of the compute_query_id item. > -- > > Based on the commit message, adding Alvaro was

Re: compute_query_id and pg_stat_statements

2021-05-15 Thread Bruce Momjian
On Sat, May 15, 2021 at 05:32:58PM -0400, Bruce Momjian wrote: > OK, new text is: > > > > > > Move query hash computation from pg_stat_statements to the core > server (Julien Rouhaud) > > > > The new server variable

Re: PG 14 release notes, first draft

2021-05-15 Thread Tom Lane
Alvaro Herrera writes: > I, um, again think that the item should not be primarily about JSONB, > but about our (IMO groundbreaking) extensible subscripting work. +1. Extensible subscripting is THE feature here, using it for jsonb is just an application. regards, tom

Re: [HACKERS] Re: Improve OR conditions on joined columns (common star schema problem)

2021-05-15 Thread Andy Fan
On Mon, Mar 18, 2019 at 8:09 AM Noah Misch wrote: > On Tue, Oct 02, 2018 at 10:53:40AM -0400, Tom Lane wrote: > > Noah Misch writes: > > > On Mon, Oct 01, 2018 at 09:32:10PM -0400, Tom Lane wrote: > > >> FWIW, my problem with this patch is that I remain unconvinced of the > basic > > >>

Re: PG 14 release notes, first draft

2021-05-15 Thread Justin Pryzby
On Sat, May 15, 2021 at 07:12:28PM -0400, Alvaro Herrera wrote: > On 2021-May-15, Bruce Momjian wrote: > > On Fri, May 14, 2021 at 04:01:32PM -0400, Bruce Momjian wrote: > > > On Fri, May 14, 2021 at 03:39:39PM -0400, Tom Lane wrote: > > > > Bruce Momjian writes: > > > > > On Thu, May 13, 2021 at

Re: PG 14 release notes, first draft

2021-05-15 Thread Alvaro Herrera
On 2021-May-10, Bruce Momjian wrote: > I have committed the first draft of the PG 14 release notes. You can > see the most current build of them here: > > https://momjian.us/pgsql_docs/release-14.html Thanks for putting this all together. > > > > > Autovacuum now analyzes

Re: PG 14 release notes, first draft

2021-05-15 Thread Alvaro Herrera
On 2021-May-15, Bruce Momjian wrote: > On Fri, May 14, 2021 at 04:01:32PM -0400, Bruce Momjian wrote: > > On Fri, May 14, 2021 at 03:39:39PM -0400, Tom Lane wrote: > > > Bruce Momjian writes: > > > > On Thu, May 13, 2021 at 09:01:41PM -0500, Justin Pryzby wrote: > > > >> New SQL-accessible

Re: PG 14 release notes, first draft

2021-05-15 Thread Alvaro Herrera
On 2021-May-12, Bruce Momjian wrote: > OK, updated text: > > > > > > Change the default of the password_encryption server parameter > to scram-sha-256 (Peter Eisentraut) > > > > Previously it was md5. All new passwords will be

Re: compute_query_id and pg_stat_statements

2021-05-15 Thread Alvaro Herrera
On 2021-May-15, Bruce Momjian wrote: > On Sat, May 15, 2021 at 02:21:59PM -0400, Álvaro Herrera wrote: > > I wonder why the initial line says "query hash" instead of "query > > identifier". Do we want to say "hash" everywhere? Why didn't we name > > the GUC "compute_query_hash" in that case? >

Re: prion failed with ERROR: missing chunk number 0 for toast value 14334 in pg_toast_2619

2021-05-15 Thread Tom Lane
Heikki Linnakangas writes: > After my commit c532d15ddd to split up copy.c, buildfarm animal "prion" > failed in pg_upgrade > (https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion=2020-11-23%2009%3A23%3A16): prion's continued to fail, rarely, in this same way:

Re: compute_query_id and pg_stat_statements

2021-05-15 Thread Bruce Momjian
On Sat, May 15, 2021 at 02:21:59PM -0400, Álvaro Herrera wrote: > I commented out the release notes para that is now wrong. What remains > is this: > > Move query hash computation from pg_stat_statements to the core server > (Julien Rouhaud) > > We could perhaps add something like > >

Re: PG 14 release notes, first draft

2021-05-15 Thread Bruce Momjian
On Fri, May 14, 2021 at 04:01:32PM -0400, Bruce Momjian wrote: > On Fri, May 14, 2021 at 03:39:39PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > On Thu, May 13, 2021 at 09:01:41PM -0500, Justin Pryzby wrote: > > >> New SQL-accessible functionality should be included: > > >>> 8c15a29745

Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set

2021-05-15 Thread Andrew Dunstan
On 5/14/21 10:26 PM, Michael Paquier wrote: > Hi, > (Adding Andrew in CC for the buildfarm and PostgresNode parts.) > > $subject has been around for a couple of years now, with the following > threads: > https://www.postgresql.org/message-id/20180126080026.gi17...@paquier.xyz >

Re: compute_query_id and pg_stat_statements

2021-05-15 Thread Alvaro Herrera
On 2021-May-16, Julien Rouhaud wrote: > On Sat, May 15, 2021 at 10:00 PM Bruce Momjian wrote: > > > > I am no longer the committer in charge of this feature, but I would like > > to remind the group that beta1 will be wrapped on Monday, and it is hard > > to change non-read-only GUCs after beta

Re: compute_query_id and pg_stat_statements

2021-05-15 Thread Julien Rouhaud
On Sat, May 15, 2021 at 10:00 PM Bruce Momjian wrote: > > I am no longer the committer in charge of this feature, but I would like > to remind the group that beta1 will be wrapped on Monday, and it is hard > to change non-read-only GUCs after beta since the settings are embedded > in

Re: amvalidate(): cache lookup failed for operator class 123

2021-05-15 Thread Robert Haas
On Thu, May 13, 2021 at 4:49 PM Tom Lane wrote: > The main reason I'm concerned about applying that rule to amvalidate > is that then how do you know what's actually an error case? > > As a hardly-irrelevant counterexample, we have a whole bunch of > regression tests that do something like > >

Re: Possible memory corruption (src/timezone/zic.c b/src/timezone/zic.c)

2021-05-15 Thread Ranier Vilela
Em sex., 14 de mai. de 2021 às 19:52, Tom Lane escreveu: > I wrote: > > So the question for us is whether it's worth trying to make pgreadlink > > conform to the letter of the POSIX spec in this detail. TBH, I can't > > get excited about that, at least not so far as zic's usage is concerned. >

Re: compute_query_id and pg_stat_statements

2021-05-15 Thread Bruce Momjian
On Sat, May 15, 2021 at 04:09:32PM +0800, Julien Rouhaud wrote: > > While thinking about this patch it occurred to that an useful gadget > > might be to let pg_stat_statements be loaded always, but with > > compute_query_id=false; so it's never active; except if you > > ALTER {DATABASE, USER}

Re: alter subscription drop publication fixes

2021-05-15 Thread vignesh C
On Sat, May 15, 2021 at 2:58 PM Bharath Rupireddy < bharath.rupireddyforpostg...@gmail.com> wrote: > > On Fri, May 14, 2021 at 11:02 PM vignesh C wrote: > > > > On Fri, May 14, 2021 at 8:56 PM Tom Lane wrote: > > > > > > Bharath Rupireddy writes: > > > > On Fri, May 14, 2021 at 7:58 PM vignesh

Re: [Patch] ALTER SYSTEM READ ONLY

2021-05-15 Thread Dilip Kumar
On Thu, May 13, 2021 at 2:56 PM Dilip Kumar wrote: > > Great thanks. I will review the remaining patch soon. I have reviewed v28-0003, and I have some comments on this. === @@ -126,9 +127,14 @@ XLogBeginInsert(void) Assert(mainrdata_last == (XLogRecData *) _head);

Re: Added missing tab completion for alter subscription set option

2021-05-15 Thread Bharath Rupireddy
On Sat, May 15, 2021 at 10:44 AM vignesh C wrote: > I have added a commitfest entry at [1]. > Thanks for the comments, the attached patch has the changes for the same. > > [1] - https://commitfest.postgresql.org/33/3116/ Thanks Vignesh. The v3 patch looks good to me. It applies and compiles

Re: alter subscription drop publication fixes

2021-05-15 Thread Bharath Rupireddy
On Fri, May 14, 2021 at 11:02 PM vignesh C wrote: > > On Fri, May 14, 2021 at 8:56 PM Tom Lane wrote: > > > > Bharath Rupireddy writes: > > > On Fri, May 14, 2021 at 7:58 PM vignesh C wrote: > > >> I have changed it to: > > >> ADD adds additional publications, > > >> - DROP removes

Removed extra memory allocations from create_list_bounds

2021-05-15 Thread Nitin Jadhav
Hi, While working on [1], I observed that extra memory is allocated in 'create_list_bounds' function which can be avoided. So the attached patch removes extra memory allocations done inside 'create_list_bounds' function and also removes the unused variable 'cell'. In the existing code, in

Re: compute_query_id and pg_stat_statements

2021-05-15 Thread Julien Rouhaud
On Sat, May 15, 2021 at 7:50 AM Alvaro Herrera wrote: > > I took out the new WARNING in pg_stat_statements. It's not clear to me > that that's terribly useful (it stops working as soon as you have one > query in the pg_stat_statements stash and later disable everything). If no query_id is

Re: use AV worker items infrastructure for GIN pending list's cleanup

2021-05-15 Thread Joel Jacobson
On Sat, May 15, 2021, at 08:42, Jaime Casanova wrote: > A customer here has 20+ GIN indexes in a big heavily used table and > every time one of the indexes reaches gin_pending_list_limit (because of > an insert or update) a user feels the impact. > > So, currently we have a cronjob running

Re: use AV worker items infrastructure for GIN pending list's cleanup

2021-05-15 Thread Jaime Casanova
On Sat, May 15, 2021 at 08:12:51AM +0200, Joel Jacobson wrote: > On Mon, Apr 5, 2021, at 16:47, Jaime Casanova wrote: > > On Mon, Apr 05, 2021 at 10:41:22AM -0300, Euler Taveira wrote: > > > On Mon, Apr 5, 2021, at 3:31 AM, Jaime Casanova wrote: > > > > When AV worker items where introduced 4

Re: seawasp failing, maybe in glibc allocator

2021-05-15 Thread Fabien COELHO
Hello Andres, It finally failed with a core on 8f72bba, in llvm_shutdown, AFAIKS in a free while doing malloc-related housekeeping. My guess is that there is an actual memory corruption somewhere. It is unobvious whether it is in bleeding-edge llvm or bleeding-edge postgres though. The

Re: use AV worker items infrastructure for GIN pending list's cleanup

2021-05-15 Thread Joel Jacobson
On Mon, Apr 5, 2021, at 16:47, Jaime Casanova wrote: > On Mon, Apr 05, 2021 at 10:41:22AM -0300, Euler Taveira wrote: > > On Mon, Apr 5, 2021, at 3:31 AM, Jaime Casanova wrote: > > > When AV worker items where introduced 4 years ago, i was suggested that > > > it could be used for other things