On Fri, 23 Jul 2021 at 16:50, Tom Lane wrote:
>
> OK, I've now studied this more closely, and have some additional
> nitpicks:
>
> * I felt the way you did the documentation was confusing. It seems
> better to explain the normal case first, and then describe the two
> extended cases.
OK, that lo
On Fri, Jul 23, 2021 at 5:46 PM Bossart, Nathan wrote:
> My apologies for chiming in so late to this thread, but a similar idea
> crossed my mind while working on a bug where .ready files get created
> too early [0]. Specifically, instead of maintaining a status file per
> WAL segment, I was thin
On Mon, Jul 26, 2021 at 7:55 AM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:
>
> Just wondering, do you have the code in a GitHub/Gitlab branch?
Sorry, I didn't see this earlier. No, I don't.
--
John Naylor
EDB: http://www.enterprisedb.com
On Mon, Jul 26, 2021 at 7:55 AM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:
>
> Just wondering, do you have the code in a GitHub/Gitlab branch?
>
> >+ utf8_advance(s, state, len);
> >+
> >+ /*
> >+ * If we saw an error during the loop, let the caller handle it. We
treat
> >+ * all other
On Thu, 29 Apr 2021 at 08:17, Amul Sul wrote:
> On Wed, Apr 28, 2021 at 7:56 PM Tom Lane wrote:
> > I don't think we should remove them. However, it could make sense to
> > print the "pg_temp" alias instead of the real schema name when we
> > are talking about myTempNamespace. Basically try to
On Mon, Jul 19, 2021 at 4:37 PM Ibrar Ahmed wrote:
>
>
> On Mon, Jul 12, 2021 at 4:59 PM Ibrar Ahmed wrote:
>
>>
>> Hackers,
>>
>> The Commitfest 2021-07 is now in progress. It is one of the biggest one.
>> Total number of patches of this commitfest is 342.
>>
>> Needs review: 204.
>> Waiting on
Just wondering, do you have the code in a GitHub/Gitlab branch?
>+ utf8_advance(s, state, len);
>+
>+ /*
>+ * If we saw an error during the loop, let the caller handle it. We treat
>+ * all other states as success.
>+ */
>+ if (state == ERR)
>+ return 0;
Did you mean state = utf8_advance(s, state
Attached is v20, which has a number of improvements:
1. Cleaned up and explained DFA coding.
2. Adjusted check_ascii to return bool (now called is_valid_ascii) and to
produce an optimized loop, using branch-free accumulators. That way, it
doesn't need to be rewritten for different input lengths. I
> > Yeah, thank you very much for checking that. However, this patch is
> > now developed in Andres' GitHub repository. So I'm at a loss what to
> > do for the failure..
>
> I'll post a rebased version soon.
(Sorry if you feel being hurried, which I didn't meant to.)
regards.
--
Kyotaro Horig
At Mon, 26 Jul 2021 15:01:35 +0900, Michael Paquier wrote
in
> On Sat, Jul 24, 2021 at 07:41:12PM +0900, Michael Paquier wrote:
> > I have looked at that over the last couple of days, and applied it
> > after some small fixes, including an indentation.
>
> One thing that we forgot here is the h
On Fri, Jul 23, 2021 at 8:08 PM Amit Kapila wrote:
>
> On Tue, Jul 20, 2021 at 9:24 AM Peter Smith wrote:
> >
> > Please find attached the latest patch set v98*
> >
>
> Review comments:
>
[...]
> With Regards,
> Amit Kapila.
Thanks for your review comments.
I having been worki
Bonjour Michaël,
My 0.02€:
- pgbench has its own parsing routines for int64 and double, with
an option to skip errors. That's not surprising in itself, but, for
strtodouble(), errorOK is always true, meaning that the error strings
are dead.
Indeed. However, there are "atof" calls for option
On Sat, Jul 24, 2021 at 09:56:40PM +0530, Bharath Rupireddy wrote:
> LGTM. PSA v2 patch.
FWIW, like Ashutosh upthread, my vote would be to do nothing here in
terms of behavior changes as this is just breaking a behavior for the
sake of breaking it, so there are chances that this is going to piss
s
On Wed, Jul 7, 2021 at 5:35 PM Bharath Rupireddy
wrote:
>
> Attaching v6 patch rebased onto the latest master.
I came across a recent commit 81d5995 and have used the same error
message for temporary and unlogged tables. Also added, test cases to
cover these error cases for foreign, temporary, un
On Mon, Jul 26, 2021 at 05:50:28AM +, tanghy.f...@fujitsu.com wrote:
> Thanks for your comment. Agree with your suggestion.
> Modified it in the attachment patch.
Okay, applied, but without the pwd part.
--
Michael
signature.asc
Description: PGP signature
On Fri, Jun 04, 2021 at 12:10:47PM -0400, Andrew Dunstan wrote:
> Here's a completely trivial command to turn of echoing of a couple of
> Windows commands pg_upgrade writes to cleanup scripts. This makes them
> behave more like the Unix equivalents.
Why not. Perhaps you should add a comment to me
On Sat, Jul 24, 2021 at 04:08:33PM -0700, Andres Freund wrote:
> On 2021-07-21 16:55:08 -0700, Andres Freund wrote:
>> I'm inclined to push it to 14 and master, but ...
>
> RMT: ^
If it were me, I think that I would have back-patched this change even
if found after the GA release of 14 as there i
Hi all,
While looking at the code areas of $subject, I got surprised about a
couple of things:
- pgbench has its own parsing routines for int64 and double, with
an option to skip errors. That's not surprising in itself, but, for
strtodouble(), errorOK is always true, meaning that the error string
101 - 118 of 118 matches
Mail list logo
