RE: Allow escape in application_name

2021-12-07 Thread kuroda.hay...@fujitsu.com
Dear Horiguchi-san Thank you for giving comments! I attached new patches. > > + if (appname == NULL) > > + appname = "[unknown]"; > > + if (username == NULL || *username > == '\0') > > +

回复:Re: Is it worth pushing conditions to sublink/subplan?

2021-12-07 Thread 曾文旌(义从)
Hi Hackers For my previous proposal, I developed a prototype and passed regression testing. It works similarly to subquery's qual pushdown. We know that sublink expands at the beginning of each level of query. At this stage, The query's conditions and equivalence classes are not processed. But

RE: Failed transaction statistics to measure the logical replication progress

2021-12-07 Thread osumi.takami...@fujitsu.com
On Monday, December 6, 2021 11:27 PM vignesh C wrote: > Thanks for the updated patch, few comments: Thank you for your review ! > 1) We can keep the documentation similar to mention the count includes both > table sync worker / main apply worker in case of commit_count/error_count > and

Re: Non-superuser subscription owners

2021-12-07 Thread Ronan Dunklau
Le lundi 6 décembre 2021, 16:56:56 CET Mark Dilger a écrit : > > On Dec 6, 2021, at 2:19 AM, Amit Kapila wrote: > >>> If we want to maintain the property that subscriptions can only be > >>> owned by superuser > > We don't want to maintain such a property, or at least, that's not what I > want.

Re: Fix a bug in DecodeAbort() and improve input data check on subscriber.

2021-12-07 Thread vignesh C
On Tue, Dec 7, 2021 at 6:07 AM Masahiko Sawada wrote: > > Hi all, > > While updating the patch I recently posted[1] to make pg_waldump > report replication origin ID, LSN, and timestamp, I found a bug that > replication origin timestamp is not set in ROLLBACK PREPARED case. > Commit 8bdb1332eb5

RE: Allow escape in application_name

2021-12-07 Thread kuroda.hay...@fujitsu.com
Dear Fujii-san, Thank you for reviewing! I'll post the latest version. > Currently StringInfo variable is defined in connect_pg_server() and passed to > parse_pgfdw_appname(). But there is no strong reason why the variable needs to > be defined connect_pg_server(). Right? If so how about

Re: Pre-allocating WAL files

2021-12-07 Thread Bharath Rupireddy
On Thu, Nov 11, 2021 at 12:29 AM Bossart, Nathan wrote: > > On 10/8/21, 1:55 PM, "Bossart, Nathan" wrote: > > Here is a first attempt at adding the pre-allocation logic to the > > checkpointer. I went ahead and just used CheckpointWriteDelay() for > > pre-allocating during checkpoints. I've

Re: Do we need pre-allocate WAL files during end-of-recovery checkpoint?

2021-12-07 Thread Bharath Rupireddy
On Tue, Dec 7, 2021 at 12:35 AM SATYANARAYANA NARLAPURAM wrote: > > If the segment size is 16MB it shouldn't take much time but higher segment > values this can be a problem. But again, the current segment has to be filled > 75% to precreate new one. I am not sure how much we gain. Do you have

Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

2021-12-07 Thread Dilip Kumar
On Mon, Dec 6, 2021 at 7:53 PM Ashutosh Sharma wrote: > > Thank you, Dilip for the quick response. I am okay with the changes done in > the v7 patch. > > One last point - If we try to clone a huge database, as expected CREATE > DATABASE emits a lot of WALs, causing a lot of intermediate

Re: Do we need pre-allocate WAL files during end-of-recovery checkpoint?

2021-12-07 Thread Bharath Rupireddy
On Tue, Dec 7, 2021 at 12:09 PM Noah Misch wrote: > > On Mon, Dec 06, 2021 at 06:21:40PM +0530, Bharath Rupireddy wrote: > > The function PreallocXlogFiles doesn't get called during > > end-of-recovery checkpoint in CreateCheckPoint, see [1]. The server > > becomes operational after the

Re: Do we need pre-allocate WAL files during end-of-recovery checkpoint?

2021-12-07 Thread Bharath Rupireddy
On Tue, Dec 7, 2021 at 1:02 AM Bossart, Nathan wrote: > > On 12/6/21, 4:54 AM, "Bharath Rupireddy" > wrote: > > The function PreallocXlogFiles doesn't get called during > > end-of-recovery checkpoint in CreateCheckPoint, see [1]. The server > > becomes operational after the end-of-recovery

Re: Is it correct to update db state in control file as "shutting down" during end-of-recovery checkpoint?

2021-12-07 Thread Bharath Rupireddy
On Tue, Dec 7, 2021 at 12:58 AM Bossart, Nathan wrote: > > On 12/6/21, 4:34 AM, "Bharath Rupireddy" > wrote: > > While the database is performing end-of-recovery checkpoint, the > > control file gets updated with db state as "shutting down" in > > CreateCheckPoint (see the code snippet at [1])

AW: Assorted improvements in pg_dump

2021-12-07 Thread Hans Buschmann
Hello Tom, from your mail from 25.10.2021: >0005 implements your suggestion of accounting for TOAST data while >scheduling parallel dumps. I realized while looking at that that >there's a pre-existing bug, which this'd exacerbate: on machines >with 32-bit off_t, dataLength can overflow.

<    1   2