Hello Justin,
Happy new year!
I think the 2nd half of the patches are still waiting for fixes to lstat() on
windows.
Not your problem?
Here is my review about v32:
All patches apply cleanly.
# part 01
One liner doc improvement to tell that creation time is only available on
windows.
It
Here is my review about v32:
I forgot to tell that doc generation for the cumulated changes also works.
--
Fabien.
On Fri, Dec 24, 2021 at 05:00:17PM -0500, Tom Lane wrote:
> While I've not done so here, I'm tempted to rename
> create_function_0 to create_function_c and create_function_3 to
> create_function_sql, to give them better-defined charters and
> eliminate the confusion with trailing digits for variant
Yesterday I pushed what I thought was a quick fix for bug #17350 [1].
In short, if we have an index that stores both "x" and "f(x)",
where the "x" column can be retrieved in index-only scans but "f(x)"
cannot, it's possible for the planner to generate an IOS plan that
nonetheless tries to read the
Hi,
On 2021-12-14 20:23:57 +, Bossart, Nathan wrote:
> As promised, here is v2. This patch set includes handling for all
> four tasks noted upthread. I'd still consider this a work-in-
> progress, as I've done minimal testing. At the very least, it should
> demonstrate what an auxiliary pro
Hi,
On 2021-12-03 17:03:46 +0300, Andrei Zubkov wrote:
> I've attached a new version of a patch.
This fails with an assertion failure:
https://cirrus-ci.com/task/5567540742062080?logs=cores#L55
Greetings,
Andres Freund
Hi,
On 2021-12-16 01:13:57 +, Jacob Champion wrote:
> Attached is a patch for libpq to support IP addresses in the server's
> Subject Alternative Names, which would allow admins to issue certs for
> multiple IP addresses, both IPv4 and IPv6, and mix them with
> alternative DNS hostnames. These
On 2021-12-21 22:41:18 +0100, Dag Lem wrote:
> This is my very first code contribution to PostgreSQL, and I would be
> grateful for any advice on how to proceed in order to get the patch
> accepted.
Currently the tests don't seem to pass on any platform:
https://cirrus-ci.com/task/5941863248035840
Hi,
On 2021-11-10 22:44:49 +0900, Michael Paquier wrote:
> Patch 0003 has been heavily reworked, and it would be good to have an
> extra pair of eyes on it. So I have switched the CF entry as "Needs
> Review" and added my name to the list of authors (originally this
> stuff took code portions of
I wrote:
> Unless somebody's got a better idea, I'll push forward with making
> this happen.
Here's a proposed patch for that. I ended up reverting the code
changes of 4ace45677 in favor of an alternative I'd considered
previously, which is to mark the indextlist elements as resjunk
if they're no
On Mon, Jan 3, 2022 at 10:32 AM Andres Freund wrote:
> On 2021-12-21 22:41:18 +0100, Dag Lem wrote:
> > This is my very first code contribution to PostgreSQL, and I would be
> > grateful for any advice on how to proceed in order to get the patch
> > accepted.
>
> Currently the tests don't seem to
Thomas Munro writes:
> Erm, it looks like something weird is happening somewhere in cfbot's
> pipeline, because Dag's patch says:
> +SELECT daitch_mokotoff('Straßburg');
> + daitch_mokotoff
> +-
> + 294795
> +(1 row)
... so, that test case is guaranteed to fail in non-UTF8 encodi
On Wed, Dec 29, 2021 at 7:26 PM Nitin Jadhav
wrote:
>
>
> > -* For range partitioning, we must only perform pruning with values
> > -* for either all partition keys or a prefix thereof.
> > +* For range partitioning and list partitioning, we must only
> > perform
> > +
The attached patch corrects a very minor typographical inconsistency
when date_part is invoked with invalid units on time/timetz data vs
timestamp/timestamptz/interval data.
(If stuff like this is too minor to bother with, let me know and I'll
hold off in the future... but since this was pointed o
Hi Hackers,
I noticed that pg_receivewal fails to stream when the partial file to write
is not fully initialized and fails with the error message something like
below. This requires an extra step of deleting the partial file that is not
fully initialized before starting the pg_receivewal. Attachin
On Wednesday, December 22, 2021 6:14 PM Osumi, Takamichi
wrote:
> Attached the new patch v19.
Hi,
Thanks for updating the patch.
--- a/src/include/pgstat.h
+++ b/src/include/pgstat.h
@@ -15,6 +15,7 @@
#include "portability/instr_time.h"
#include "postmaster/pgarch.h" /* for MAX_XFN_CHARS */
Hi,
While reading some code around I noticed that b04aeb0a053e7 added a MaxLockMode
but didn't update the lock methods initialization. It shouldn't make much
difference in the long run but some consistency seems better to me.
>From 1a3de43f4ed75466413ffcd884678332960c2520 Mon Sep 17 00:00:00 2001
On Mon, Jan 3, 2022 at 2:56 AM Andres Freund wrote:
>
> Hi,
>
> On 2021-12-14 20:23:57 +, Bossart, Nathan wrote:
> > As promised, here is v2. This patch set includes handling for all
> > four tasks noted upthread. I'd still consider this a work-in-
> > progress, as I've done minimal testing.
Hi,
planner hook is frequently used in monitoring and advising extensions.
The call to this hook is implemented in the way, that the
standard_planner routine must be called at least once in the hook's call
chain.
But, as I see in [1], it should allow us "... replace the planner
altogether".
On Thu, Dec 30, 2021 at 06:45:30AM +, houzj.f...@fujitsu.com wrote:
> I think forbids DROP INDEX might not completely solve this problem. Because
> user could still use other command to delete the index, for example: ALTER
> TABLE DROP COLUMN. After dropping the column, the index on it will als
On Sun, Jan 02, 2022 at 09:27:43PM -0800, SATYANARAYANA NARLAPURAM wrote:
> I noticed that pg_receivewal fails to stream when the partial file to write
> is not fully initialized and fails with the error message something like
> below. This requires an extra step of deleting the partial file that i
21 matches
Mail list logo
