Re: Add client connection check during the execution of the query

2022-01-11 Thread Thomas Munro
On Tue, Dec 14, 2021 at 11:50 PM Thomas Munro wrote: > On Tue, Dec 14, 2021 at 11:18 AM Thomas Munro wrote: > > Well, I was trying to avoid bikeshedding an API change just for a > > hypothetical problem we could solve when the time comes (say, after > > fixing the more egregious problems with App

Re: row filtering for logical replication

2022-01-11 Thread Amit Kapila
On Tue, Jan 11, 2022 at 1:32 PM tanghy.f...@fujitsu.com wrote: > > On Tuesday, January 11, 2022 10:16 AM houzj.f...@fujitsu.com > wrote: > > > > Attach the v62 patch set which address the above comments and slightly > > adjust the commit message in 0002 patch. > > > > I saw a possible problem ab

Re: logical replication empty transactions

2022-01-11 Thread Ajin Cherian
On Wed, Sep 1, 2021 at 8:57 PM Ajin Cherian wrote: > > Thanks for the comments. Addressed them in the attached patch. > > regards, > Ajin Cherian > Fujitsu Australia Minor update to rebase the patch so that it applies clean on HEAD. regards, Ajin Cherian regards, Ajin Cherian v16-0001-Skip-em

Re: In-placre persistance change of a relation

2022-01-11 Thread Jakub Wartak
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:not tested I've retested v15 of the patch with everything that came to my mi

Re: ICU for global collation

2022-01-11 Thread Peter Eisentraut
On 10.01.22 07:00, Julien Rouhaud wrote: And then I changed in varstr_cmp(): if (collid != DEFAULT_COLLATION_OID) mylocale = pg_newlocale_from_collation(collid); to just mylocale = pg_newlocale_from_collation(collid); I find that the \timing results are indist

Re: Throttling WAL inserts when the standby falls behind more than the configured replica_lag_in_bytes

2022-01-11 Thread Konstantin Knizhnik
On 11.01.2022 03:06, Bossart, Nathan wrote: I noticed this thread and thought I'd share my experiences building something similar for Multi-AZ DB clusters [0]. It's not a strict RPO mechanism, but it does throttle backends in an effort to keep the replay lag below a configured maximum. I can

Re: Disallow quorum uncommitted (with synchronous standbys) txns in logical replication subscribers

2022-01-11 Thread Kyotaro Horiguchi
At Fri, 7 Jan 2022 09:44:15 -0800, SATYANARAYANA NARLAPURAM wrote in > On Fri, Jan 7, 2022 at 12:27 AM Kyotaro Horiguchi > wrote: > > One is to serialize WAL sending (of course it is unacceptable at all) > > or aotehr is to send WAL to all standbys at once then make the > > decision after makin

Re: Skipping logical replication transactions on subscriber side

2022-01-11 Thread Masahiko Sawada
On Tue, Jan 11, 2022 at 3:12 PM Amit Kapila wrote: > > On Tue, Jan 11, 2022 at 8:52 AM Masahiko Sawada wrote: > > > > On Mon, Jan 10, 2022 at 8:50 PM Amit Kapila wrote: > > > > > > I was thinking what if we don't advance origin explicitly in this > > > case? Actually, that will be no different t

Re: a misbehavior of partition row movement (?)

2022-01-11 Thread Amit Langote
On Thu, Jan 6, 2022 at 9:36 PM Alvaro Herrera wrote: > On 2022-Jan-06, Amit Langote wrote: > > On Thu, Jan 6, 2022 at 7:27 AM Alvaro Herrera > > wrote: > > > > I have pushed it thinking that we would not backpatch any of this fix. > > > However, after running the tests and realizing that I didn'

Re: Improve error handling of HMAC computations and SCRAM

2022-01-11 Thread Sergey Shinderuk
On 11.01.2022 10:57, Michael Paquier wrote: On Tue, Jan 11, 2022 at 10:50:50AM +0300, Sergey Shinderuk wrote: + * Returns a static string providing errors about an error that happened "errors about an error" looks odd. Sure, that could be reworded. What about "providing details about an erro

RE: row filtering for logical replication

2022-01-11 Thread tanghy.f...@fujitsu.com
On Tuesday, January 11, 2022 10:16 AM houzj.f...@fujitsu.com wrote: > > Attach the v62 patch set which address the above comments and slightly > adjust the commit message in 0002 patch. > I saw a possible problem about Row-Filter tablesync SQL, which is related to partition table. If a parent

<    1   2