Re: ltree_gist indexes broken after pg_upgrade from 12 to 13

On Tue, Mar 8, 2022 at 2:05 AM Alexander Korotkov wrote: > On Sun, Mar 6, 2022 at 8:28 PM Tomas Vondra > wrote: > > On 3/6/22 08:09, Alexander Korotkov wrote: > > > Sorry for this terrible oversight by me. > > > > > > On Sat, Mar 5, 2022 at 10:13 AM Tomas Vondra > > > wrote: > > >> On 3/4/22 23:

Re: Optionally automatically disable logical replication subscriptions on error

On Wed, Mar 9, 2022 at 7:57 PM osumi.takami...@fujitsu.com wrote: > > Hi, attached v32 removed my additional code for maybe_reread_subscription. > Thanks, the patch looks good to me. I have made minor edits in the attached. I am planning to commit this early next week (Monday) unless there are an

Re: [Proposal] vacuumdb --schema only

Le 09/03/2022 à 22:10, Justin Pryzby a écrit : > On Mon, Mar 07, 2022 at 08:38:04AM +0100, Gilles Darold wrote: >>> Maybe it's clearer to write this with =ANY() / != ALL() ? >>> See 002. >> I have applied your changes and produced a new version v3 of the patch, >> thanks for the improvements. The p

RE: Skipping logical replication transactions on subscriber side

On Wednesday, March 2, 2022 12:01 AM Masahiko Sawada wrote: > I've attached an updated patch along with two patches for cfbot tests since > the > main patch (0003) depends on the other two patches. Both > 0001 and 0002 patches are the same ones I attached on another thread[2]. Hi, few comments o

Re: Adding CI to our tree

On Thu, Mar 10, 2022 at 4:33 PM Andres Freund wrote: > On 2022-03-10 15:43:16 +1300, Thomas Munro wrote: > > I'm confused. > > The "terrible IO wait" thing was before we reduced the number of CPUs and > concurrent jobs. It makes sense to me that with just two CPUs we're CPU bound, > in which case

Re: Adding CI to our tree

Hi, On 2022-03-10 15:43:16 +1300, Thomas Munro wrote: > Wow, I see the effect on Cirrus -- test_world ran in 8:55 instead of > 12:43 when I tried (terrible absolute times, but fantastic > improvement!). Hmm, on my local FreeBSD 13 box I saw 5:07 -> 5:03 > with this change. My working theory had

Re: Column Filtering in Logical Replication

On Wed, Mar 9, 2022 at 3:33 PM Amit Kapila wrote: > > On Mon, Mar 7, 2022 at 8:48 PM Tomas Vondra > wrote: > > > OK, I reworked this to do the same thing as the row filtering patch. > > > > Thanks, I'll check this. > Some assorted comments: = 1. We don't need to send a column

Re: Adding CI to our tree

On Thu, Mar 10, 2022 at 9:37 AM Justin Pryzby wrote: > On Wed, Mar 09, 2022 at 10:12:54AM -0800, Andres Freund wrote: > > On 2022-03-09 11:47:23 -0600, Justin Pryzby wrote: > > > I'm curious what you think of this patch. > > > > > > It makes check-world on freebsd over 30% faster - saving 5min. >

RE: Data is copied twice when specifying both child and parent table in publication

Hi, When reviewing some logical replication related features. I noticed another possible problem if the subscriber subscribes multiple publications which publish parent and child table. For example: pub create table t (a int, b int, c int) partition by range (a); create table t_1 partition o

Re: Add index scan progress to pg_stat_progress_vacuum

> > BTreeShmemInit(); > > SyncScanShmemInit(); > > AsyncShmemInit(); > > + vacuum_worker_init(); > > Don't we also need to add the size of the hash table to > > CalculateShmemSize()? > No, ShmemInitHash takes the min and max size o

Re: Add index scan progress to pg_stat_progress_vacuum

>I took a look at the latest patch set. >+ >+ indexes_total bigint >+ >+ >+ The number of indexes to be processed in the >+ vacuuming indexes >+ or cleaning up indexes phase. It is set to >+ 0 when vacuum is not in

Re: Add index scan progress to pg_stat_progress_vacuum

I took a look at the latest patch set. + + indexes_total bigint + + + The number of indexes to be processed in the + vacuuming indexes + or cleaning up indexes phase. It is set to + 0 when vacuum is not in any of these phases. + Could we avo

Re: support for MERGE

On Wed, Mar 9, 2022 at 9:38 AM Alvaro Herrera wrote: > I attach MERGE v14. This includes a fix from Amit Langote for the > problem I described previously, with EvalPlanQual not working correctly. > (I had failed to short-circuit the cross-partition update correctly.) > Now the test case is enabl

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 3/9/22 18:06, Nathan Bossart wrote: On Wed, Mar 09, 2022 at 06:11:19PM -0500, Chapman Flack wrote: I think the listitem In the same connection as before, issue the command: SELECT * FROM pg_backup_stop(true); would be clearer if it used named-parameter form, wait_for_archive => true.

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On Wed, Mar 09, 2022 at 06:11:19PM -0500, Chapman Flack wrote: > I think the listitem > > In the same connection as before, issue the command: > SELECT * FROM pg_backup_stop(true); > > would be clearer if it used named-parameter form, wait_for_archive => true. > > This is not strictly necess

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 03/09/22 17:21, Nathan Bossart wrote: > Great. Is there any additional feedback on this patch? Should we add an > example of using pg_basebackup in the "Standalone Hot Backups" section, or > should we leave all documentation additions like this for Chap's new > thread? I'm composing something

Re: Add index scan progress to pg_stat_progress_vacuum

>I think if it's a better approach we can do that including adding a >new infrastructure for it. +1 This is a beneficial idea, especially to other progress reporting, but I see this as a separate thread targeting the next major version.

Re: role self-revocation

"David G. Johnston" writes: > So CREATE ROLE will assign ownership of AND membership in the newly created > role to the session_user I would NOT have it automatically assign membership in the new role, even though the SQL spec says so. We've not done that historically and it doesn't seem desirab

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On Wed, Mar 09, 2022 at 02:32:24PM -0500, Chapman Flack wrote: > On 03/09/22 12:19, Stephen Frost wrote: >> Let's avoid hijacking this thread, which is about this >> patch, for an independent debate about what our documentation should or >> shouldn't include. > > Agreed. New thread here: > > http

Re: parse/analyze API refactoring

On Wed, Mar 09, 2022 at 11:35:32AM +0100, Peter Eisentraut wrote: > I have committed my original patches. I'll leave the above-mentioned topic > as ideas for the future. Sounds good. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com

Re: role self-revocation

On Wed, Mar 9, 2022 at 2:31 PM Tom Lane wrote: > Robert Haas writes: > > Well, the problem is that as far as I can see, the admin option is an > > optional feature of membership. You can grant someone membership > > without admin option, or with admin option, but you can't grant them > > the adm

Re: Commitfest 2022-03 One Week in. 3 Commits 213 Patches Remaining

On Wed, 9 Mar 2022 at 16:46, Greg Stark wrote: > Many of them seem to mostly have gotten > feedback from committers already and the type of feedback that leads > me to think it's ready for commit. Er. I meant *not* the type of feedback that leads me to think it's ready for commit. I mostly see pa

Re: Commitfest 2022-03 One Week in. 3 Commits 213 Patches Remaining

On Wed, 9 Mar 2022 at 15:44, David Steele wrote: > > On 3/9/22 13:38, Greg Stark wrote: > Should I do a round-robin style assignment for any of these? > > I don't think this is a good idea. Committers pick the patches they are > going to commit. > > What prefer to do is bump any committers that ha

Re: role self-revocation

Robert Haas writes: > Well, the problem is that as far as I can see, the admin option is an > optional feature of membership. You can grant someone membership > without admin option, or with admin option, but you can't grant them > the admin option without membership, just like you can't purchase

Re: role self-revocation

I wrote: > This seems like a reasonable answer to me too: the creating role has admin > option implicitly, and can then choose to grant that to other roles. > Obviously some work needs to be done to make that happen (and we should > see whether the SQL spec has some different idea). Ah, here we go

Re: role self-revocation

Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Wed, Mar 9, 2022 at 4:01 PM Tom Lane wrote: > > > In my opinion, the right to > > > administer a role - regardless of whether or not it is a login role - > > > most naturally vests in the role that created it, or something in that > > >

Re: role self-revocation

Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Robert Haas writes: > > On Mar 7, 2022, at 12:16 PM, Tom Lane wrote: > > tgl> Having said that, one thing that I find fishy is that it's not clear > > tgl> where the admin privilege for a role originates. After "CREATE ROLE > > tgl> alice", al

Re: role self-revocation

On Wed, Mar 9, 2022 at 4:01 PM Tom Lane wrote: > > In my opinion, the right to > > administer a role - regardless of whether or not it is a login role - > > most naturally vests in the role that created it, or something in that > > direction at least, if not that exact thing. > > This seems like a

Re: [Proposal] vacuumdb --schema only

On Mon, Mar 07, 2022 at 08:38:04AM +0100, Gilles Darold wrote: > > Maybe it's clearer to write this with =ANY() / != ALL() ? > > See 002. > > I have applied your changes and produced a new version v3 of the patch, > thanks for the improvements. The patch have been added to commitfest > interface,

Re: role self-revocation

Robert Haas writes: > On Mar 7, 2022, at 12:16 PM, Tom Lane wrote: > tgl> Having said that, one thing that I find fishy is that it's not clear > tgl> where the admin privilege for a role originates. After "CREATE ROLE > tgl> alice", alice has no members, therefore none that have admin privilege,

Re: role self-revocation

On Mon, Mar 7, 2022 at 11:14 PM Mark Dilger wrote: > > On Mar 7, 2022, at 12:16 PM, Tom Lane wrote: > > What would be > > lost if we drop it? > > I looked into this a bit. Removing that bit of code, the only regression > test changes for "check-world" are the expected ones, with nothing else >

Re: Commitfest 2022-03 One Week in. 3 Commits 213 Patches Remaining

On 3/9/22 13:38, Greg Stark wrote: Is there anything I can do to get committers assigned to these patches? Should I do a round-robin style assignment for any of these? I don't think this is a good idea. Committers pick the patches they are going to commit. What prefer to do is bump any comm

Re: Document what is essential and undocumented in pg_basebackup

On 3/9/22 13:46, Stephen Frost wrote: I don't think it is as reasonable to say, effectively, that you learn what the irreducibly essential steps of an online base backup are by reading the source of pg_basebackup, and then intuiting which of the details you find there are the essential ones and

Re: Adding CI to our tree

On Wed, Mar 09, 2022 at 10:12:54AM -0800, Andres Freund wrote: > On 2022-03-09 11:47:23 -0600, Justin Pryzby wrote: > > I'm curious what you think of this patch. > > > > It makes check-world on freebsd over 30% faster - saving 5min. > > That's nice! While -Og makes interactive debugging noticeabl

Re: [Proposal] vacuumdb --schema only

Hi, New version v4 of the patch to fix a typo in a comment. -- Gilles Darold diff --git a/doc/src/sgml/ref/vacuumdb.sgml b/doc/src/sgml/ref/vacuumdb.sgml index 956c0f01cb..378328afb3 100644 --- a/doc/src/sgml/ref/vacuumdb.sgml +++ b/doc/src/sgml/ref/vacuumdb.sgml @@ -39,6 +39,40 @@ PostgreSQL do

Re: Document what is essential and undocumented in pg_basebackup

Greetings, * Chapman Flack (c...@anastigmatix.net) wrote: > On 03/09/22 12:19, Stephen Frost wrote: > > Let's avoid hijacking [thread about other patch] [1] > > for an independent debate about what our documentation should or > > shouldn't include. > > Agreed. New thread here. Thanks. > Stephen

Re: Commitfest 2022-03 One Week in. 3 Commits 213 Patches Remaining

So it's 8 days into the commitfest. So far 3 patches have been committed: * parse/analyze API refactoring by Peter Eisentraut * FUNCAPI tuplestore helper function by Melanie Plagemen committed by Michael Paquier * Typo in pgbench messages by Kawamoto Masay committed by Tatsuo Ishii (There was als

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 03/09/22 12:19, Stephen Frost wrote: > Let's avoid hijacking this thread, which is about this > patch, for an independent debate about what our documentation should or > shouldn't include. Agreed. New thread here: https://www.postgresql.org/message-id/6228FFE4.3050309%40anastigmatix.net Regar

Document what is essential and undocumented in pg_basebackup

On 03/09/22 12:19, Stephen Frost wrote: > Let's avoid hijacking [thread about other patch] [1] > for an independent debate about what our documentation should or > shouldn't include. Agreed. New thread here. Stephen wrote: > Documenting everything that pg_basebackup does to make sure that the > b

Re: [RFC] building postgres with meson

Hi, On 2021-10-22 11:55:05 -0400, John Naylor wrote: > On Thu, Oct 21, 2021 at 5:48 PM Andres Freund wrote: > > > However, update-unicode is a bit harder. Partially not directly because > of > > meson, but because update-unicode as-is afaict doesn't support VPATH > builds, > > and meson enforce

Re: Adding CI to our tree

Hi, On 2022-03-09 11:47:23 -0600, Justin Pryzby wrote: > I'm curious what you think of this patch. > > It makes check-world on freebsd over 30% faster - saving 5min. That's nice! While -Og makes interactive debugging noticeably harder IME, it's not likely to be a large enough difference just for

Re: Adding CI to our tree

I'm curious what you think of this patch. It makes check-world on freebsd over 30% faster - saving 5min. Apparently gcc -Og was added in gcc 4.8 (c. 2013). On Wed, Mar 02, 2022 at 02:50:58PM -0600, Justin Pryzby wrote: > From d180953d273c221a30c5e9ad8d74b1b4dfc60bd1 Mon Sep 17 00:00:00 2001 > Fr

Re: support for MERGE

On 2022-Mar-07, Zhihong Yu wrote: > For v13-0003-MERGE-SQL-Command-following-SQL-2016.patch : > > +* Reset per-tuple memory context to free any expression evaluation > +* storage allocated in the previous cycle. > +*/ > + ResetExprContext(econtext); > > Why is the memory cleanup do

Re: Proposal: Support custom authentication methods using hooks

On Tue, Mar 8, 2022 at 9:28 PM Stephen Frost wrote: > > Greetings, > > * Jeff Davis (pg...@j-davis.com) wrote: > > On Wed, 2022-03-02 at 10:54 -0500, Stephen Frost wrote: > > > It's our decision what we want to support and maintain in the code > > > base > > > and what we don't. > > > > That might

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

Greetings, * Chapman Flack (c...@anastigmatix.net) wrote: > On 03/09/22 11:22, Magnus Hagander wrote: > >> It's more than just too confusing, it's actively bad because people will > >> actually use it and then end up with backups that don't work. > > > > +1. > > > > Or even worse, backups that s

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On 03/09/22 11:22, Magnus Hagander wrote: >> It's more than just too confusing, it's actively bad because people will >> actually use it and then end up with backups that don't work. > > +1. > > Or even worse, backups that sometimes work, but not reliably and not > every time. > ... > Pretending

Re: New developer papercut - Makefile references INSTALL

Magnus Hagander writes: > On Mon, Mar 7, 2022 at 11:51 PM Tom Lane wrote: >> Doesn't really help people working from git, I think, because the >> master branch is always going to claim to be "devel" even when you >> rewind it to some old state. Maybe we can assume people doing >> such a thing ha

Re: [RFC] building postgres with meson

Hi, One thing that's pretty cool with ninja based builds is that it contains a dependency log of "discovered" dependencies as well as information about dependencies "encoded" in the build specification. LLVM contains a script that uses that dependency information to see whether the build specifica

Re: New developer papercut - Makefile references INSTALL

On Mon, Mar 7, 2022 at 11:51 PM Tom Lane wrote: > > Magnus Hagander writes: > > But taking a step back, who is the actual audience for this? Do we > > *need* a link pointing directly there, or is it enough to just point > > to "use the docs on the web"? We can't link to the incorrect version, > >

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

Rebased over 9e9858389 (Michael may want to look at the tuplestore part?). Fixing a comment typo. I also changed pg_ls_dir_recurse() to handle concurrent removal of a dir, which I noticed caused an infrequent failure on CI. However I'm not including that here, since the 2nd half of the patch set

Re: [RFC] building postgres with meson -v7

Hi, On 2022-03-09 13:37:23 +0100, Peter Eisentraut wrote: > I looked at this today mainly to consider whether some of the prereq > work is ready for adoption now. Thanks! > A lot of the work has to do with > making various scripts write the output to other directories. I > suspect this has som

Re: PROXY protocol support

On Wed, Mar 9, 2022 at 5:23 PM Peter Eisentraut wrote: > > A general question on this feature: AFAICT, you can only send the proxy > header once at the beginning of the connection. So this wouldn't be of > use for PostgreSQL-protocol connection poolers (pgbouncer, pgpool), > where the same server

Re: PROXY protocol support

A general question on this feature: AFAICT, you can only send the proxy header once at the beginning of the connection. So this wouldn't be of use for PostgreSQL-protocol connection poolers (pgbouncer, pgpool), where the same server connection can be used for clients from different source addr

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

On Wed, Mar 9, 2022 at 4:42 PM Stephen Frost wrote: > > Greetings, > > * Chapman Flack (c...@anastigmatix.net) wrote: > > On 03/08/22 17:12, Nathan Bossart wrote: > > > I spent some time trying to come up with a workable script to replace the > > > existing one. I think the main problem is that y

Re: Printing backtrace of postgres processes

rebased to appease cfbot. + couple of little fixes as 0002. -- Justin >From 4be93f2bab460682a0f5af9e1e3f4970709b3517 Mon Sep 17 00:00:00 2001 From: Vigneshwaran C Date: Tue, 25 Jan 2022 08:21:22 +0530 Subject: [PATCH 1/2] Add function to log the backtrace of the specified postgres process. ci

Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

Greetings, * Chapman Flack (c...@anastigmatix.net) wrote: > On 03/08/22 17:12, Nathan Bossart wrote: > > I spent some time trying to come up with a workable script to replace the > > existing one. I think the main problem is that you need to write out both > > the backup label file and the tables

Re: [PATCH] Add reloption for views to enable RLS

On Tue, 2022-03-08 at 18:17 +0100, Christoph Heiss wrote: > Since there don't seem to be any more objections to "security_invoker" I > attached v10 renaming it again. > > I've tried to better clarify the whole invoker vs. definer thing in the > CREATE VIEW documentation by explicitly mentioning

RE: Optionally automatically disable logical replication subscriptions on error

On Wednesday, March 9, 2022 8:22 PM Amit Kapila wrote: > On Wed, Mar 9, 2022 at 2:21 PM Masahiko Sawada > wrote: > > > > On Wed, Mar 9, 2022 at 4:33 PM osumi.takami...@fujitsu.com > > wrote: > > > > > > On Tuesday, March 8, 2022 10:23 PM Amit Kapila > wrote: > > > > On Tue, Mar 8, 2022 at 1:37

Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs)

On Tue, Mar 08, 2022 at 08:57:23PM +0530, Nitin Jadhav wrote: > > I just wanted to avoid extra calculations just to show the progress in > the view. Since it's a good metric, I have added an additional field > named 'next_flags' to the view which holds all possible flag values of > the next checkp

Re: Changing "Hot Standby" to "hot standby"

>>Hmm.  Outside the title that had better use upper-case characters for >>the first letter of each word, I can see references to the pattern you >>are trying to eliminate in amcheck.sgml (1), config.sgml (3), >>protocol.sgml (3) and mvcc.sgml (1).  Shouldn't you refresh these as >>well if the point

Re: Column Filtering in Logical Replication

On 3/9/22 11:03, Amit Kapila wrote: > ... >> Hmm, yeah. That seems like a genuine problem - it should not depend on >> the order of publications in the subscription, I guess. >> >> But is it an issue in the patch? Isn't that a pre-existing issue? AFAICS >> the problem is that we initialize publish_

Re: Report checkpoint progress with pg_stat_progress_checkpoint (was: Report checkpoint progress in server logs)

On Tue, Mar 8, 2022 at 8:31 PM Nitin Jadhav wrote: > > > > [local]:5432 ashu@postgres=# select * from pg_stat_progress_checkpoint; > > > -[ RECORD 1 ]-+- > > > pid | 22043 > > > type | checkpoint > > > kind | immediate

Re: logical decoding and replication of sequences

On 3/9/22 12:41, Amit Kapila wrote: > On Wed, Mar 9, 2022 at 4:14 AM Tomas Vondra > wrote: >> >> On 3/7/22 22:11, Tomas Vondra wrote: >>> >>> I've pushed this simple fix. Not sure it'll fix the assert failures on >>> skink/locust, though. Given the lack of information it'll be difficult >>> to ver

Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

On Wed, Mar 9, 2022 at 6:07 AM Dilip Kumar wrote: > Yeah you are correct about the local map, but I am not sure whether we > can rely on not updating the shared map in the startup process. > Because how can we guarantee that now or in future the startup process > can never look into the map? I ag

Re: wal_compression=zstd

On Fri, Mar 04, 2022 at 05:44:06AM -0600, Justin Pryzby wrote: > On Fri, Mar 04, 2022 at 04:19:32PM +0900, Michael Paquier wrote: > > On Tue, Feb 22, 2022 at 05:19:48PM -0600, Justin Pryzby wrote: > > > > > As writen, this patch uses zstd level=1 (whereas the ZSTD's default > > > compress > > > l

Re: role self-revocation

On Wed, Mar 9, 2022 at 7:55 AM Peter Eisentraut wrote: > Do we have subtractive permissions today? Not in the GRANT/REVOKE sense, I think, but you can put a user in a group and then mention that group in pg_hba.conf. And that line might be "reject" or whatever. -- Robert Haas EDB: http://www.en

Re: Synchronizing slots from primary to standby

Hi, I have spent little time trying to understand the concern raised by Andres and while doing so I could think of a couple of issues which I would like to share here. Although I'm not quite sure how inline these are with the problems seen by Andres. 1) Firstly, what if we come across a situation

Re: role self-revocation

On 07.03.22 19:18, Robert Haas wrote: That all said, permissions SHOULD BE strictly additive. If boss doesn't want to be a member of pg_read_all_files allowing them to revoke themself from that role seems like it should be acceptable. If there is fear in allowing someone to revoke (not add)

Re: Time to drop plpython2?

On 3/8/22 15:02, Andres Freund wrote: > Hi, > > On 2022-03-08 10:42:31 -0800, Andres Freund wrote: >>> crake also failed. Looks like plpy_plpymodule.h needs to include >>> plpython.h. A >>> pre-existing issue that just didn't happen to cause problems... >> Fixed that. > Hm. Now crake failed in X

Re: [RFC] building postgres with meson -v6

On 08.03.22 03:56, Andres Freund wrote: Attached is v6 of the meson patchset. There are a lots of changes since the last version posted. These include: - python2 removal is now committed, so not needed in here anymore - CI changed to be based on the CI now merged into postgres - CI also tests sus

Re: logical decoding and replication of sequences

On Wed, Mar 9, 2022 at 4:14 AM Tomas Vondra wrote: > > On 3/7/22 22:11, Tomas Vondra wrote: > > > > I've pushed this simple fix. Not sure it'll fix the assert failures on > > skink/locust, though. Given the lack of information it'll be difficult > > to verify. So let's wait a bit. > > > > I've don

Re: Reducing power consumption on idle servers

On Sat, 26 Feb 2022 at 17:44, Tom Lane wrote: > > Magnus Hagander writes: > >> Deprecating explicit file-based promotion is possible and simple, so > >> that is the approach in the latest version of the patch. > > > Is there any actual use-case for this other than backwards > > compatibility? > >

Re: Changing "Hot Standby" to "hot standby"

Hi Michael, >On Wed, Mar 09, 2022 at 07:45:32AM +, Daniel Westermann (DWE) wrote: >> Thanks for having a look. Done that way. >Hmm.  Outside the title that had better use upper-case characters for >the first letter of each word, I can see references to the pattern you >are trying to eliminate

Re: Optionally automatically disable logical replication subscriptions on error

On Wed, Mar 9, 2022 at 2:21 PM Masahiko Sawada wrote: > > On Wed, Mar 9, 2022 at 4:33 PM osumi.takami...@fujitsu.com > wrote: > > > > On Tuesday, March 8, 2022 10:23 PM Amit Kapila > > wrote: > > > On Tue, Mar 8, 2022 at 1:37 PM osumi.takami...@fujitsu.com > > > wrote: > > > > > > > > > > > 2.

Re: [PATCH] Double declaration in pg_upgrade.h

On 09.03.22 11:29, Pavel Borisov wrote: I've noticed that check_ok() in pg_upgrade.h has been declared two times. Here's a one-line patch correcting this. Fixed, thanks.

Re: Add pg_freespacemap extension sql test

2022년 3월 9일 (수) 오전 1:19, Tom Lane 님이 작성: > Dong Wook Lee writes: > > [ 0001_add_test_pg_fsm.patch ] > > I think having some coverage here would be great, but I'm concerned that > this patch doesn't look very portable. Aren't the numbers liable to > change on 32-bit machines, in particular? > >

Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints

On Wed, Mar 9, 2022 at 3:12 AM Robert Haas wrote: > Thanks for reviewing and valuable feedback. > Reviewing 0001, the boundaries of the critical section move slightly, > but only over a memcpy, which can't fail, so that seems fine. But this > comment looks ominous: > > * Note: we're cheating

Re: parse/analyze API refactoring

On 28.02.22 19:51, Nathan Bossart wrote: On Mon, Feb 28, 2022 at 07:46:40AM +0100, Peter Eisentraut wrote: You set this commit fest entry to Waiting on Author, but there were no reviews posted and the patch still applies and builds AFAICT, so I don't know what you meant by that. Apologies for

[PATCH] Double declaration in pg_upgrade.h

Hi, hackers! I've noticed that check_ok() in pg_upgrade.h has been declared two times. Here's a one-line patch correcting this. -- Best regards, Pavel Borisov Postgres Professional: http://postgrespro.com v1-0001-Fix-double-declaration-for-check_ok-in-pg_upgrade.pa

RE: Column Filtering in Logical Replication

On Wednesday, March 9, 2022 6:04 PM Amit Kapila > On Mon, Mar 7, 2022 at 8:48 PM Tomas Vondra > wrote: > > > > On 3/4/22 11:42, Amit Kapila wrote: > > > > > * > > > Fetching column filter info in tablesync.c is quite expensive. It > > > seems to be using four round-trips to get the complete info

Re: cpluspluscheck complains about use of register

It seems we should just remove the use of register? I have a vague idea that it was once important to say "register" if you are going to use the variable in an asm snippet that requires it to be in a register. That might be wrong, or it might be obsolete even if once true. We could try taki

Re: RFC: Logging plan of the running query

On 2022-02-08 01:13, Fujii Masao wrote: AbortSubTransaction() should reset ActiveQueryDesc to save_ActiveQueryDesc that ExecutorRun() set, instead of NULL? Otherwise ActiveQueryDesc of top-level statement will be unavailable after subtransaction is aborted in the nested statements. I once agree

Re: Column Filtering in Logical Replication

On Mon, Mar 7, 2022 at 8:48 PM Tomas Vondra wrote: > > On 3/4/22 11:42, Amit Kapila wrote: > > On Wed, Mar 2, 2022 at 5:43 PM Tomas Vondra > > wrote: > >> > >> Attached is an updated patch, addressing most of the issues reported so > >> far. There are various minor tweaks, but the main changes ar

Re: Time to drop plpython2?

On 08.03.22 20:03, Andres Freund wrote: Hi, On 2022-03-08 13:49:15 -0500, Tom Lane wrote: Andres Freund writes: A bit depressing to have a 500 line alternative output file for a one line diff :(. Yeah. How badly do we need that particular test case? A bit hard to tell. The test was intro

Re: Column Filtering in Logical Replication

On 07.03.22 16:18, Tomas Vondra wrote: AFAICS these issues should be resolved by the adoption of the row-filter approach (i.e. it should fail the same way as for row filter). The first two patches (additional testing for row filtering feature) look okay to me. Attached is a fixup patch for

Re: Optionally automatically disable logical replication subscriptions on error

On Wed, Mar 9, 2022 at 4:33 PM osumi.takami...@fujitsu.com wrote: > > On Tuesday, March 8, 2022 10:23 PM Amit Kapila > wrote: > > On Tue, Mar 8, 2022 at 1:37 PM osumi.takami...@fujitsu.com > > wrote: > > > > > > > 2. Is there a reason the patch doesn't allow workers to restart via > > maybe_rer

Re: Changing "Hot Standby" to "hot standby"

On Wed, Mar 09, 2022 at 07:45:32AM +, Daniel Westermann (DWE) wrote: > Thanks for having a look. Done that way. Hmm. Outside the title that had better use upper-case characters for the first letter of each word, I can see references to the pattern you are trying to eliminate in amcheck.sgml (

Re: wal_compression=zstd

On Sat, Mar 05, 2022 at 07:26:39PM +0900, Michael Paquier wrote: > Repeatability and randomness of data counts, we could have for example > one case with a set of 5~7 int attributes, a second with text values > that include random data, up to 10~12 bytes each to count on the tuple > header to be ab