Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman

2022-04-16 Thread Michael Paquier
On Sun, Apr 17, 2022 at 08:56:33AM +1200, Thomas Munro wrote: > Under valgrind I got "Undefined subroutine &main::usleep called at > t/002_archiving.pl line 103" so I added "use Time::HiRes qw(usleep);", > and now I get past the first 4 tests with your patch, but then > promotion times out, not sur

Re: convert libpq uri-regress tests to tap test

2022-04-16 Thread Andrew Dunstan
On 2022-04-16 Sa 10:44, Justin Pryzby wrote: > On Sat, Feb 26, 2022 at 05:46:26PM -0800, Andres Freund wrote: >> Pushed. Attached is the remainder, 0003, the move of libpq_pipeline to >> src/interfaces/libpq that I'm not planning to push for now. > I saw that Andrew just pushed something to star

Re: Crash in new pgstats code

2022-04-16 Thread Andres Freund
Hi, On 2022-04-16 12:13:09 -0700, Andres Freund wrote: > On 2022-04-15 13:28:35 -0400, Tom Lane wrote: > > mylodon just showed a new-to-me failure mode [1]: > > Thanks. Found the bug (pgstat_drop_all_entries() passed the wrong lock > level), with the obvious fix. > > This failed to fail in other

Re: Crash in new pgstats code

2022-04-16 Thread Andres Freund
Hi On 2022-04-16 12:13:09 -0700, Andres Freund wrote: > What confuses me so far is what already had generated stats before > reaching pgstat_reset_after_failure() (so that the bug could even be hit > in t/025_stuck_on_old_timeline.pl). I see part of a problem - in archiver stats. Even in 14 (and

Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman

2022-04-16 Thread Thomas Munro
On Tue, Apr 12, 2022 at 3:49 PM Michael Paquier wrote: > All that stuff leads me to the attached. Thoughts? Under valgrind I got "Undefined subroutine &main::usleep called at t/002_archiving.pl line 103" so I added "use Time::HiRes qw(usleep);", and now I get past the first 4 tests with your pat

Re: GSoC: pgmoneta: Write-Ahead Log (WAL) infrastructure (2022)

2022-04-16 Thread Jesper Pedersen
Hi, On 4/16/22 13:06, dl x wrote: My name is Donglin Xie, a MSc. student at Zhejiang University, in China. I am interested in the project *pgmoneta: Write-Ahead Log (WAL) infrastructure.* The proposal is attached to this email. Looking forward to the suggestions! Thanks for your proposal to

Re: Crash in new pgstats code

2022-04-16 Thread Andres Freund
Hi On 2022-04-15 13:28:35 -0400, Tom Lane wrote: > mylodon just showed a new-to-me failure mode [1]: Thanks. Found the bug (pgstat_drop_all_entries() passed the wrong lock level), with the obvious fix. This failed to fail in other tests because they all end up resetting only when there's no stat

Re: TRAP: FailedAssertion("HaveRegisteredOrActiveSnapshot()", File: "toast_internals.c", Line: 670, PID: 19403)

2022-04-16 Thread Tom Lane
Robert Haas writes: > Well ... I agree that brittle is bad, but it's not clear to me which > way is actually less brittle. As for performant, I think you might be > misjudging the situation. My original design for removing SnapshotNow > didn't even have the catalog snapshot - it just took a new sn

Re: TRAP: FailedAssertion("tabstat->trans == trans", File: "pgstat_relation.c", Line: 508

2022-04-16 Thread Andres Freund
Hi, On 2022-04-16 09:37:55 +0200, Erik Rijkers wrote: > I get this crash running the attached test program. On my slow-disked and > old desktop it occurs once in 20 or so runs (it is yet another installment > of an old test that runs pgbench with logical replication). > > 15devel compiled from d36

Stabilizing the test_decoding checks, take N

2022-04-16 Thread Tom Lane
My pet dinosaur prairiedog just failed in the contrib/test_decoding tests [1]: diff -U3 /Users/buildfarm/bf-data/HEAD/pgsql.build/contrib/test_decoding/expected/stream.out /Users/buildfarm/bf-data/HEAD/pgsql.build/contrib/test_decoding/results/stream.out --- /Users/buildfarm/bf-data/HEAD/pgsql

Re: convert libpq uri-regress tests to tap test

2022-04-16 Thread Justin Pryzby
On Sat, Feb 26, 2022 at 05:46:26PM -0800, Andres Freund wrote: > Pushed. Attached is the remainder, 0003, the move of libpq_pipeline to > src/interfaces/libpq that I'm not planning to push for now. I saw that Andrew just pushed something to start building this under MSVC. In case it's of any int

Re: Handle infinite recursion in logical replication setup

2022-04-16 Thread vignesh C
On Thu, Apr 14, 2022 at 1:53 PM Peter Smith wrote: > > Here are my review comments for v8-0001. > > == > > 1. Commit message > > CREATE SUBSCRIPTION sub1 CONNECTION 'dbname =postgres port=' > PUBLICATION pub1 with (local_only = true); > > The spaces in the CONNECTION string are a bit stran

Re: GSoC: GUI representation of monitoring System Activity with the system_stats Extension in pgAdmin 4

2022-04-16 Thread Kunal Garg
Hey Ilaria, Thankyou so much for the review, your suggestion is quite useful. I think when first function of the system_stat gets connected with pgadmin4, then the process will be pretty straightforward, the longer duration of testing will iterate over enhancing the GUI. But to be on the safer sid

Re: TRAP: FailedAssertion("tabstat->trans == trans", File: "pgstat_relation.c", Line: 508

2022-04-16 Thread Michael Paquier
On Sat, Apr 16, 2022 at 09:37:55AM +0200, Erik Rijkers wrote: > I get this crash running the attached test program. On my slow-disked and > old desktop it occurs once in 20 or so runs (it is yet another installment > of an old test that runs pgbench with logical replication). > > 15devel compiled

Re: CLUSTER on partitioned index

2022-04-16 Thread Michael Paquier
On Thu, Apr 14, 2022 at 10:37:06PM +0200, Alvaro Herrera wrote: > Thanks for the patch -- I have pushed it now, with some wording changes > and renaming the role to regress_* to avoid buildfarm's ire. Cool, thanks. > Michaƫl in addition proposes an isolation test. I'm not sure; is it > worth the

TRAP: FailedAssertion("tabstat->trans == trans", File: "pgstat_relation.c", Line: 508

2022-04-16 Thread Erik Rijkers
Hi, I get this crash running the attached test program. On my slow-disked and old desktop it occurs once in 20 or so runs (it is yet another installment of an old test that runs pgbench with logical replication). 15devel compiled from d3609dd25. (The bash deletes stuff, and without my enviro