Re: better page-level checksums

2022-06-09 Thread Fabien COELHO
Hello Robert, I think for this purpose we should limit ourselves to algorithms whose output size is, at minimum, 64 bits, and ideally, a multiple of 64 bits. I'm sure there are plenty of options other than the ones that btrfs uses; I mentioned them only as a way of jump-starting the discussion.

Re: Using PQexecQuery in pipeline mode produces unexpected Close messages

2022-06-09 Thread Kyotaro Horiguchi
At Fri, 10 Jun 2022 15:25:44 +0900 (JST), Kyotaro Horiguchi wrote in > The current implement of PQsendQueryInternal looks like the result of > a misunderstanding of the doc. In the regression tests, that path is > excercised only for an error case, where no CloseComplete comes. > > The attache

Re: Support logical replication of DDLs

2022-06-09 Thread Amit Kapila
On Thu, Jun 9, 2022 at 5:14 PM houzj.f...@fujitsu.com wrote: > > Hi, > > I did some research for one potential problem[1] mentioned earlier which is > related > to the function execution when replicating DDL. > > [1]> 4. Statements that have nondeterministic side effects (e.g., as caused > > by t

Re: Using PQexecQuery in pipeline mode produces unexpected Close messages

2022-06-09 Thread Kyotaro Horiguchi
(Moved to -hackers) At Wed, 8 Jun 2022 17:08:47 +0200, Alvaro Herrera wrote in > What that Close message is doing is closing the unnamed portal, which > is otherwise closed implicitly when the next one is opened. That's how > single-query mode works: if you run a single portal, it'll be kept o

Re: Collation version tracking for macOS

2022-06-09 Thread Thomas Munro
On Fri, Jun 10, 2022 at 12:48 PM Tobias Bussmann wrote: > Perhaps I can shed some light on this matter: Hi Tobias, Oh, thanks for your answers. Definitely a few bits of interesting archeology I was not aware of. > Apple's libc collations have always been a bit special in that concern, even >

Re: Allow foreign keys to reference a superset of unique columns

2022-06-09 Thread David Rowley
On Fri, 10 Jun 2022 at 16:14, Peter Eisentraut wrote: > > On 10.06.22 05:47, David Rowley wrote: > >> I think this should be referring to constraint name, not an index name. > > Can you explain why you think that? > > If you wanted to specify this feature in the SQL standard (I'm not > proposing t

Re: Handle infinite recursion in logical replication setup

2022-06-09 Thread Peter Smith
Below are some review comments for the patch v18-0003 1. Commit message This patch does a couple of things: change 1) Checks and throws an error if the publication tables were also subscribing data in the publisher from other publishers when copy_data parameter is specified as 'ON' and origin par

Re: Collation version tracking for macOS

2022-06-09 Thread Thomas Munro
On Fri, Jun 10, 2022 at 1:48 PM Peter Geoghegan wrote: > On Thu, Jun 9, 2022 at 6:23 PM Thomas Munro wrote: > > Well I can report that the system from ec483147 was hellishly > > complicated, and not universally loved. Which isn't to say that there > > isn't a simple and loveable way to do it, wa

Re: Multi-Master Logical Replication

2022-06-09 Thread Amit Kapila
On Thu, Jun 9, 2022 at 6:04 PM Bharath Rupireddy wrote: > > On Thu, Apr 28, 2022 at 5:20 AM Peter Smith wrote: > > > > MULTI-MASTER LOGICAL REPLICATION > > > > 1.0 BACKGROUND > > > > Let’s assume that a user wishes to set up a multi-master environment > > so that a set of PostgreSQL instances (no

Re: Allow foreign keys to reference a superset of unique columns

2022-06-09 Thread Peter Eisentraut
On 10.06.22 05:47, David Rowley wrote: I think this should be referring to constraint name, not an index name. Can you explain why you think that? If you wanted to specify this feature in the SQL standard (I'm not proposing that, but it seems plausible), then you need to deal in terms of con

Re: Allow foreign keys to reference a superset of unique columns

2022-06-09 Thread David Rowley
On Fri, 10 Jun 2022 at 15:08, Peter Eisentraut wrote: > > On 07.06.22 20:59, Kaiting Chen wrote: > > 2. The FOREIGN KEY constraint syntax gains a [ USING INDEX index_name ] > > clause > > optionally following the referenced column list. > > > > The index specified by this clause is used t

Re: Allow foreign keys to reference a superset of unique columns

2022-06-09 Thread Peter Eisentraut
On 07.06.22 20:59, Kaiting Chen wrote: 2. The FOREIGN KEY constraint syntax gains a [ USING INDEX index_name ] clause optionally following the referenced column list. The index specified by this clause is used to support the foreign key constraint, and it must be a non-deferrable uni

Re: Collation version tracking for macOS

2022-06-09 Thread Peter Geoghegan
On Thu, Jun 9, 2022 at 6:23 PM Thomas Munro wrote: > Well I can report that the system from ec483147 was hellishly > complicated, and not universally loved. Which isn't to say that there > isn't a simple and loveable way to do it, waiting to be discovered, > and I do think we could fix most of th

Re: Collation version tracking for macOS

2022-06-09 Thread Tobias Bussmann
Am 08.06.2022 um 16:16 schrieb Tom Lane : > The proposed patch would result in a warning about every collation- > sensitive index during every macOS major version upgrade, ie about > once a year for most people. > We need something that has at least *some* connection to actual changes. In Postgr

Re: Collation version tracking for macOS

2022-06-09 Thread Thomas Munro
On Fri, Jun 10, 2022 at 1:06 PM Peter Geoghegan wrote: > On Thu, Jun 9, 2022 at 5:59 PM Thomas Munro wrote: > > That sounds nice, but introduces subtle problems for the planner. For > > example, pathkeys that look compatible might not be, when > > merge-joining an ICU 63 index scan against an IC

Re: Collation version tracking for macOS

2022-06-09 Thread Peter Geoghegan
On Thu, Jun 9, 2022 at 5:59 PM Thomas Munro wrote: > That sounds nice, but introduces subtle problems for the planner. For > example, pathkeys that look compatible might not be, when > merge-joining an ICU 63 index scan against an ICU 67 index scan. You > could teach it about that, whereas with

Re: Collation version tracking for macOS

2022-06-09 Thread Thomas Munro
On Fri, Jun 10, 2022 at 12:32 PM Peter Geoghegan wrote: > On Thu, Jun 9, 2022 at 5:18 PM Thomas Munro wrote: > > You seem to have some > > other idea in mind where the system only knows about one > > "en-US-x-icu", but somehow, somewhere else (where?), keeps track of > > which indexes were built

Re: Collation version tracking for macOS

2022-06-09 Thread Tobias Bussmann
Thanks for picking this up! > How can I see evidence of this? I'm comparing Debian, FreeBSD and > macOS 12.4 and when I run "LC_COLLATE=en_US.UTF-8 sort > /usr/share/dict/words" I get upper and lower case mixed together on > the other OSes, but on the Mac the upper case comes first, which is my >

Re: Collation version tracking for macOS

2022-06-09 Thread Peter Geoghegan
On Thu, Jun 9, 2022 at 5:18 PM Thomas Munro wrote: > However, since you mentioned that a simple REINDEX would get you from > one library version to another, I think we're making some completely > different assumptions somewhere along the line, and I don't get your > idea yet. It sounds like you d

doc: array_length produces null instead of 0

2022-06-09 Thread David G. Johnston
Hi, Per discussion here: https://www.postgresql.org/message-id/163636931138.8076.5140809232053731248%40wrigleys.postgresql.org We can now easily document the array_length behavior of returning null instead of zero for an empty array/dimension. I added an example to the json_array_length functio

Re: Collation version tracking for macOS

2022-06-09 Thread Thomas Munro
On Fri, Jun 10, 2022 at 10:29 AM Peter Geoghegan wrote: > On Thu, Jun 9, 2022 at 2:20 PM Finnerty, Jim wrote: > > For example, an alternate syntax might be: > > > > create collation icu63."en-US-x-icu" (provider = icu, locale = > > 'en-US@colVersion=63'); > > Why would a user want to specify

Re: better page-level checksums

2022-06-09 Thread Matthias van de Meent
On Thu, 9 Jun 2022 at 23:13, Robert Haas wrote: > > On Thu, Oct 7, 2021 at 11:50 AM Stephen Frost wrote: > > Alternatively, we could use > > that technique to just provide a better per-page checksum than what we > > have today. Maybe we could figure out how to leverage that to move to > > 64bit

Re: Collation version tracking for macOS

2022-06-09 Thread Peter Geoghegan
On Thu, Jun 9, 2022 at 4:23 PM Thomas Munro wrote: > Suppose you pg_upgrade to something that is linked against 71. > Perhaps you'd need to tell it how to dlopen 67 before you can open any > collations with that library, but once you've done that your > collation-dependent partition constraints et

doc: Bring mention of unique index forced transaction wait behavior outside of the internal section

2022-06-09 Thread David G. Johnston
Hi. The fact that one transaction will wait on another if they are trying to claim the same unique value is presently relegated to a subchapter of the documentation where the typical reader will not even understand (rightly so) the main chapter's title. This has prompted a number of questions bei

Re: [PoC] Let libpq reject unexpected authentication requests

2022-06-09 Thread Jacob Champion
On Wed, Jun 8, 2022 at 9:58 PM Michael Paquier wrote: > > - require_auth=scram-sha-256,cert means that either a SCRAM handshake > > must be completed, or the server must request a client certificate. It > > has a potential pitfall in that it allows a partial SCRAM handshake, > > as long as a certi

Re: Collation version tracking for macOS

2022-06-09 Thread Thomas Munro
On Fri, Jun 10, 2022 at 9:20 AM Finnerty, Jim wrote: > Specifying the library name before the language-country code with a new > separator (":") as you suggested below has some benefits. One of the reasons for putting some representation of desired library into the colliculocale column (rather

Re: Logging query parmeters in auto_explain

2022-06-09 Thread Dagfinn Ilmari Mannsåker
Michael Paquier writes: > On Tue, Jun 07, 2022 at 12:18:52PM +0100, Dagfinn Ilmari Mannsåker wrote: >> Point, fixed in the attached v2. I've also added a test that truncation >> and disabling works. > > The tests are structured so as all the queries are run first, then the > full set of logs is s

Re: Collation version tracking for macOS

2022-06-09 Thread Peter Geoghegan
On Thu, Jun 9, 2022 at 2:20 PM Finnerty, Jim wrote: > Specifying the library name before the language-country code with a new > separator (":") as you suggested below has some benefits. Did you consider > making the collation version just another collation attribute, such as > colStrength, col

Re: pgcon unconference / impact of block size on performance

2022-06-09 Thread Tomas Vondra
On 6/9/22 13:23, Jakub Wartak wrote: >>> The really >> puzzling thing is why is the filesystem so much slower for smaller >> pages. I mean, why would writing 1K be 1/3 of writing 4K? >> Why would a filesystem have such effect? > > Ha! I don't care at this point as 1 or 2

Re: better page-level checksums

2022-06-09 Thread Peter Geoghegan
On Thu, Jun 9, 2022 at 2:33 PM Peter Geoghegan wrote: > My preference is for an approach that builds on that, or at least > doesn't significantly complicate it. So a cryptographic hash or nonce > can go in the special area proper (structs like BTPageOpaqueData don't > need any changes), but at a p

Re: better page-level checksums

2022-06-09 Thread Peter Geoghegan
On Thu, Jun 9, 2022 at 2:13 PM Robert Haas wrote: > I'm interested in assessing the feasibility of a "better page-level > checksums" feature. I have a few questions, and a few observations. > One of my questions is what algorithm(s) we'd want to support. I did a > quick Google search and found tha

Re: Collation version tracking for macOS

2022-06-09 Thread Finnerty, Jim
Specifying the library name before the language-country code with a new separator (":") as you suggested below has some benefits. Did you consider making the collation version just another collation attribute, such as colStrength, colCaseLevel, etc.? For example, an alternate syntax might be:

better page-level checksums

2022-06-09 Thread Robert Haas
On Thu, Oct 7, 2021 at 11:50 AM Stephen Frost wrote: > Alternatively, we could use > that technique to just provide a better per-page checksum than what we > have today. Maybe we could figure out how to leverage that to move to > 64bit transaction IDs with some page-level epoch. I'm interested i

Re: Tightening behaviour for non-immutable behaviour in immutable functions

2022-06-09 Thread Peter Geoghegan
On Thu, Jun 9, 2022 at 12:39 PM Greg Stark wrote: > Generally I think the idea is that the user *is* responsible for > writing immutable functions carefully to hide any non-deterministic > behaviour from the code they're calling. But that does raise the > question of why to focus on search_path. >

Re: Tightening behaviour for non-immutable behaviour in immutable functions

2022-06-09 Thread Greg Stark
On Wed, 8 Jun 2022 at 19:39, Mark Dilger wrote: > > > I like the general idea, but I'm confused why you are limiting the analysis > to search path resolution. The following is clearly wrong, but not for that > reason: > > create function public.identity () returns double precision as $$ > sel

Re: Checking for missing heap/index files

2022-06-09 Thread Stephen Frost
Greetings, * Bruce Momjian (br...@momjian.us) wrote: > We currently can check for missing heap/index files by comparing > pg_class with the database directory files. However, I am not clear if > this is safe during concurrent DDL. I assume we create the file before > the update to pg_class is vi

Re: Checking for missing heap/index files

2022-06-09 Thread Peter Geoghegan
On Thu, Jun 9, 2022 at 11:46 AM Bruce Momjian wrote: > I don't have a need for it --- I was just wondering why we have > something that checks the relation contents, but not the file existence? We do this for B-tree indexes within amcheck. They must always have storage, if only to store the index

Re: BTMaxItemSize seems to be subtly incorrect

2022-06-09 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Wed, Jun 8, 2022 at 5:55 PM Peter Geoghegan wrote: > > > That's a problem, because if in that scenario you allow three 2704 > > > byte items that don't need a heap TID and later you find you need to > > > add a heap TID to one of those

Re: Checking for missing heap/index files

2022-06-09 Thread Bruce Momjian
On Thu, Jun 9, 2022 at 09:46:51AM -0700, Mark Dilger wrote: > > > > On Jun 8, 2022, at 5:45 AM, Bruce Momjian wrote: > > > > Is this something anyone has even needed or had requested? > > I might have put this in amcheck's verify_heapam() had there been an > interface for it. I vaguely recall wan

Re: Collation version tracking for macOS

2022-06-09 Thread Peter Geoghegan
On Thu, Jun 9, 2022 at 10:54 AM Jeremy Schneider wrote: > MySQL did the right thing here by doing what every other RDBMS did, and just > making a simple “good-enough” collation hardcoded in the DB, same across all > platforms, that never changes. That's not true. Both SQL Server and DB2 have so

Re: Collation version tracking for macOS

2022-06-09 Thread Peter Geoghegan
On Thu, Jun 9, 2022 at 10:54 AM Jeremy Schneider wrote: > I’m probably just going to end up rehashing the old threads I haven’t read > yet… > > One challenge with this approach is you have things like sort-merge joins > that require the same collation across multiple objects. So I think you’d >

Re: ALTER TABLE SET ACCESS METHOD on partitioned tables

2022-06-09 Thread Soumyadeep Chakraborty
On Wed, May 18, 2022 at 6:26 PM Zhihong Yu wrote: > + accessMethodId = ((Form_pg_class) GETSTRUCT(tup))->relam; > > - /* look up the access method, verify it is for a table */ > - if (accessMethod != NULL) > - accessMethodId = get_table_am_oid(accessMethod, false); > + if (!

Re: BTMaxItemSize seems to be subtly incorrect

2022-06-09 Thread Robert Haas
On Thu, Jun 9, 2022 at 1:39 PM Peter Geoghegan wrote: > On Thu, Jun 9, 2022 at 6:40 AM Robert Haas wrote: > > Are you going to code up a patch? > > I can, but feel free to fix it yourself if you prefer. Your analysis > seems sound. I think I'd feel more comfortable if you wrote the patch, if tha

Re: Collation version tracking for macOS

2022-06-09 Thread Jeremy Schneider
> On Jun 8, 2022, at 22:40, Peter Geoghegan wrote: > > On Wed, Jun 8, 2022 at 10:24 PM Jeremy Schneider > wrote: >> Even if PG supports two versions of ICU, how does someone actually go about >> removing every dependency on the old version and replacing it with the new? > > They simply REIN

Re: BTMaxItemSize seems to be subtly incorrect

2022-06-09 Thread Peter Geoghegan
On Thu, Jun 9, 2022 at 6:40 AM Robert Haas wrote: > Are you going to code up a patch? I can, but feel free to fix it yourself if you prefer. Your analysis seems sound. -- Peter Geoghegan

Re: Checking for missing heap/index files

2022-06-09 Thread Mark Dilger
> On Jun 8, 2022, at 5:45 AM, Bruce Momjian wrote: > > Is this something anyone has even needed or had requested? I might have put this in amcheck's verify_heapam() had there been an interface for it. I vaguely recall wanting something like this, yes. As it stands, verify_heapam() may trig

Re: Error from the foreign RDBMS on a foreign table I have no privilege on

2022-06-09 Thread Laurenz Albe
On Thu, 2022-06-09 at 21:55 +0900, Etsuro Fujita wrote: > On Thu, Jun 9, 2022 at 9:49 AM Laurenz Albe wrote: > > On Wed, 2022-06-08 at 19:06 +0900, Etsuro Fujita wrote: > > > On Wed, Jun 8, 2022 at 2:51 PM Kyotaro Horiguchi > > > wrote: > > > > At Wed, 08 Jun 2022 07:05:09 +0200, Laurenz Albe >

doc: Move enum storage commentary to top of section

2022-06-09 Thread David G. Johnston
Per suggestion over on -docs: https://www.postgresql.org/message-id/bl0pr06mb4978f6c0b69f3f03aebed0fbb3...@bl0pr06mb4978.namprd06.prod.outlook.com David J. 0001-doc-Move-enum-storage-size-to-top-of-section.patch Description: Binary data

doc: Make selectivity example match wording

2022-06-09 Thread David G. Johnston
Hi, Reposting this to its own thread. https://www.postgresql.org/message-id/flat/CAKFQuwby1aMsJDMeibaBaohgoaZhivAo4WcqHC1%3D9-GDZ3TSng%40mail.gmail.com doc: make unique non-null join selectivity example match the prose The description of the computation for the unique, non-null, joi

doc: Fix description of how the default user name is chosen

2022-06-09 Thread David G. Johnston
Hi. Reposting this on its own thread. https://www.postgresql.org/message-id/flat/CAKFQuwby1aMsJDMeibaBaohgoaZhivAo4WcqHC1%3D9-GDZ3TSng%40mail.gmail.com The default database name is just the user name, not the operating-system user name. In passing, the authentication error examples

doc: Clarify Routines and Extension Membership

2022-06-09 Thread David G. Johnston
Hi. Reposting this on its own thread. https://www.postgresql.org/message-id/flat/CAKFQuwby1aMsJDMeibaBaohgoaZhivAo4WcqHC1%3D9-GDZ3TSng%40mail.gmail.com Per discussion on -general the documentation for the ALTER ROUTINE ... DEPENDS ON EXTENSION and DROP EXTENSION doesn't clearly indic

Re: doc: Clarify Savepoint Behavior

2022-06-09 Thread David G. Johnston
On Thu, Jun 9, 2022 at 8:36 AM David G. Johnston wrote: > Hi, > > Reposting this on its own thread. > > > https://www.postgresql.org/message-id/flat/CAKFQuwby1aMsJDMeibaBaohgoaZhivAo4WcqHC1%3D9-GDZ3TSng%40mail.gmail.com > > Presently, the open item seems to be whether my novelty regarding the > r

doc: Clarify what "excluded" represents for INSERT ON CONFLICT

2022-06-09 Thread David G. Johnston
Hi, Reposting this on its own thread. https://www.postgresql.org/message-id/flat/CAKFQuwby1aMsJDMeibaBaohgoaZhivAo4WcqHC1%3D9-GDZ3TSng%40mail.gmail.com As one cannot place excluded in a FROM clause (subquery) in the ON CONFLICT clause referring to it as a table, with plural rows none

doc: Clarify Savepoint Behavior

2022-06-09 Thread David G. Johnston
Hi, Reposting this on its own thread. https://www.postgresql.org/message-id/flat/CAKFQuwby1aMsJDMeibaBaohgoaZhivAo4WcqHC1%3D9-GDZ3TSng%40mail.gmail.com Presently, the open item seems to be whether my novelty regarding the reworked example is too much. David J. 0001-doc-Clarify-Savepoint-behav

Re: broken regress tests on fedora 36

2022-06-09 Thread Tom Lane
Peter Eisentraut writes: > Shouldn't we reset the locale setting (LC_NUMERIC?) to a known value? > We clearly already do that for other categories, or it wouldn't say "Time:". pg_regress.c and Utils.pm force LC_MESSAGES to C, explaining * Set translation-related settings to English; ot

[no subject]

2022-06-09 Thread Tom Lane
Peter Eisentraut writes: > Initially, that chapter did not document any system views. Maybe we could make the system views a separate chapter? regards, tom lane

Re: broken regress tests on fedora 36

2022-06-09 Thread Peter Eisentraut
On 07.06.22 14:56, Michael Paquier wrote: On Tue, Jun 07, 2022 at 10:52:45AM +0200, Pavel Stehule wrote: # Failed test '\timing with query error: timing output appears' # at t/001_basic.pl line 95. # 'Time: 0,293 ms' # doesn't match '(?^m:^Time: \d+\.\d\d\d ms)' # Looks

Re: BTMaxItemSize seems to be subtly incorrect

2022-06-09 Thread Robert Haas
On Wed, Jun 8, 2022 at 7:44 PM Peter Geoghegan wrote: > FWIW I don't see much difference between borrowing special space and > adding something to BTPageOpaqueData. If anything I'd prefer the > latter. I think this discussion will take us too far afield from the topic of this thread, so I'll just

Re: Replica Identity check of partition table on subscriber

2022-06-09 Thread Amit Langote
Hi Amit, On Thu, Jun 9, 2022 at 8:02 PM Amit Kapila wrote: > On Wed, Jun 8, 2022 at 2:17 PM shiy.f...@fujitsu.com > wrote: > > I saw a problem in logical replication, when the target table on subscriber > > is a > > partitioned table, it only checks whether the Replica Identity of > > partitio

Re:

2022-06-09 Thread Peter Eisentraut
On 09.06.22 01:29, Peter Smith wrote: OTOH it looks like this table of contents page has been this way forever (20+ years?). It is hard to believe nobody else suggested modifying it in all that time, so perhaps there is some reason for it being like it is? Initially, that chapter did not docume

Re: [PATCH] Expose port->authn_id to extensions and triggers

2022-06-09 Thread Robert Haas
On Wed, Jun 8, 2022 at 7:53 PM Jacob Champion wrote: > But I don't have any better ideas for how to achieve both. I'm fine > with your suggestion of ClientConnectionInfo, if that sounds good to > others; the doc comment can clarify why it differs from Port? Or add > one of the Shared-/Gang-/Group-

Re: Error from the foreign RDBMS on a foreign table I have no privilege on

2022-06-09 Thread Etsuro Fujita
On Thu, Jun 9, 2022 at 9:49 AM Laurenz Albe wrote: > On Wed, 2022-06-08 at 19:06 +0900, Etsuro Fujita wrote: > > On Wed, Jun 8, 2022 at 2:51 PM Kyotaro Horiguchi > > wrote: > > > At Wed, 08 Jun 2022 07:05:09 +0200, Laurenz Albe > > > wrote in > > > > diff --git a/doc/src/sgml/postgres-fdw.sgml

Re: Multi-Master Logical Replication

2022-06-09 Thread Bharath Rupireddy
On Thu, Apr 28, 2022 at 5:20 AM Peter Smith wrote: > > MULTI-MASTER LOGICAL REPLICATION > > 1.0 BACKGROUND > > Let’s assume that a user wishes to set up a multi-master environment > so that a set of PostgreSQL instances (nodes) use logical replication > to share tables with every other node in the

RE: pgcon unconference / impact of block size on performance

2022-06-09 Thread Jakub Wartak
> > The really > puzzling thing is why is the filesystem so much slower for smaller > pages. I mean, why would writing 1K be 1/3 of writing 4K? > Why would a filesystem have such effect? > >>> > >>> Ha! I don't care at this point as 1 or 2kB seems too small to handle > >>> many

Re: Replica Identity check of partition table on subscriber

2022-06-09 Thread Amit Kapila
On Wed, Jun 8, 2022 at 2:17 PM shiy.f...@fujitsu.com wrote: > > I saw a problem in logical replication, when the target table on subscriber > is a > partitioned table, it only checks whether the Replica Identity of partitioned > table is consistent with the publisher, and doesn't check Replica Id

Re: Defer selection of asynchronous subplans until the executor initialization stage

2022-06-09 Thread Etsuro Fujita
On Wed, Jun 8, 2022 at 7:18 PM Etsuro Fujita wrote: > On Fri, Jun 3, 2022 at 1:03 AM Zhihong Yu wrote: > > Suggestion on formatting the comment: > > > > + * node (or that for any plan node in the subplan tree), 2) > > + * set_plan_references() modifies the tlist for every plan node in the > > > >

Re: Improve TAP tests of pg_upgrade for cross-version tests

2022-06-09 Thread Michael Paquier
On Wed, May 25, 2022 at 10:35:57AM +0900, Michael Paquier wrote: > On Tue, May 24, 2022 at 03:03:28PM +0900, Michael Paquier wrote: >> (Adding Andrew Dunstan in CC.) >> >> I have been toying with $subject, trying to improve the ways to test >> pg_upgrade across different major versions as perl mak

Re: A proposal to provide a timeout option for CREATE_REPLICATION_SLOT/pg_create_logical_replication_slot

2022-06-09 Thread Kyotaro Horiguchi
At Thu, 9 Jun 2022 10:25:06 +0530, Bharath Rupireddy wrote in > Hi, > > Currently CREATE_REPLICATION_SLOT/pg_create_logical_replication_slot waits > unboundedly if there are any in-progress write transactions [1]. The wait > is for a reason actually i.e. for building an initial snapshot, but wa