On Sun, 09 Oct 2022 at 11:07, Julien Rouhaud wrote:
> Hi,
>
> On Sun, Oct 09, 2022 at 07:42:58AM +0800, Japin Li wrote:
>>
>> Hi hackers,
>>
>> I find there are some unnecessary commas for goto lables,
>> attached a patch to remove them.
>
> You mean semi-colon? +1, and a quick regex later I
Hi,
On Sun, Oct 09, 2022 at 07:42:58AM +0800, Japin Li wrote:
>
> Hi hackers,
>
> I find there are some unnecessary commas for goto lables,
> attached a patch to remove them.
You mean semi-colon? +1, and a quick regex later I don't see any other
occurrence.
On 10/8/22 1:40 PM, Andres Freund wrote:
On 2022-10-08 09:53:50 -0700, Andres Freund wrote:
On 2022-10-07 19:56:33 -0700, Andres Freund wrote:
I'm planning to push this either later tonight (if I feel up to it after
cooking dinner) or tomorrow morning PST, due to the release wrap deadline.
I
On Sat, Oct 08, 2022 at 10:12:22AM -0700, Nathan Bossart wrote:
> Okay, I think there are sufficient votes against this change to simply mark
> it Rejected. Thanks for the discussion!
Even if the patch is at the end rejected, I think that the test is
still useful once you switch its logic to use
Hi hackers,
I find there are some unnecessary commas for goto lables,
attached a patch to remove them.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
>From 3ac7d03e1c5d81e883406ac62fafbe7e7d32fd1e Mon Sep 17 00:00:00 2001
From: Japin Li
Date: Sun, 9 Oct 2022 07:35:43
On Sun, Oct 2, 2022 at 12:12 AM Andres Freund wrote:
>
> Here's an updated patch adding meson compat.
Thank you, Andres! Here's one more rebase (something was adjusted in
amcheck build).
Also I've fixed new warnings except warning about absent
heapallindexed for GIN. It's a TODO.
Thanks!
Best
On Mon, Sep 19, 2022 at 07:49:21PM +0530, Bharath Rupireddy wrote:
> SwitchFromArchiveToStreamEnabled() seemed better at this point. I'm
> attaching the v7 patch with that change. Please review it further.
As I mentioned upthread [0], I'm still a little concerned that this patch
will cause the
On Sat, Oct 08, 2022 at 10:37:41AM -0700, Nathan Bossart wrote:
> Yeah, that makes more sense. It actually simplifies things a bit, too.
Sorry for the noise. There was an extra #include in v4 that I've removed
in v5.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
>From
On 2022-10-01 15:07, Peter Eisentraut wrote:
On 22.09.22 20:06, Marina Polyakova wrote:
On 2022-09-21 17:53, Peter Eisentraut wrote:
Committed with that test, thanks. I think that covers all the ICU
issues you reported for PG15 for now?
I thought about the order of the ICU checks - if it is
Andres Freund writes:
> When can PostmasterContext be NULL here, and why can we just continue without
> (re-)allocating PMChildInUse?
We'd only get into the !found stanza in a postmaster or a
standalone backend. A standalone backend isn't ever going to call
AssignPostmasterChildSlot or
On 2022-10-08 09:53:50 -0700, Andres Freund wrote:
> On 2022-10-07 19:56:33 -0700, Andres Freund wrote:
> > I'm planning to push this either later tonight (if I feel up to it after
> > cooking dinner) or tomorrow morning PST, due to the release wrap deadline.
>
> I looked this over again, tested a
On Sat, Oct 08, 2022 at 02:11:38PM +0900, Michael Paquier wrote:
> Using an ereport(NOTICE) to show the data reported in the callback is
> fine by me. How about making the module a bit more modular, by
> passing as argument a regclass and building a list of arguments with
> it? You may want to
Hi,
On 2022-10-08 13:15:07 -0400, Tom Lane wrote:
> I wrote:
> > Andres Freund writes:
> >> Only PM_CHILD_ACTIVE and PM_CHILD_WALSENDER though. We could afford another
> >> MaxLivePostmasterChildren() sized array...
>
> > Oh, I see what you mean --- one private and one public array.
> > Maybe
I wrote:
> Andres Freund writes:
>> Only PM_CHILD_ACTIVE and PM_CHILD_WALSENDER though. We could afford another
>> MaxLivePostmasterChildren() sized array...
> Oh, I see what you mean --- one private and one public array.
> Maybe that makes more sense than what I did, not sure.
Yeah, that's
On Sat, Oct 08, 2022 at 09:57:02AM -0700, David G. Johnston wrote:
> I would tend to agree that even membership probably shouldn't be involved
> here, and that this entire feature would be implemented in an orthogonal
> manner. I don't see any specific need to try and move to a more isolated
>
On Sat, Oct 08, 2022 at 11:46:50AM -0400, Robert Haas wrote:
> Now there may be some other scenario in which the patch is going in
> exactly the right direction, and if I knew what it was, maybe I'd
> agree that the patch was a great idea. But I haven't seen anything
> like that on the thread.
On Sat, Oct 8, 2022 at 8:47 AM Robert Haas wrote:
> On Sat, Oct 8, 2022 at 11:14 AM Tom Lane wrote:
> > Joe Conway writes:
> > > Thanks -- looks good to me. If there are no other comments or concerns,
> > > I will commit/push by the end of the weekend.
> >
> > Robert seems to think that this
Hi,
On 2022-10-07 19:56:33 -0700, Andres Freund wrote:
> I'm planning to push this either later tonight (if I feel up to it after
> cooking dinner) or tomorrow morning PST, due to the release wrap deadline.
I looked this over again, tested a bit more, and pushed the adjusted 15 and
master
So I pushed that, but I don't feel that we're out of the woods yet.
As I mentioned at [1], while testing this stuff I hit a case where
aset.c will try to wipe_mem practically the entire address space after
being asked to pfree() an invalid pointer. The specific reproducer
isn't too interesting
On Sat, Oct 8, 2022 at 11:14 AM Tom Lane wrote:
> Joe Conway writes:
> > Thanks -- looks good to me. If there are no other comments or concerns,
> > I will commit/push by the end of the weekend.
>
> Robert seems to think that this patch might be completely misguided,
> so I'm not sure we have
Joe Conway writes:
> Thanks -- looks good to me. If there are no other comments or concerns,
> I will commit/push by the end of the weekend.
Robert seems to think that this patch might be completely misguided,
so I'm not sure we have real consensus. I think he may have a point.
An angle that
On 10/7/22 17:58, Nathan Bossart wrote:
On Fri, Oct 07, 2022 at 04:18:59PM -0400, Tom Lane wrote:
There's another problem there, which is that buildfarm animals
using -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS will complain
about role names that don't start with "regress_".
Huh, I hadn't
22 matches
Mail list logo
