Re: libpq compression (part 2)

On Sat, Nov 12, 2022 at 1:47 PM Andrey Borodin wrote: > > I've tried the patch, it works as advertised. While testing patch some more I observe unpleasant segfaults: #26 0x7fecafa1e058 in __memcpy_ssse3_back () from target:/lib64/libc.so.6 #27 0x0b08fda2 in lz4_decompress

Re: PGDOCS - Logical replication GUCs - added some xrefs

On Mon, 24 Oct 2022 at 13:15, Peter Smith wrote: > > Hi hackers. > > There is a docs Logical Replication section "31.10 Configuration > Settings" [1] which describes some logical replication GUCs, and > details on how they interact with each other and how to take that into > account when setting

Re: A new strategy for pull-up correlated ANY_SUBLINK

Andy Fan writes: > In the past we pull-up the ANY-sublink with 2 steps, the first step is to > pull up the sublink as a subquery, and the next step is to pull up the > subquery if it is allowed. The benefits of this method are obvious, > pulling up the subquery has more requirements, even if we

Re: Use fadvise in wal replay

On Sun, Aug 7, 2022 at 9:41 AM Andrey Borodin wrote: > Hi everyone. The patch is 16 lines, looks harmless and with proven benefits. I'm moving this into RfC. Thanks! Best regards, Andrey Borodin.

Re: libpq compression (part 2)

On Tue, Aug 2, 2022 at 1:53 PM Jacob Champion wrote: > > and changing the status to "Needs Review" I've tried the patch, it works as advertised. The code generally is OK, maybe some functions require comments (because at least their neighbours have some). Some linkers complain about

Re: proposal: possibility to read dumped table's name from file

Hi and updated patch Regards Pavel diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml index 8b9d9f4cad..d5a6e2c7ee 100644 --- a/doc/src/sgml/ref/pg_dump.sgml +++ b/doc/src/sgml/ref/pg_dump.sgml @@ -779,6 +779,80 @@ PostgreSQL documentation + +

Re: proposal: possibility to read dumped table's name from file

pá 11. 11. 2022 v 9:11 odesílatel Julien Rouhaud napsal: > Hi, > > On Sat, Nov 05, 2022 at 08:54:57PM +0100, Pavel Stehule wrote: > > > > pá 4. 11. 2022 v 14:28 odesílatel Julien Rouhaud > > napsal: > > > > > > But one thing I noticed is that "optarg" looks wrong here: > > > > > > > >

Re: Fix order of checking ICU options in initdb and create database

Hello Marina. I just reviewed your patch. It applied cleanly at my current master (commit d6a3dbe14f98d867b2fc3faeb99d2d3c2a48ca67). Also, it worked as described in email. Since it's a clarification in an error message, I think the documentation is fine. I played a bit with "make check",

Re: generate_series for timestamptz and time zone problem

=?UTF-8?Q?Przemys=c5=82aw_Sztoch?= writes: > Gurjeet Singh wrote on 01.07.2022 06:35: >> Can you please explain why you chose to remove the provolatile >> attribute from the existing entry of date_trunc in pg_proc.dat. > I believe it was a mistake in PG code. > All timestamptz functions must be

Re: Lack of PageSetLSN in heap_xlog_visible

On Fri, 2022-11-11 at 12:43 +0200, Konstantin Knizhnik wrote: > Yes, you are right: my original concerns that it may cause problems > with > recovery at replica are not correct. Great, thank you for following up. > I also not sure that it can cause problems with checksums - page is > marked as

Re: Remove unused param rte in set_plain_rel_pathlist

Zhang Mingli writes: > Param RangeTblEntry *rte in function set_plain_rel_pathlist is not used at > all. > Add a path to remove it. I'm disinclined to change that, as it'd make set_plain_rel_pathlist different from its sibling functions, which do need the RTE. In practice this has cost zero

Re: Avoid overhead open-close indexes (catalog updates)

Em sex., 11 de nov. de 2022 às 01:54, Michael Paquier escreveu: > On Thu, Nov 10, 2022 at 08:56:25AM -0300, Ranier Vilela wrote: > > For CopyStatistics() have performance checks. > > You are not giving all the details of your tests, though, Windows 10 64 bits SSD 256 GB pgbench -i

Re: logical replication restrictions

On Thu, 11 Aug 2022 at 02:03, Euler Taveira wrote: > > On Wed, Aug 10, 2022, at 9:39 AM, osumi.takami...@fujitsu.com wrote: > > Minor review comments for v6. > > Thanks for your review. I'm attaching v7. > > "If the subscriber sets min_apply_delay parameter, ..." > > I suggest we use subscription

Remove unused param rte in set_plain_rel_pathlist

Hi, hackers Param RangeTblEntry *rte in function set_plain_rel_pathlist is not used at all. I look at the commit e2fa76d80b(10 years ago), it’s useless since then. Add a path to remove it. Regards, Zhang Mingli v1-0001-Remove-unused-param-rte-in-set_plain_rel_pathlist.patch Description:

Re: Perform streaming logical transactions by background workers and parallel apply

On Fri, Nov 11, 2022 at 2:12 PM houzj.f...@fujitsu.com wrote: > Few comments on v46-0001: == 1. +static void +apply_handle_stream_abort(StringInfo s) { ... + /* Send STREAM ABORT message to the parallel apply worker. */ + parallel_apply_send_data(winfo, s->len, s->data); + +

Re: Allow file inclusion in pg_hba and pg_ident files

On Thu, Nov 10, 2022 at 10:29:40AM +0900, Michael Paquier wrote: > > FWIW, I have been playing with the addition of a ErrorContextCallback > in tokenize_auth_file(), and this addition leads to a really nice > result. With this method, it is possible to know the full chain of > events leading to a