Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL

2022-12-25 Thread Michael Paquier
On Sat, Dec 24, 2022 at 06:23:29PM +0530, Bharath Rupireddy wrote: > Thanks for the patch. I've made the above change as well as renamed > the test file name to be save_fpi.pl, everything else remains the same > as v11. Here's the v12 patch which LGTM. I'll mark it as RfC - >

Re: [BUG] pg_upgrade test fails from older versions.

2022-12-25 Thread Anton A. Melnikov
Hello! On 23.12.2022 05:42, Michael Paquier wrote: On Thu, Dec 22, 2022 at 09:59:18AM +0300, Anton A. Melnikov wrote: 2) v2-0002-Additional-dumps-filtering.patch + # Replace specific privilegies with ALL + $dump_contents =~ s/^(GRANT\s|REVOKE\s)(\S*)\s/$1ALL /mgx; This should not

Re: [BUG] pg_upgrade test fails from older versions.

2022-12-25 Thread Michael Paquier
On Fri, Dec 23, 2022 at 12:43:00PM +0300, Anton A. Melnikov wrote: > Sorry, didn't get to see the last letter! No worries, the result is the same :) I was looking at 0002 to add a callback to provide custom filtering rules. + my @ext_filter = split('\/', $_); Are you sure that

Re: [BUG] pg_upgrade test fails from older versions.

2022-12-25 Thread Michael Paquier
On Fri, Dec 23, 2022 at 10:39:25AM -0600, Justin Pryzby wrote: > LGTM. Thanks. Done as of d3c0cc4. -- Michael signature.asc Description: PGP signature

Re: pg_upgrade: Make testing different transfer modes easier

2022-12-25 Thread Daniel Gustafsson
> On 19 Dec 2022, at 01:39, Shinoda, Noriyoshi (PN Japan FSIP) > wrote: > With the addition of --copy option, pg_upgrade now has three possible > transfer mode options. Currently, an error does not occur even if multiple > transfer modes are specified. For example, we can also run "pg_upgrade

Re: Error-safe user functions

2022-12-25 Thread Tom Lane
I got annoyed by the fact that types cid, xid, xid8 don't throw error even for obvious garbage, because they just believe the result of strtoul or strtoull without any checking. That was probably up to project standards when cidin and xidin were written; but surely it's not anymore, especially

Re: [PATCH] Improve ability to display optimizer analysis using OPTIMIZER_DEBUG

2022-12-25 Thread Ankit Kumar Pandey
On 25/12/22 23:54, Tom Lane wrote: These days people would probably also wish that the output could be machine- readable in some way (JSON-formatted, perhaps). Perhaps switch to enable logs could be on (standard logging style), json, xml etc and print the output as required?

Re: [PATCH] Improve ability to display optimizer analysis using OPTIMIZER_DEBUG

2022-12-25 Thread Tom Lane
Ankit Kumar Pandey writes: > As per as suggestion in the mailing list which is to replace current > mechanism of getting optimizer log via OPTIMIZER_DEBUG macro > to something more configurable (which doesn't require rebuilding > postgres from source code). This patch replaces /OPTIMIZER_DEBUG

Re: [RFC] Add jit deform_counter

2022-12-25 Thread Pavel Stehule
Hi ne 11. 12. 2022 v 5:44 odesílatel Pavel Stehule napsal: > Hi > > ne 11. 12. 2022 v 1:14 odesílatel Ian Lawrence Barwick > napsal: > >> 2022年6月12日(日) 18:14 Dmitry Dolgov <9erthali...@gmail.com>: >> > >> > Hi, >> > >> > I've noticed that JIT performance counter generation_counter seems to >>

Re: Error-safe user functions

2022-12-25 Thread Tom Lane
Robert Haas writes: > On Fri, Dec 16, 2022 at 1:31 PM Tom Lane wrote: >> The reg* functions probably need a unified plan as to how far >> down we want to push non-error behavior. > I would be in favor of an aggressive approach. Here's a proposed patch for converting regprocin and friends to

[PATCH] Improve ability to display optimizer analysis using OPTIMIZER_DEBUG

2022-12-25 Thread Ankit Kumar Pandey
Hi all, This is patch for TODO item: /Improve ability to display optimizer analysis using OPTIMIZER_DEBUG / As per as suggestion in the mailing list which is to replace current mechanism of getting optimizer log via OPTIMIZER_DEBUG macro to something more configurable (which doesn't

Todo: Teach planner to evaluate multiple windows in the optimal order

2022-12-25 Thread Ankit Kumar Pandey
Hi, While looking at one of the todo item in Window function, namely: /Teach planner to evaluate multiple windows in the optimal order Currently windows are always evaluated in the query-specified order./ From threads, relevant points. Point #1 In the above query Oracle 10g performs 2

Re: daitch_mokotoff module

2022-12-25 Thread Alvaro Herrera
Hello On 2022-Dec-23, Dag Lem wrote: > It seems to me like you're trying to use soundex coding for something it > was never designed for. I'm not trying to use it for anything, actually. I'm just reading the pages your patch links to, to try and understand how this algorithm can be best

Re: [PATCH] Enable using llvm jitlink as an alternative llvm jit linker of old Rtdyld.

2022-12-25 Thread Andres Freund
Hi, On 2022-11-23 21:13:04 +1100, Alex Fan wrote: > > @@ -241,6 +246,40 @@ llvm_mutable_module(LLVMJitContext *context) > > context->module = LLVMModuleCreateWithName("pg"); > > LLVMSetTarget(context->module, llvm_triple); > >

Re: Improve WALRead() to suck data directly from WAL buffers when possible

2022-12-25 Thread Dilip Kumar
On Fri, Dec 23, 2022 at 3:46 PM Bharath Rupireddy wrote: > > On Mon, Dec 12, 2022 at 8:27 AM Kyotaro Horiguchi > wrote: > > > > Thanks for providing thoughts. > > > At Fri, 9 Dec 2022 14:33:39 +0530, Bharath Rupireddy > > wrote in > > > The patch introduces concurrent readers for the WAL