Re: Time delayed LR (WAS Re: logical replication restrictions)

On Fri, Feb 10, 2023 at 4:56 PM Takamichi Osumi (Fujitsu) wrote: > > On Friday, February 10, 2023 2:05 PM Friday, February 10, 2023 2:05 PM wrote: > > On Fri, Feb 10, 2023 at 10:11 AM Amit Kapila > > wrote: > > In the previous patch, we couldn't solve the > timeout of the publisher, when we

Re: Killing off removed rels properly

On Sat, Feb 11, 2023 at 4:50 AM Tom Lane wrote: > I think it's time to clean this up by removing the rel from the > planner data structures altogether. The attached passes check-world, > and if it does trigger any problems I would say that's a clear > sign of bugs elsewhere. +1. The patch

Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes?

At Mon, 13 Feb 2023 10:15:03 +0530, Bharath Rupireddy wrote in > On Sun, Feb 12, 2023 at 11:01 PM Andres Freund wrote: > > > > On 2023-02-12 19:59:00 +0530, Bharath Rupireddy wrote: > > > /* Prepare to write out a lot of copies of our zero buffer at once. > > > */ > > > for (i =

Re: Consolidate ItemPointer to Datum conversion functions

On 09.02.23 09:33, Peter Eisentraut wrote: On 06.02.23 11:11, Heikki Linnakangas wrote: On 06/02/2023 11:54, Peter Eisentraut wrote: Instead of defining the same set of macros several times, define it once in an appropriate header file.  In passing, convert to inline functions. Looks good to

Re: Support logical replication of DDLs

On 2023-Feb-06, Peter Smith wrote: > I thought this comment was analogous to another one from this same > patch 0001 (see seclabel.c), so the suggested change above was simply > to make the wording consistent. > > @@ -134,6 +134,9 @@ ExecSecLabelStmt(SecLabelStmt *stmt) >

Get rid of PgStat_BackendFunctionEntry

Hi hackers, Please find attached a patch proposal to $SUBJECT: it would allow to simplify even more the work done to generate pg_stat_get_xact*() functions with Macros. This is a follow up for [1] where it has been suggested to get rid of PgStat_BackendFunctionEntry in a separate patch.

Re: Reconcile stats in find_tabstat_entry() and get rid of PgStat_BackendFunctionEntry

Hi, On 2/13/23 8:40 AM, Kyotaro Horiguchi wrote: At Mon, 13 Feb 2023 08:09:50 +0100, "Drouvot, Bertrand" wrote in I think this is useful beyond being able to generate those functions with macros. The fact that we had to deal with transactional code in pgstatfuncs.c meant that a lot of the

Re: Time delayed LR (WAS Re: logical replication restrictions)

Here are my review comments for the v34 patch. == src/backend/replication/logical/worker.c +/* The last time we send a feedback message */ +static TimestampTz send_time = 0; + IMO this is a bad variable name. When this variable was changed to be global it ought to have been renamed. The

Re: Rework LogicalOutputPluginWriterUpdateProgress

On Sat, Feb 11, 2023 at 2:34 AM Andres Freund wrote: > > On 2023-02-09 11:21:41 +0530, Amit Kapila wrote: > > On Thu, Feb 9, 2023 at 1:33 AM Andres Freund wrote: > > > > > > Hacking on a rough prototype how I think this should rather look, I had a > > > few > > > questions / remarks: > > > > >

Re: ExecRTCheckPerms() and many prunable partitions (sqlsmith)

On Mon, Feb 13, 2023 at 5:07 Justin Pryzby wrote: > On Tue, Nov 29, 2022 at 10:37:56PM +0900, Amit Langote wrote: > > 0002 contains changes that has to do with changing how we access > > checkAsUser in some foreign table planning/execution code sites. > > Thought it might be better to describe

<    1   2