On Mon, May 15, 2023 at 7:24 PM Jelte Fennema wrote:
>
> On Mon, 15 May 2023 at 14:47, Masahiko Sawada wrote:
> > Thank you for the patch! I think we might want to have tests for it.
>
> Yes, code looks good. But indeed some tests would be great. It seems
> we forgot to actually do:
>
Agreed wit
On Fri, May 12, 2023 at 5:25 PM Ajin Cherian wrote:
>
> On Fri, May 12, 2023 at 1:49 PM Amit Kapila wrote:
> >
>
> I tried the following test:
>
>
> Repeat On the publisher and subscriber:
> /* Create role regress_alice with NOSUPERUSER on
>publisher and subscriber and
On Mon, May 15, 2023 at 12:36:51PM -0700, Nathan Bossart wrote:
> There's still some time before we'll be able to commit any of these, but
> here is an attempt at addressing all the feedback thus far.
- The parenthesized syntax was added in
- PostgreSQL 9.0; the unparenthesized
- syntax is
Hi,
On 5/15/23 4:39 PM, Bharath Rupireddy wrote:
On Mon, May 15, 2023 at 6:14 PM Masahiko Sawada wrote:
On Mon, May 15, 2023 at 1:49 PM Thomas Munro wrote:
Do we need to add an open item for this issue in
https://wiki.postgresql.org/wiki/PostgreSQL_16_Open_Items? If yes, can
anyone in this
On Mon, May 15, 2023 at 10:07:04AM +0200, Drouvot, Bertrand wrote:
> This is preliminary work to autogenerate some wait events
> code and documentation done in [1].
>
> The patch introduces 2 new "wait events" (WAIT_EVENT_EXTENSION
> and WAIT_EVENT_BUFFER_PIN) and their associated functions
> (pgs
Dear Peter,
Thanks for reviewing! PSA new version patchset.
> 1. get_logical_slot_infos_per_db
>
> I noticed that the way this is coded, 'ntups' and 'num_slots' seems to
> have exactly the same meaning. IMO you can simplify this by removing
> 'ntups'.
>
> BEFORE
> + int ntups;
> + int num_slots
Hi,
On 5/16/23 7:14 AM, Michael Paquier wrote:
On Mon, May 15, 2023 at 06:01:02PM -0700, Andres Freund wrote:
On 2023-05-16 09:38:54 +0900, Michael Paquier wrote:
On Mon, May 15, 2023 at 05:17:16PM -0700, Andres Freund wrote:
These are the two things refactored in the patch, explaining the
On Mon, May 15, 2023 at 05:54:53PM -0700, Andres Freund wrote:
> Yes. numactl --physcpubind ... in my case. Linux has an optimization where it
> does not need to send an IPI when the client and server are scheduled on the
> same core. For single threaded ping-pong tasks like pgbench -c1, that can
On Tue, May 16, 2023 at 1:14 AM Michael Paquier wrote:
> On Mon, May 15, 2023 at 06:01:02PM -0700, Andres Freund wrote:
> > Why those tweaks are necessary is precisely what I am asking for.
>
> Then the perl script generates the same structures for all the wait
> event classes, with all the event
Noah Misch writes:
> For the record, I'm fairly sure s/public, test_ns_schema_1/test_ns_schema_1/
> on the new namespace tests would also solve things. Those tests don't need
> "public" in the picture. Nonetheless, +1 for your proposal.
Hmm, I'd not read the test case all that closely, but I di
On Mon, May 15, 2023 at 12:16:08PM -0400, Tom Lane wrote:
> Marina Polyakova writes:
> > IIUC the conflict was caused by
>
> > +SET search_path to public, test_ns_schema_1;
> > +CREATE SCHEMA test_ns_schema_2
> > + CREATE VIEW abc_view AS SELECT a FROM abc;
>
> > because the parallel regre
On Mon, May 15, 2023 at 06:01:02PM -0700, Andres Freund wrote:
> On 2023-05-16 09:38:54 +0900, Michael Paquier wrote:
>> On Mon, May 15, 2023 at 05:17:16PM -0700, Andres Freund wrote:
>>> IMO the submission should include why automating requires these changes
>>> (yours
>>> doesn't really either).
Hi Hackers,
I noticed some confusing behavior with REVOKE recently. Normally if
REVOKE fails to revoke anything a warning is printed. For example, see
the following scenario:
```
test=# SELECT current_role;
current_role
--
joe
(1 row)
test=# CREATE ROLE r1;
CREATE ROLE
test=# CREAT
Currently, I believe that we are frowning on writing things directly to
Public by default.
Also, we had already taken that step in our systems. Furthermore we force
Public to be the first Schema, so this restriction enforces that everything
created must be assigned to the appropriate schema.
Tha
On Mon, May 15, 2023 at 10:28 AM Tom Lane wrote:
> Alvaro Herrera writes:
> > It's worth considering what will readline history do with the comment.
> > As I recall, we keep /* comments */ together with the query that
> > follows, but the -- comments are keep in a separate history entry.
> > So
Hi,
On 2023-05-16 09:38:54 +0900, Michael Paquier wrote:
> On Mon, May 15, 2023 at 05:17:16PM -0700, Andres Freund wrote:
> > IMO the submission should include why automating requires these changes
> > (yours
> > doesn't really either). I can probably figure it out if I stare a bit at the
> > cod
Hi,
On 2023-05-16 09:42:31 +0900, Michael Paquier wrote:
> > I get quite variable performance if I don't pin client / server to the same
> > core, but even the slow performance is faster than 45k.
>
> Okay. You mean with something like taskset or similar, I guess?
Yes. numactl --physcpubind ...
On Mon, May 15, 2023 at 05:14:47PM -0700, Andres Freund wrote:
> On 2023-05-15 14:20:24 +0900, Michael Paquier wrote:
>> On Thu, May 11, 2023 at 01:28:40PM +0900, Michael Paquier wrote:
>> Extreme is adapted for a worst-case scenario. Looking at my notes
>> from a few months back, that's kind of w
On Mon, May 15, 2023 at 05:17:16PM -0700, Andres Freund wrote:
> IMO the submission should include why automating requires these changes (yours
> doesn't really either). I can probably figure it out if I stare a bit at the
> code and read the other thread - but I shouldn't need to.
Hm? My previou
Hi,
On 2023-05-16 07:30:54 +0900, Michael Paquier wrote:
> On Mon, May 15, 2023 at 11:29:56AM -0700, Andres Freund wrote:
> > Without an explanation for why this change is needed for [1], it's hard to
> > give useful feedback...
>
> The point is to integrate the wait event classes for buffer pin
Hi,
On 2023-05-15 14:20:24 +0900, Michael Paquier wrote:
> On Thu, May 11, 2023 at 01:28:40PM +0900, Michael Paquier wrote:
> > On Tue, May 09, 2023 at 09:48:24AM -0700, Andres Freund wrote:
> >> On 2023-05-08 12:11:17 -0700, Andres Freund wrote:
> >>> I can reproduce a significant regression due
On Mon, May 15, 2023 at 12:33:17PM +0200, Alvaro Herrera wrote:
> But make_ctags is *our* script, so I think this rule applies to them as
> well. (In any case, what can be hurt? We're not going to add any files
> to git named "tags" anyway.)
Yes, you have a point about the origin of the script g
On Mon, May 15, 2023 at 11:36 PM Robert Sjöblom
wrote:
>
>
>
> On 2023-05-05 15:17, Robert Sjöblom wrote:
> >
> > Hi,
> >
> > We have recently used the PostgreSQL documentation when setting up our
> > logical replication. We noticed there was a step missing in the
> > documentation on how to drop
Hi,
On 2023-05-15 15:30:28 -0700, Andres Freund wrote:
> As soon as either the pg_ctl for the start, or the whole bash invocation, has
> stdin redirected, the problem vanishes.
For a moment I thought this could be related to InheritStdHandles() - but no,
it doesn't make a difference.
There's loa
On Mon, May 15, 2023 at 11:23:18PM +0300, Marina Polyakova wrote:
> On 2023-05-15 19:16, Tom Lane wrote:
>> Hmm. I'd actually fix the blame on transactions.sql here. Creating
>> a table named as generically as "abc" is horribly bad practice in
>> a set of concurrent tests. namespace.sql is argua
On Mon, May 15, 2023 at 11:29:56AM -0700, Andres Freund wrote:
> Without an explanation for why this change is needed for [1], it's hard to
> give useful feedback...
The point is to integrate the wait event classes for buffer pin and
extension into the txt file that automates the creation of the S
Hi,
On 2023-05-15 13:13:26 -0700, Andres Freund wrote:
> It wouldn't really - the echo $? inside the system() would report the
> error. Which it doesn't - note the "0" in the second output.
Ah. Interesting. Part of the issue is perl (or msys?) swalling some error
details.
I could see more detail
Hi,
Thanks for your review!
On Sat, 13 May 2023 23:47:53 +0200
Tomas Vondra wrote:
> Thanks for the patches. A couple mostly minor comments, to complement
> Melanie's review:
>
> 0001
>
> I'm not really sure about calling this "hybrid hash-join". What does it
> even mean? The new comments sim
On Mon, 2023-05-08 at 14:59 -0700, Jeff Davis wrote:
> The easiest thing to do is revert it for now, and after we sort out
> the
> memcmp() path for the ICU provider, then I can commit it again (after
> that point it would just be code cleanup and should have no
> functional
> impact).
The convers
On Sat, 2023-05-13 at 13:00 +0300, Alexander Lakhin wrote:
> On the current master (after 455f948b0, and before f7faa9976, of
> course)
> I get an ASAN-detected failure with the following query:
> CREATE COLLATION col (provider = icu, locale = '123456789012');
>
Thank you for the report!
ICU sou
On 2023-05-15 19:16, Tom Lane wrote:
Marina Polyakova writes:
IIUC the conflict was caused by
+SET search_path to public, test_ns_schema_1;
+CREATE SCHEMA test_ns_schema_2
+ CREATE VIEW abc_view AS SELECT a FROM abc;
because the parallel regression test transactions had already crea
Hi,
On 2023-05-15 16:01:39 -0400, Andrew Dunstan wrote:
> On 2023-05-15 Mo 15:38, Andres Freund wrote:
> > Hi,
> >
> > On 2023-05-05 07:08:39 -0400, Andrew Dunstan wrote:
> > > If you want to play I can arrange access.
> > Andrew did - thanks!
> >
> >
> > A first observeration is that making th
On Mon, May 15, 2023 at 04:27:04PM +0900, Michael Paquier wrote:
> On Fri, May 12, 2023 at 04:35:34PM +0200, Peter Eisentraut wrote:
>> it's not intuitive whether foo becomes a member of bar or bar becomes a
>> member of foo. Maybe something more verbose like --member-of would help?
>
> Indeed, p
On Mon, May 15, 2023 at 9:37 PM Magnus Hagander wrote:
>
> The pginfra team is about to begin an upgrade of git.postgresql.org to
> a new version of debian. During the operation there may be some
> intermittent outages -- we will let you know once the upgrade is
> complete.
This upgrade has now b
On 2023-05-15 Mo 15:38, Andres Freund wrote:
Hi,
On 2023-05-05 07:08:39 -0400, Andrew Dunstan wrote:
If you want to play I can arrange access.
Andrew did - thanks!
A first observeration is that making the shell command slightly more
complicated, by echoing $? after pg_ctl, prevents the erro
Hi,
On 2023-05-05 07:08:39 -0400, Andrew Dunstan wrote:
> If you want to play I can arrange access.
Andrew did - thanks!
A first observeration is that making the shell command slightly more
complicated, by echoing $? after pg_ctl, prevents the error:
/usr/bin/perl -e 'system(qq{"bin/pg_ctl" -D
The pginfra team is about to begin an upgrade of git.postgresql.org to
a new version of debian. During the operation there may be some
intermittent outages -- we will let you know once the upgrade is
complete.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.co
On Tue, Apr 25, 2023 at 03:18:44PM +0900, Michael Paquier wrote:
> On Mon, Apr 24, 2023 at 09:52:21AM -0700, Nathan Bossart wrote:
>> I think this can wait for v17, but if there's a strong argument for doing
>> some of this sooner, we can reevaluate.
>
> FWIW, I agree to hold on this stuff for v17
On Mon, May 15, 2023 at 2:05 PM Matthias van de Meent
wrote:
> > Add SET PERFORMANCE_TIPS option to suggest INDEX, VACUUM, VACUUM ANALYZE,
> > and CLUSTER
> > -> There are external tools that help with this kind of analysis
>
> Althrough there are external tools which help with the analysis, the
Hi,
On 2023-05-15 10:07:04 +0200, Drouvot, Bertrand wrote:
> Please find attached a patch to $SUBJECT.
>
> This is preliminary work to autogenerate some wait events
> code and documentation done in [1].
>
> The patch introduces 2 new "wait events" (WAIT_EVENT_EXTENSION
> and WAIT_EVENT_BUFFER_PI
Robert Haas writes:
> On Sat, May 13, 2023 at 12:42 AM John Naylor
> wrote:
>> Add support for polymorphic arguments and return types to languages other
>> than PL/PgSQL
>> -> Seems if someone needed this, they would say so (no thread).
>>
>> Add support for OUT and INOUT parameters to language
On Sat, 13 May 2023 at 06:42, John Naylor wrote:
>
>
> On Mon, Feb 6, 2023 at 11:04 AM John Naylor
> wrote:
> > I'll try to get back to culling the list items at the end of April.
>
> I've made another pass at this. Previously, I went one or two sections at a
> time, but this time I tried just
On Sat, May 13, 2023 at 12:42 AM John Naylor
wrote:
> Add support for polymorphic arguments and return types to languages other
> than PL/PgSQL
> -> Seems if someone needed this, they would say so (no thread).
>
> Add support for OUT and INOUT parameters to languages other than PL/PgSQL
> -> Ditt
On Fri, May 12, 2023 at 9:53 AM Stephen Frost wrote:
> While I tend to agree that 1GB is too small, 1TB seems like it's
> possibly going to end up on the too big side of things, or at least,
> if we aren't getting rid of the segment code then it's possibly throwing
> away the benefits we have from
On Fri, May 12, 2023 at 4:02 PM Thomas Munro wrote:
> On Sat, May 13, 2023 at 4:41 AM MARK CALLAGHAN wrote:
> > Repeating what was mentioned on Twitter, because I had some experience
> with the topic. With fewer files per table there will be more contention on
> the per-inode mutex (which might
On Sat, May 13, 2023 at 01:31:21AM -0400, Tom Lane wrote:
> John Naylor writes:
> > I've made another pass at this. Previously, I went one or two sections at a
> > time, but this time I tried just skimming the whole thing and noting what
> > jumps out at me. Also, I've separated things into three
Marina Polyakova writes:
> IIUC the conflict was caused by
> +SET search_path to public, test_ns_schema_1;
> +CREATE SCHEMA test_ns_schema_2
> + CREATE VIEW abc_view AS SELECT a FROM abc;
> because the parallel regression test transactions had already created
> the table abc and was tryin
Hello, hackers!
When running tests for version 15, we found a conflict between
regression tests namespace & transactions due to recent changes [1].
diff -w -U3 .../src/test/regress/expected/transactions.out
.../src/bin/pg_upgrade/tmp_check/results/transactions.out
--- .../src/test/regress/ex
On Mon, May 15, 2023 at 6:14 PM Masahiko Sawada wrote:
>
> On Mon, May 15, 2023 at 1:49 PM Thomas Munro wrote:
> >
> > On Fri, May 12, 2023 at 11:58 PM Bharath Rupireddy
> > wrote:
> > > Andres, rightly put it - 'mis-using' CV infrastructure. It is simple,
> > > works, and makes the WalSndWakeup
Alvaro Herrera writes:
> It's worth considering what will readline history do with the comment.
> As I recall, we keep /* comments */ together with the query that
> follows, but the -- comments are keep in a separate history entry.
> So that's one more reason to prefer /* */
Good point.
> (To m
On Sun, 14 May 2023 00:10:00 +0200
Tomas Vondra wrote:
> On 5/12/23 23:36, Melanie Plageman wrote:
> > Thanks for continuing to work on this.
> >
> > Are you planning to modify what is displayed for memory usage in
> > EXPLAIN ANALYZE?
Yes, I already start to work on this. Tracking spilling mem
On 2023-May-15, Tom Lane wrote:
> Laurenz Albe writes:
> > On Mon, 2023-05-15 at 08:37 +0200, Pavel Stehule wrote:
> >> This looks little bit strange
> >>
> >> What about /* comments
> >> Like
> >> /*** Query /
> >> Or just
> >> Query
>
> > +1 for either of Pavel's
Laurenz Albe writes:
> On Mon, 2023-05-15 at 08:37 +0200, Pavel Stehule wrote:
>> This looks little bit strange
>>
>> What about /* comments
>> Like
>> /*** Query /
>> Or just
>> Query
> +1 for either of Pavel's suggestions.
+1. Probably the slash-star way would b
On Fri, 24 Mar 2023 at 19:37, Robert Haas wrote:
> > > > I think there's some important tests missing related to this:
> > > > 1. Ensuring that SECURITY_RESTRICTED_OPERATION things are enforced
> > > > when the user **does not** have SET ROLE permissions to the
> > > > subscription owner, e.g. don
On Mon, May 15, 2023 at 04:33:27PM +0900, Michael Paquier wrote:
> On Thu, May 11, 2023 at 09:34:42AM -0400, Bruce Momjian wrote:
> > On Thu, May 11, 2023 at 02:21:22PM +0200, Daniel Gustafsson wrote:
> >> IIRC there were a number of ideas presented in that thread but backwards
> >> compatibility w
On Mon, 15 May 2023 at 14:47, Masahiko Sawada wrote:
> Thank you for the patch! I think we might want to have tests for it.
Yes, code looks good. But indeed some tests would be great. It seems
we forgot to actually do:
On Fri, 12 May 2023 at 13:55, Ajin Cherian wrote:
> CREATE ROLE regress_alic
On 2023-05-05 15:17, Robert Sjöblom wrote:
Hi,
We have recently used the PostgreSQL documentation when setting up our
logical replication. We noticed there was a step missing in the
documentation on how to drop a logical replication subscription with a
replication slot attached.
Followin
On Mon, May 15, 2023 at 5:44 PM Ajin Cherian wrote:
>
> On Fri, May 12, 2023 at 9:55 PM Ajin Cherian wrote:
> >
> > If nobody else is working on this, I can come up with a patch to fix this
> >
>
> Attaching a patch which attempts to fix this.
>
Thank you for the patch! I think we might want to
On Mon, May 15, 2023 at 1:49 PM Thomas Munro wrote:
>
> On Fri, May 12, 2023 at 11:58 PM Bharath Rupireddy
> wrote:
> > Andres, rightly put it - 'mis-using' CV infrastructure. It is simple,
> > works, and makes the WalSndWakeup() easy solving the performance
> > regression.
>
> Yeah, this seems O
On 2023-May-14, Tom Lane wrote:
> Steve Chavez writes:
> > In this case I just propose adding 'tags'. I believe it's reasonable to
> > ignore these as they're produced by make_ctags.
>
> Our policy on this is that the project's .gitignore files should ignore
> files that are produced by our stan
On 11.05.23 23:29, Jeff Davis wrote:
New patch series attached.
=== 0001: fix bug that allows creating hidden collations
Bug:
https://www.postgresql.org/message-id/051c9395cf880307865ee8b17acdbf7f838c1e39.ca...@j-davis.com
This is still being debated in the other thread. Not really related t
On 2023-May-07, Tomas Vondra wrote:
> > Álvaro wrote:
> >> In backbranches, the new field to BrinMemTuple needs to be at the end of
> >> the struct, to avoid ABI breakage.
>
> Unfortunately, this is not actually possible :-(
>
> The BrinMemTuple has a FLEXIBLE_ARRAY_MEMBER at the end, so we can'
> On 30 Mar 2023, at 22:29, Tom Lane wrote:
> Well, we could do "select rolname from pg_roles order by 1" and
> actually compare the results of the two selects. That might be
> advisable anyway, in order to produce a complaint with useful
> detail when there is something wrong.
I took a look at
On Fri, May 12, 2023 at 9:55 PM Ajin Cherian wrote:
>
> If nobody else is working on this, I can come up with a patch to fix this
>
Attaching a patch which attempts to fix this.
regards,
Ajin Cherian
Fujitsu Australia
v1-0001-Fix-issue-where-the-copy-command-does-not-adhere-.patch
Description:
Hi,
On 5/15/23 4:19 AM, Zhijie Hou (Fujitsu) wrote:
On Friday, May 12, 2023 7:58 PM Bharath Rupireddy
wrote:
On Wed, May 10, 2023 at 3:23 PM Drouvot, Bertrand
That's not the case with the attached v2 patch. Please have a look.
Thanks for V2! It does look good to me and I like the fact t
Hi,
On 5/6/23 4:23 AM, Michael Paquier wrote:
On Thu, May 04, 2023 at 08:39:49AM +0200, Drouvot, Bertrand wrote:
On 5/1/23 1:59 AM, Michael Paquier wrote:
I'm not sure I like it. First, it does break the "Note" ordering as compare
to the current documentation. That's not a big deal though.
Sec
Hi hackers,
Please find attached a patch to $SUBJECT.
This is preliminary work to autogenerate some wait events
code and documentation done in [1].
The patch introduces 2 new "wait events" (WAIT_EVENT_EXTENSION
and WAIT_EVENT_BUFFER_PIN) and their associated functions
(pgstat_get_wait_extension
> On 15 May 2023, at 09:45, Michael Paquier wrote:
> On Thu, May 11, 2023 at 11:57:37AM +0200, Daniel Gustafsson wrote:
>> Looking at the snprintf sites made me remember a patchset I worked on last
>> year
>> (but I don't remember if I ended up submitting); there is no need to build
>> one
>> o
On Mon, 2023-05-15 at 08:37 +0200, Pavel Stehule wrote:
> Dne po 15. 5. 2023 8:01 uživatel Kirk Wolak napsal:
> > This would be a trivial change. Willing to do it, and push it.
> >
> > In effect, we have this GREAT feature:
> > \set ECHO_HIDDON on
> >
> > Which outputs a bunch of queries (as yo
On Thu, May 11, 2023 at 11:57:37AM +0200, Daniel Gustafsson wrote:
> I think it's intentionally done in 73b9952e82 as defensive coding, and given
> that this is far from a hot codepath I think leaving them is better.
>
> Instead I think it would be more worthwhile to remove these snprintf() made
>
Hi Kuroda-san.
I looked at the latest patch v13-0001. Here are some minor comments.
==
src/bin/pg_upgrade/info.c
1. get_logical_slot_infos_per_db
I noticed that the way this is coded, 'ntups' and 'num_slots' seems to
have exactly the same meaning. IMO you can simplify this by removing
'ntup
On Thu, May 11, 2023 at 09:34:42AM -0400, Bruce Momjian wrote:
> On Thu, May 11, 2023 at 02:21:22PM +0200, Daniel Gustafsson wrote:
>> IIRC there were a number of ideas presented in that thread but backwards
>> compatibility with --role already "taken" made it complicated, so --role and
>> --member
On Fri, May 12, 2023 at 04:35:34PM +0200, Peter Eisentraut wrote:
> it's not intuitive whether foo becomes a member of bar or bar becomes a
> member of foo. Maybe something more verbose like --member-of would help?
Indeed, presented like that it could be confusing, and --member-of
sounds like it
On Mon, May 15, 2023 at 2:37 AM Pavel Stehule
wrote:
> Hi
>
> Dne po 15. 5. 2023 8:01 uživatel Kirk Wolak napsal:
>
>> This would be a trivial change. Willing to do it, and push it.
>>
>> In effect, we have this GREAT feature:
>> \set ECHO_HIDDON on
>> -- **
>>
>> Kirk..
On Mon, May 15, 2023 at 03:22:29PM +1200, Thomas Munro wrote:
> LGTM.
Thanks, fixed!
--
Michael
signature.asc
Description: PGP signature
75 matches
Mail list logo
